You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Alex Herbert <ah...@apache.org> on 2022/10/05 10:25:27 UTC
[VOTE][RC1] Release Commons RNG 1.5
We have fixed quite a few bugs and added some significant enhancements
since Apache Commons RNG 1.4 was released, so I would like to release
Apache Commons RNG 1.5.
Apache Commons RNG 1.5 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1 (svn
revision 57177)
https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/
The Git tag commit for this RC is commons-rng-1.5-RC1 which you can browse
here:
https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commit;h=commons-rng-1.5-RC1
You may checkout this tag using:
git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch
commons-rng-1.5-RC1 commons-rng-1.5-RC1
(signature can be checked from git using 'git tag -v commons-rng-1.5-RC1')
Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/
These are the artifacts and their hashes:
#Release SHA-512s
#Tue Oct 04 13:00:24 BST 2022
commons-rng-1.5-bin.tar.gz=9e98092cb123a1873cc4ab05ebd87681b9f5fe171ad53cd00488c33e0ab2c7fb8a0bdd9c903a3bde7bc2e4f4035b07cf223b0d921e35d00fcea226ec16f86b5c
commons-rng-1.5-bin.zip=ad01629da0ef089641c4a7a8fed8e2dd9f1ed0fec3e9cc6fd19df22e0516bc8c1a4699a8d2104b5878a13ad9fbec724b85ca0a71c1e3027673cbcab8a5911b30
commons-rng-1.5-src.tar.gz=7fdfcd9ee43ac51f73eb6781d8fae7f313bf20658af84383ff791779def56c690458b99f2e996ce7fec8588db3218f23eea6dc6c2ff7d692f4209b78eb4b4dd8
commons-rng-1.5-src.zip=e1624601d449eecca660839b592c4deb7386ef77a09d613002e8220149f244cbb5bc70c08100fe27eb0d448efea7aef8ac1ebe26f416d846ba3bccd4f43d82e5
Signatures may be validated on a system supporting a bash unix shell by
executing:
svn co https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/
cd 1.5-RC1
chmod +x ./signature-validator.sh
for m in client-api core simple sampling bom; do
./signature-validator.sh
https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/commons-rng-${m}/1.5/;
done
The source code contains examples that are not part of the public API.
These examples contain Java 11 modules and are enabled using a profile (see
below).
Note: Testing randomness using statistical thresholds results in failures
at a given probability. The 'maven-surefire-plugin' is configured to re-run
tests that fail, and pass the build if they succeed within the allotted
number of reruns (the test will be marked as 'flaky' in the report).
I have tested this with 'mvn clean install' using:
Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Maven home: /usr/local/apache-maven-3
Java version: 1.8.0_333, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/jdk1.8.0_333/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family:
"unix"
I have tested this with 'mvn clean package site site:stage
-Pcommons-rng-examples' using:
Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Maven home: /usr/local/apache-maven-3
Java version: 11.0.16, vendor: Ubuntu, runtime:
/usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family:
"unix"
Details of changes since 1.4 are in the release notes:
https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/RELEASE-NOTES.txt
https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/changes-report.html
Site:
https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/index.html
(note some *relative* links are broken and the 1.5 directories are not
yet created - these will be OK once the site is deployed.)
JApiCmp Report (compared to 1.4):
https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-client-api/japicmp.html
https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/japicmp.html
https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-simple/japicmp.html
https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-sampling/japicmp.html
RevApi Report (compared to 1.4):
https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-client-api/revapi-report.html
https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/revapi-report.html
https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-simple/revapi-report.html
https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-sampling/revapi-report.html
RAT Report:
https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/rat-report.html
KEYS:
https://www.apache.org/dist/commons/KEYS
Please review the release candidate and vote.
This vote will close no sooner than 72 hours from now.
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Thank you,
Alex Herbert,
Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567)
The following is intended as a helper and refresher for reviewers.
Validating a release candidate
==============================
These guidelines are NOT complete.
Requirements: Git, Java, Maven.
You can validate a release from a release candidate (RC) tag as follows.
1) Extract the .tar.gz or .zip source archive from the release artifacts.
unzip commons-rng-1.5-src.zip
cd commons-rng-1.5-src
Alternatively clone and checkout the RC tag
git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch
commons-rng-1.5-RC1 commons-rng-1.5-RC1
cd commons-rng-1.5-RC1
2) Check Apache licenses
This step is not required if the site includes a RAT report page which you
then must check.
mvn apache-rat:check
3) Check binary compatibility
Newer components use JApiCmp with the japicmp Maven Profile:
This step is not required if the site includes a JApiCmp report page which
you then must check.
mvn install -DskipTests -P japicmp japicmp:cmp
4) Build the package
mvn -V clean verify
You can record the Maven and Java version produced by -V in your VOTE reply.
To gather OS information from a command line:
Windows: ver
Linux: uname -a
5) Build the site for a multi-module project
mvn package site site:stage
Check the site reports in:
- Windows: target\site\index.html
- Linux: target/site/index.html
-the end-
Re: [VOTE][RC1] Release Commons RNG 1.5
Posted by Alex Herbert <al...@gmail.com>.
On Wed, 5 Oct 2022 at 17:07, Gary Gregory <ga...@gmail.com> wrote:
> There is nothing at for
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/japicmp.html
>
> Thoughts?
> Gary
>
Thanks for highlighting this. It is due to moving method implementations
from a class to the declaring interface (default methods) and was discussed
on the mailing list.
JapiCmp is disabled for the core component. RevApi was added as a
replacement and is enabled, see:
https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/revapi-report.html
Reason:
The core module implements the interface definitions in the client-api
module. This release changed the interface definitions to have default
method implementations as the component is now using Java 8. This was done
by moving the methods from an abstract base class in the core module to the
client-api module. The methods in the core module have been removed as they
are redundant (the code was exactly the same).
JApiCmp does not like this and will fail the build. RevApi allows it [1]
and you can see that in the report (search
for java.method.movedToSuperClass under 'Changes Not Affecting The API').
I have tested binary compatibility for code built against release 1.4. If
you run against core:1.5 and client-api:1.5 then the code is ok. But if you
run against core:1.5 and client-api:1.4 then there will be a linkage error
as the moved method is not available. This is why I wanted to create a BOM
for the modules to be explicit that the versions have to be matched to
maintain binary compatibility.
I decided to disable JApiCmp only on this component as the configuration to
add specific suppressions is limited in JApiCmp. The suppressions are
global and in this case the removal of a method implementation (which is
the error JApiCmp detects) is not something we want to suppress.
If we wish to lower the upgrade path for users then the removed methods can
be added back to the core module. This will add code redundancy. But I
convinced myself with testing that the change is binary and source
compatible. The issue seems to be in JApiCmp.
Alex
[1]
https://revapi.org/revapi-java/0.27.0/differences.html#java.method.movedToSuperClass
Re: [VOTE][RC1] Release Commons RNG 1.5
Posted by Gary Gregory <ga...@gmail.com>.
There is nothing at for
https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/japicmp.html
Thoughts?
Gary
On Wed, Oct 5, 2022, 06:25 Alex Herbert <ah...@apache.org> wrote:
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons RNG 1.4 was released, so I would like to release
> Apache Commons RNG 1.5.
>
> Apache Commons RNG 1.5 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1 (svn
> revision 57177)
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/
>
> The Git tag commit for this RC is commons-rng-1.5-RC1 which you can browse
> here:
>
>
> https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commit;h=commons-rng-1.5-RC1
>
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch
> commons-rng-1.5-RC1 commons-rng-1.5-RC1
> (signature can be checked from git using 'git tag -v commons-rng-1.5-RC1')
>
> Maven artifacts are here:
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Tue Oct 04 13:00:24 BST 2022
>
> commons-rng-1.5-bin.tar.gz=9e98092cb123a1873cc4ab05ebd87681b9f5fe171ad53cd00488c33e0ab2c7fb8a0bdd9c903a3bde7bc2e4f4035b07cf223b0d921e35d00fcea226ec16f86b5c
>
> commons-rng-1.5-bin.zip=ad01629da0ef089641c4a7a8fed8e2dd9f1ed0fec3e9cc6fd19df22e0516bc8c1a4699a8d2104b5878a13ad9fbec724b85ca0a71c1e3027673cbcab8a5911b30
>
> commons-rng-1.5-src.tar.gz=7fdfcd9ee43ac51f73eb6781d8fae7f313bf20658af84383ff791779def56c690458b99f2e996ce7fec8588db3218f23eea6dc6c2ff7d692f4209b78eb4b4dd8
>
> commons-rng-1.5-src.zip=e1624601d449eecca660839b592c4deb7386ef77a09d613002e8220149f244cbb5bc70c08100fe27eb0d448efea7aef8ac1ebe26f416d846ba3bccd4f43d82e5
>
> Signatures may be validated on a system supporting a bash unix shell by
> executing:
> svn co https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/
> cd 1.5-RC1
> chmod +x ./signature-validator.sh
> for m in client-api core simple sampling bom; do
> ./signature-validator.sh
>
> https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/commons-rng-${m}/1.5/
> ;
> done
>
> The source code contains examples that are not part of the public API.
> These examples contain Java 11 modules and are enabled using a profile (see
> below).
>
> Note: Testing randomness using statistical thresholds results in failures
> at a given probability. The 'maven-surefire-plugin' is configured to re-run
> tests that fail, and pass the build if they succeed within the allotted
> number of reruns (the test will be marked as 'flaky' in the report).
>
> I have tested this with 'mvn clean install' using:
>
> Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> Maven home: /usr/local/apache-maven-3
> Java version: 1.8.0_333, vendor: Oracle Corporation, runtime:
> /usr/lib/jvm/jdk1.8.0_333/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family:
> "unix"
>
> I have tested this with 'mvn clean package site site:stage
> -Pcommons-rng-examples' using:
>
> Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> Maven home: /usr/local/apache-maven-3
> Java version: 11.0.16, vendor: Ubuntu, runtime:
> /usr/lib/jvm/java-11-openjdk-amd64
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family:
> "unix"
>
> Details of changes since 1.4 are in the release notes:
>
>
> https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/RELEASE-NOTES.txt
>
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/changes-report.html
>
> Site:
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/index.html
> (note some *relative* links are broken and the 1.5 directories are not
> yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.4):
>
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-client-api/japicmp.html
>
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/japicmp.html
>
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-simple/japicmp.html
>
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-sampling/japicmp.html
>
> RevApi Report (compared to 1.4):
>
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-client-api/revapi-report.html
>
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/revapi-report.html
>
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-simple/revapi-report.html
>
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-sampling/revapi-report.html
>
> RAT Report:
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/rat-report.html
>
> KEYS:
> https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thank you,
>
> Alex Herbert,
> Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567)
>
> The following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Extract the .tar.gz or .zip source archive from the release artifacts.
>
> unzip commons-rng-1.5-src.zip
> cd commons-rng-1.5-src
>
> Alternatively clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch
> commons-rng-1.5-RC1 commons-rng-1.5-RC1
> cd commons-rng-1.5-RC1
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you
> then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page which
> you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean verify
>
> You can record the Maven and Java version produced by -V in your VOTE
> reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a multi-module project
>
> mvn package site site:stage
>
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> -the end-
>
[VOTE][RESULT] Release Commons RNG 1.5 based on RC1
Posted by Alex Herbert <ah...@apache.org>.
This vote passes with the following votes:
+1: Gilles Sadowski (binding)
+1: Bruno Kinoshita (binding)
+1: Alex Herbert (binding)
Thank you to the reviewers. I will proceed with the release promotion.
Alex
Re: [VOTE][RC1] Release Commons RNG 1.5
Posted by Bruno Kinoshita <ki...@apache.org>.
(I mean, to customize RNG's CONTRIBUTING.md to add that info, not the
templated file from the parent or release-plugin)
On Tue, 11 Oct 2022 at 09:37, Bruno Kinoshita <ki...@apache.org> wrote:
> Hi Alex,
>
> The updated changes report looks great!
>
> The Unit Tests [2] looks really useful to new contributors. I think our
> CONTRIBUTING.md files are generated automatically, but perhaps there's a
> way to add a link there to the developers.html page some day?
>
> Cheers
> Bruno
>
> On Tue, 11 Oct 2022 at 01:53, Alex Herbert <al...@gmail.com>
> wrote:
>
>> On Mon, 10 Oct 2022 at 09:22, Alex Herbert <al...@gmail.com>
>> wrote:
>> >
>> >
>> > On Mon, 10 Oct 2022 at 08:26, Bruno Kinoshita <ki...@apache.org> wrote:
>> >>
>> >>
>> >> Changes report
>> >> look OK too, confirmed the Java version in the description. The text
>> could
>> >> be probably trimmed a little (see the changes-report.html in the parent
>> >> site), but not a blocker.
>> >>
>>
>> I have updated the changes.xml to simplify the description. The new
>> changes report is now live here [1].
>>
>> A new paragraph has been added to the developer guide to capture the
>> previous text regarding the configuration of the surefire plugin
>> (under 'Unit Tests' [2]).
>>
>> The user guide contains all the other information about the various
>> modules: the lack of compatibility for the examples, and the potential
>> to block direct usage of the core module using JPMS [3]; and the
>> behavioural compatibility of number generation [4].
>>
>> Alex
>>
>> [1] https://commons.apache.org/proper/commons-rng/changes-report.html
>> [2]
>> https://commons.apache.org/proper/commons-rng/developers.html#Unit_Tests
>> [3]
>> https://commons.apache.org/proper/commons-rng/userguide/rng.html#a1._Purpose
>> [4]
>> https://commons.apache.org/proper/commons-rng/userguide/rng.html#a7._Release_compatibility
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
Re: [VOTE][RC1] Release Commons RNG 1.5
Posted by Bruno Kinoshita <ki...@apache.org>.
Hi Alex,
The updated changes report looks great!
The Unit Tests [2] looks really useful to new contributors. I think our
CONTRIBUTING.md files are generated automatically, but perhaps there's a
way to add a link there to the developers.html page some day?
Cheers
Bruno
On Tue, 11 Oct 2022 at 01:53, Alex Herbert <al...@gmail.com> wrote:
> On Mon, 10 Oct 2022 at 09:22, Alex Herbert <al...@gmail.com>
> wrote:
> >
> >
> > On Mon, 10 Oct 2022 at 08:26, Bruno Kinoshita <ki...@apache.org> wrote:
> >>
> >>
> >> Changes report
> >> look OK too, confirmed the Java version in the description. The text
> could
> >> be probably trimmed a little (see the changes-report.html in the parent
> >> site), but not a blocker.
> >>
>
> I have updated the changes.xml to simplify the description. The new
> changes report is now live here [1].
>
> A new paragraph has been added to the developer guide to capture the
> previous text regarding the configuration of the surefire plugin
> (under 'Unit Tests' [2]).
>
> The user guide contains all the other information about the various
> modules: the lack of compatibility for the examples, and the potential
> to block direct usage of the core module using JPMS [3]; and the
> behavioural compatibility of number generation [4].
>
> Alex
>
> [1] https://commons.apache.org/proper/commons-rng/changes-report.html
> [2]
> https://commons.apache.org/proper/commons-rng/developers.html#Unit_Tests
> [3]
> https://commons.apache.org/proper/commons-rng/userguide/rng.html#a1._Purpose
> [4]
> https://commons.apache.org/proper/commons-rng/userguide/rng.html#a7._Release_compatibility
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [VOTE][RC1] Release Commons RNG 1.5
Posted by Alex Herbert <al...@gmail.com>.
On Mon, 10 Oct 2022 at 09:22, Alex Herbert <al...@gmail.com> wrote:
>
>
> On Mon, 10 Oct 2022 at 08:26, Bruno Kinoshita <ki...@apache.org> wrote:
>>
>>
>> Changes report
>> look OK too, confirmed the Java version in the description. The text could
>> be probably trimmed a little (see the changes-report.html in the parent
>> site), but not a blocker.
>>
I have updated the changes.xml to simplify the description. The new
changes report is now live here [1].
A new paragraph has been added to the developer guide to capture the
previous text regarding the configuration of the surefire plugin
(under 'Unit Tests' [2]).
The user guide contains all the other information about the various
modules: the lack of compatibility for the examples, and the potential
to block direct usage of the core module using JPMS [3]; and the
behavioural compatibility of number generation [4].
Alex
[1] https://commons.apache.org/proper/commons-rng/changes-report.html
[2] https://commons.apache.org/proper/commons-rng/developers.html#Unit_Tests
[3] https://commons.apache.org/proper/commons-rng/userguide/rng.html#a1._Purpose
[4] https://commons.apache.org/proper/commons-rng/userguide/rng.html#a7._Release_compatibility
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE][RC1] Release Commons RNG 1.5
Posted by Alex Herbert <al...@gmail.com>.
On Mon, 10 Oct 2022 at 08:26, Bruno Kinoshita <ki...@apache.org> wrote:
>
> Changes report
> look OK too, confirmed the Java version in the description. The text could
> be probably trimmed a little (see the changes-report.html in the parent
> site), but not a blocker.
>
>
Thanks Bruno.
For the description there is a lot of detail there. Note it does read
better in the release notes as it is formatted. In the changes report the
new lines are lost and the text is a single paragraph that is hard to read.
If this text is reduced then we should capture it elsewhere.
The description of the module architecture is duplicated in the user guide;
the configuration of the surefire plugin is not recorded anywhere else but
this is something to concern developers and not end users. I can move this
to the 'Developer guide' (see <site url>/commons-rng/developers.html).
Thus the changes description would be more like:
"This is a minor release of Apache Commons RNG, containing a few new
features and performance improvements (requires java 8)"
Alex
Re: [VOTE][RC1] Release Commons RNG 1.5
Posted by Bruno Kinoshita <ki...@apache.org>.
[x] +1 Release these artifacts
Built from tag successfully running `mvn clean install site` on
Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Maven home: /opt/apache-maven-3.8.5
Java version: 17.0.4, vendor: Private Build, runtime:
/usr/lib/jvm/java-17-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.15.0-48-generic", arch: "amd64", family:
"unix"
Manually inspected tar.gz/zip files from binaries and source folders, in
the dist area. Everything looks OK. Signatures look OK too. Changes report
look OK too, confirmed the Java version in the description. The text could
be probably trimmed a little (see the changes-report.html in the parent
site), but not a blocker.
Forgot that it was a multi-module, so built it again with `mvn clean
package site site:stage -Pcommons-rng-examples'`. Site reports look good
(first time seeing a revapi report I think? It looks nice! Maybe they could
use a color that was not read for changes like adding a static field to a
class and leave removals and backward incompatible in a warmer color).
Impressed by the Jacoco reports too, great coverage.
Also had a very brief look at the Maven repository and everything seems to
be OK (expected files are present, non-empty; didn't have time to check
signatures of maven staged repo, sorry).
Thanks!
Bruno
On Mon, 10 Oct 2022 at 19:42, Bruno Kinoshita <ki...@apache.org> wrote:
> I have 20 mins before a quick dinner and meeting. Cloning the repository
> now.
>
> On Mon, 10 Oct 2022 at 19:38, Alex Herbert <ah...@apache.org> wrote:
>
>> Can I get another PMC vote for this please?
>>
>> Thanks,
>>
>> Alex
>>
>> On Wed, 5 Oct 2022 at 11:25, Alex Herbert <ah...@apache.org> wrote:
>>
>> > We have fixed quite a few bugs and added some significant enhancements
>> > since Apache Commons RNG 1.4 was released, so I would like to release
>> > Apache Commons RNG 1.5.
>> >
>> > Apache Commons RNG 1.5 RC1 is available for review here:
>> > https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1 (svn
>> > revision 57177)
>> > https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/
>> >
>> > The Git tag commit for this RC is commons-rng-1.5-RC1 which you can
>> browse
>> > here:
>> >
>> >
>> https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commit;h=commons-rng-1.5-RC1
>> >
>> > You may checkout this tag using:
>> > git clone https://gitbox.apache.org/repos/asf/commons-rng.git
>> > --branch commons-rng-1.5-RC1 commons-rng-1.5-RC1
>> > (signature can be checked from git using 'git tag -v
>> commons-rng-1.5-RC1')
>> >
>> > Maven artifacts are here:
>> >
>> >
>> https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/
>> >
>> > These are the artifacts and their hashes:
>> >
>> > #Release SHA-512s
>> > #Tue Oct 04 13:00:24 BST 2022
>> >
>> >
>> commons-rng-1.5-bin.tar.gz=9e98092cb123a1873cc4ab05ebd87681b9f5fe171ad53cd00488c33e0ab2c7fb8a0bdd9c903a3bde7bc2e4f4035b07cf223b0d921e35d00fcea226ec16f86b5c
>> >
>> >
>> commons-rng-1.5-bin.zip=ad01629da0ef089641c4a7a8fed8e2dd9f1ed0fec3e9cc6fd19df22e0516bc8c1a4699a8d2104b5878a13ad9fbec724b85ca0a71c1e3027673cbcab8a5911b30
>> >
>> >
>> commons-rng-1.5-src.tar.gz=7fdfcd9ee43ac51f73eb6781d8fae7f313bf20658af84383ff791779def56c690458b99f2e996ce7fec8588db3218f23eea6dc6c2ff7d692f4209b78eb4b4dd8
>> >
>> >
>> commons-rng-1.5-src.zip=e1624601d449eecca660839b592c4deb7386ef77a09d613002e8220149f244cbb5bc70c08100fe27eb0d448efea7aef8ac1ebe26f416d846ba3bccd4f43d82e5
>> >
>> > Signatures may be validated on a system supporting a bash unix shell by
>> > executing:
>> > svn co https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/
>> > cd 1.5-RC1
>> > chmod +x ./signature-validator.sh
>> > for m in client-api core simple sampling bom; do
>> > ./signature-validator.sh
>> >
>> https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/commons-rng-${m}/1.5/
>> ;
>> > done
>> >
>> > The source code contains examples that are not part of the public API.
>> > These examples contain Java 11 modules and are enabled using a profile
>> (see
>> > below).
>> >
>> > Note: Testing randomness using statistical thresholds results in
>> failures
>> > at a given probability. The 'maven-surefire-plugin' is configured to
>> re-run
>> > tests that fail, and pass the build if they succeed within the allotted
>> > number of reruns (the test will be marked as 'flaky' in the report).
>> >
>> > I have tested this with 'mvn clean install' using:
>> >
>> > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
>> > Maven home: /usr/local/apache-maven-3
>> > Java version: 1.8.0_333, vendor: Oracle Corporation, runtime:
>> > /usr/lib/jvm/jdk1.8.0_333/jre
>> > Default locale: en_GB, platform encoding: UTF-8
>> > OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family:
>> > "unix"
>> >
>> > I have tested this with 'mvn clean package site site:stage
>> > -Pcommons-rng-examples' using:
>> >
>> > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
>> > Maven home: /usr/local/apache-maven-3
>> > Java version: 11.0.16, vendor: Ubuntu, runtime:
>> > /usr/lib/jvm/java-11-openjdk-amd64
>> > Default locale: en_GB, platform encoding: UTF-8
>> > OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family:
>> > "unix"
>> >
>> > Details of changes since 1.4 are in the release notes:
>> >
>> >
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/RELEASE-NOTES.txt
>> >
>> >
>> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/changes-report.html
>> >
>> > Site:
>> >
>> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/index.html
>> > (note some *relative* links are broken and the 1.5 directories are
>> not
>> > yet created - these will be OK once the site is deployed.)
>> >
>> > JApiCmp Report (compared to 1.4):
>> >
>> >
>> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-client-api/japicmp.html
>> >
>> >
>> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/japicmp.html
>> >
>> >
>> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-simple/japicmp.html
>> >
>> >
>> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-sampling/japicmp.html
>> >
>> > RevApi Report (compared to 1.4):
>> >
>> >
>> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-client-api/revapi-report.html
>> >
>> >
>> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/revapi-report.html
>> >
>> >
>> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-simple/revapi-report.html
>> >
>> >
>> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-sampling/revapi-report.html
>> >
>> > RAT Report:
>> >
>> >
>> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/rat-report.html
>> >
>> > KEYS:
>> > https://www.apache.org/dist/commons/KEYS
>> >
>> > Please review the release candidate and vote.
>> > This vote will close no sooner than 72 hours from now.
>> >
>> > [ ] +1 Release these artifacts
>> > [ ] +0 OK, but...
>> > [ ] -0 OK, but really should fix...
>> > [ ] -1 I oppose this release because...
>> >
>> > Thank you,
>> >
>> > Alex Herbert,
>> > Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567)
>> >
>> > The following is intended as a helper and refresher for reviewers.
>> >
>> > Validating a release candidate
>> > ==============================
>> >
>> > These guidelines are NOT complete.
>> >
>> > Requirements: Git, Java, Maven.
>> >
>> > You can validate a release from a release candidate (RC) tag as follows.
>> >
>> > 1) Extract the .tar.gz or .zip source archive from the release
>> artifacts.
>> >
>> > unzip commons-rng-1.5-src.zip
>> > cd commons-rng-1.5-src
>> >
>> > Alternatively clone and checkout the RC tag
>> >
>> > git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch
>> > commons-rng-1.5-RC1 commons-rng-1.5-RC1
>> > cd commons-rng-1.5-RC1
>> >
>> > 2) Check Apache licenses
>> >
>> > This step is not required if the site includes a RAT report page which
>> you
>> > then must check.
>> >
>> > mvn apache-rat:check
>> >
>> > 3) Check binary compatibility
>> >
>> > Newer components use JApiCmp with the japicmp Maven Profile:
>> >
>> > This step is not required if the site includes a JApiCmp report page
>> which
>> > you then must check.
>> >
>> > mvn install -DskipTests -P japicmp japicmp:cmp
>> >
>> > 4) Build the package
>> >
>> > mvn -V clean verify
>> >
>> > You can record the Maven and Java version produced by -V in your VOTE
>> > reply.
>> > To gather OS information from a command line:
>> > Windows: ver
>> > Linux: uname -a
>> >
>> > 5) Build the site for a multi-module project
>> >
>> > mvn package site site:stage
>> >
>> > Check the site reports in:
>> > - Windows: target\site\index.html
>> > - Linux: target/site/index.html
>> >
>> > -the end-
>> >
>> >
>>
>
Re: [VOTE][RC1] Release Commons RNG 1.5
Posted by Bruno Kinoshita <ki...@apache.org>.
I have 20 mins before a quick dinner and meeting. Cloning the repository
now.
On Mon, 10 Oct 2022 at 19:38, Alex Herbert <ah...@apache.org> wrote:
> Can I get another PMC vote for this please?
>
> Thanks,
>
> Alex
>
> On Wed, 5 Oct 2022 at 11:25, Alex Herbert <ah...@apache.org> wrote:
>
> > We have fixed quite a few bugs and added some significant enhancements
> > since Apache Commons RNG 1.4 was released, so I would like to release
> > Apache Commons RNG 1.5.
> >
> > Apache Commons RNG 1.5 RC1 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1 (svn
> > revision 57177)
> > https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/
> >
> > The Git tag commit for this RC is commons-rng-1.5-RC1 which you can
> browse
> > here:
> >
> >
> https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commit;h=commons-rng-1.5-RC1
> >
> > You may checkout this tag using:
> > git clone https://gitbox.apache.org/repos/asf/commons-rng.git
> > --branch commons-rng-1.5-RC1 commons-rng-1.5-RC1
> > (signature can be checked from git using 'git tag -v
> commons-rng-1.5-RC1')
> >
> > Maven artifacts are here:
> >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/
> >
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Tue Oct 04 13:00:24 BST 2022
> >
> >
> commons-rng-1.5-bin.tar.gz=9e98092cb123a1873cc4ab05ebd87681b9f5fe171ad53cd00488c33e0ab2c7fb8a0bdd9c903a3bde7bc2e4f4035b07cf223b0d921e35d00fcea226ec16f86b5c
> >
> >
> commons-rng-1.5-bin.zip=ad01629da0ef089641c4a7a8fed8e2dd9f1ed0fec3e9cc6fd19df22e0516bc8c1a4699a8d2104b5878a13ad9fbec724b85ca0a71c1e3027673cbcab8a5911b30
> >
> >
> commons-rng-1.5-src.tar.gz=7fdfcd9ee43ac51f73eb6781d8fae7f313bf20658af84383ff791779def56c690458b99f2e996ce7fec8588db3218f23eea6dc6c2ff7d692f4209b78eb4b4dd8
> >
> >
> commons-rng-1.5-src.zip=e1624601d449eecca660839b592c4deb7386ef77a09d613002e8220149f244cbb5bc70c08100fe27eb0d448efea7aef8ac1ebe26f416d846ba3bccd4f43d82e5
> >
> > Signatures may be validated on a system supporting a bash unix shell by
> > executing:
> > svn co https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/
> > cd 1.5-RC1
> > chmod +x ./signature-validator.sh
> > for m in client-api core simple sampling bom; do
> > ./signature-validator.sh
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/commons-rng-${m}/1.5/
> ;
> > done
> >
> > The source code contains examples that are not part of the public API.
> > These examples contain Java 11 modules and are enabled using a profile
> (see
> > below).
> >
> > Note: Testing randomness using statistical thresholds results in failures
> > at a given probability. The 'maven-surefire-plugin' is configured to
> re-run
> > tests that fail, and pass the build if they succeed within the allotted
> > number of reruns (the test will be marked as 'flaky' in the report).
> >
> > I have tested this with 'mvn clean install' using:
> >
> > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> > Maven home: /usr/local/apache-maven-3
> > Java version: 1.8.0_333, vendor: Oracle Corporation, runtime:
> > /usr/lib/jvm/jdk1.8.0_333/jre
> > Default locale: en_GB, platform encoding: UTF-8
> > OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family:
> > "unix"
> >
> > I have tested this with 'mvn clean package site site:stage
> > -Pcommons-rng-examples' using:
> >
> > Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> > Maven home: /usr/local/apache-maven-3
> > Java version: 11.0.16, vendor: Ubuntu, runtime:
> > /usr/lib/jvm/java-11-openjdk-amd64
> > Default locale: en_GB, platform encoding: UTF-8
> > OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family:
> > "unix"
> >
> > Details of changes since 1.4 are in the release notes:
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/RELEASE-NOTES.txt
> >
> >
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/changes-report.html
> >
> > Site:
> >
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/index.html
> > (note some *relative* links are broken and the 1.5 directories are
> not
> > yet created - these will be OK once the site is deployed.)
> >
> > JApiCmp Report (compared to 1.4):
> >
> >
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-client-api/japicmp.html
> >
> >
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/japicmp.html
> >
> >
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-simple/japicmp.html
> >
> >
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-sampling/japicmp.html
> >
> > RevApi Report (compared to 1.4):
> >
> >
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-client-api/revapi-report.html
> >
> >
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/revapi-report.html
> >
> >
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-simple/revapi-report.html
> >
> >
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-sampling/revapi-report.html
> >
> > RAT Report:
> >
> >
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/rat-report.html
> >
> > KEYS:
> > https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote.
> > This vote will close no sooner than 72 hours from now.
> >
> > [ ] +1 Release these artifacts
> > [ ] +0 OK, but...
> > [ ] -0 OK, but really should fix...
> > [ ] -1 I oppose this release because...
> >
> > Thank you,
> >
> > Alex Herbert,
> > Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567)
> >
> > The following is intended as a helper and refresher for reviewers.
> >
> > Validating a release candidate
> > ==============================
> >
> > These guidelines are NOT complete.
> >
> > Requirements: Git, Java, Maven.
> >
> > You can validate a release from a release candidate (RC) tag as follows.
> >
> > 1) Extract the .tar.gz or .zip source archive from the release artifacts.
> >
> > unzip commons-rng-1.5-src.zip
> > cd commons-rng-1.5-src
> >
> > Alternatively clone and checkout the RC tag
> >
> > git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch
> > commons-rng-1.5-RC1 commons-rng-1.5-RC1
> > cd commons-rng-1.5-RC1
> >
> > 2) Check Apache licenses
> >
> > This step is not required if the site includes a RAT report page which
> you
> > then must check.
> >
> > mvn apache-rat:check
> >
> > 3) Check binary compatibility
> >
> > Newer components use JApiCmp with the japicmp Maven Profile:
> >
> > This step is not required if the site includes a JApiCmp report page
> which
> > you then must check.
> >
> > mvn install -DskipTests -P japicmp japicmp:cmp
> >
> > 4) Build the package
> >
> > mvn -V clean verify
> >
> > You can record the Maven and Java version produced by -V in your VOTE
> > reply.
> > To gather OS information from a command line:
> > Windows: ver
> > Linux: uname -a
> >
> > 5) Build the site for a multi-module project
> >
> > mvn package site site:stage
> >
> > Check the site reports in:
> > - Windows: target\site\index.html
> > - Linux: target/site/index.html
> >
> > -the end-
> >
> >
>
Re: [VOTE][RC1] Release Commons RNG 1.5
Posted by Alex Herbert <ah...@apache.org>.
Can I get another PMC vote for this please?
Thanks,
Alex
On Wed, 5 Oct 2022 at 11:25, Alex Herbert <ah...@apache.org> wrote:
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons RNG 1.4 was released, so I would like to release
> Apache Commons RNG 1.5.
>
> Apache Commons RNG 1.5 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1 (svn
> revision 57177)
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/
>
> The Git tag commit for this RC is commons-rng-1.5-RC1 which you can browse
> here:
>
> https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commit;h=commons-rng-1.5-RC1
>
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-rng.git
> --branch commons-rng-1.5-RC1 commons-rng-1.5-RC1
> (signature can be checked from git using 'git tag -v commons-rng-1.5-RC1')
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Tue Oct 04 13:00:24 BST 2022
>
> commons-rng-1.5-bin.tar.gz=9e98092cb123a1873cc4ab05ebd87681b9f5fe171ad53cd00488c33e0ab2c7fb8a0bdd9c903a3bde7bc2e4f4035b07cf223b0d921e35d00fcea226ec16f86b5c
>
> commons-rng-1.5-bin.zip=ad01629da0ef089641c4a7a8fed8e2dd9f1ed0fec3e9cc6fd19df22e0516bc8c1a4699a8d2104b5878a13ad9fbec724b85ca0a71c1e3027673cbcab8a5911b30
>
> commons-rng-1.5-src.tar.gz=7fdfcd9ee43ac51f73eb6781d8fae7f313bf20658af84383ff791779def56c690458b99f2e996ce7fec8588db3218f23eea6dc6c2ff7d692f4209b78eb4b4dd8
>
> commons-rng-1.5-src.zip=e1624601d449eecca660839b592c4deb7386ef77a09d613002e8220149f244cbb5bc70c08100fe27eb0d448efea7aef8ac1ebe26f416d846ba3bccd4f43d82e5
>
> Signatures may be validated on a system supporting a bash unix shell by
> executing:
> svn co https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/
> cd 1.5-RC1
> chmod +x ./signature-validator.sh
> for m in client-api core simple sampling bom; do
> ./signature-validator.sh
> https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/commons-rng-${m}/1.5/;
> done
>
> The source code contains examples that are not part of the public API.
> These examples contain Java 11 modules and are enabled using a profile (see
> below).
>
> Note: Testing randomness using statistical thresholds results in failures
> at a given probability. The 'maven-surefire-plugin' is configured to re-run
> tests that fail, and pass the build if they succeed within the allotted
> number of reruns (the test will be marked as 'flaky' in the report).
>
> I have tested this with 'mvn clean install' using:
>
> Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> Maven home: /usr/local/apache-maven-3
> Java version: 1.8.0_333, vendor: Oracle Corporation, runtime:
> /usr/lib/jvm/jdk1.8.0_333/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family:
> "unix"
>
> I have tested this with 'mvn clean package site site:stage
> -Pcommons-rng-examples' using:
>
> Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> Maven home: /usr/local/apache-maven-3
> Java version: 11.0.16, vendor: Ubuntu, runtime:
> /usr/lib/jvm/java-11-openjdk-amd64
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family:
> "unix"
>
> Details of changes since 1.4 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/RELEASE-NOTES.txt
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/changes-report.html
>
> Site:
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/index.html
> (note some *relative* links are broken and the 1.5 directories are not
> yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.4):
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-client-api/japicmp.html
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/japicmp.html
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-simple/japicmp.html
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-sampling/japicmp.html
>
> RevApi Report (compared to 1.4):
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-client-api/revapi-report.html
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/revapi-report.html
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-simple/revapi-report.html
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-sampling/revapi-report.html
>
> RAT Report:
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/rat-report.html
>
> KEYS:
> https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thank you,
>
> Alex Herbert,
> Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567)
>
> The following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Extract the .tar.gz or .zip source archive from the release artifacts.
>
> unzip commons-rng-1.5-src.zip
> cd commons-rng-1.5-src
>
> Alternatively clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch
> commons-rng-1.5-RC1 commons-rng-1.5-RC1
> cd commons-rng-1.5-RC1
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you
> then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page which
> you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean verify
>
> You can record the Maven and Java version produced by -V in your VOTE
> reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a multi-module project
>
> mvn package site site:stage
>
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> -the end-
>
>
Re: [VOTE][RC1] Release Commons RNG 1.5
Posted by Alex Herbert <ah...@apache.org>.
My +1
Alex
On Wed, 5 Oct 2022 at 11:25, Alex Herbert <ah...@apache.org> wrote:
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons RNG 1.4 was released, so I would like to release
> Apache Commons RNG 1.5.
>
> Apache Commons RNG 1.5 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1 (svn
> revision 57177)
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/
>
> The Git tag commit for this RC is commons-rng-1.5-RC1 which you can browse
> here:
>
> https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commit;h=commons-rng-1.5-RC1
>
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-rng.git
> --branch commons-rng-1.5-RC1 commons-rng-1.5-RC1
> (signature can be checked from git using 'git tag -v commons-rng-1.5-RC1')
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Tue Oct 04 13:00:24 BST 2022
>
> commons-rng-1.5-bin.tar.gz=9e98092cb123a1873cc4ab05ebd87681b9f5fe171ad53cd00488c33e0ab2c7fb8a0bdd9c903a3bde7bc2e4f4035b07cf223b0d921e35d00fcea226ec16f86b5c
>
> commons-rng-1.5-bin.zip=ad01629da0ef089641c4a7a8fed8e2dd9f1ed0fec3e9cc6fd19df22e0516bc8c1a4699a8d2104b5878a13ad9fbec724b85ca0a71c1e3027673cbcab8a5911b30
>
> commons-rng-1.5-src.tar.gz=7fdfcd9ee43ac51f73eb6781d8fae7f313bf20658af84383ff791779def56c690458b99f2e996ce7fec8588db3218f23eea6dc6c2ff7d692f4209b78eb4b4dd8
>
> commons-rng-1.5-src.zip=e1624601d449eecca660839b592c4deb7386ef77a09d613002e8220149f244cbb5bc70c08100fe27eb0d448efea7aef8ac1ebe26f416d846ba3bccd4f43d82e5
>
> Signatures may be validated on a system supporting a bash unix shell by
> executing:
> svn co https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/
> cd 1.5-RC1
> chmod +x ./signature-validator.sh
> for m in client-api core simple sampling bom; do
> ./signature-validator.sh
> https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/commons-rng-${m}/1.5/;
> done
>
> The source code contains examples that are not part of the public API.
> These examples contain Java 11 modules and are enabled using a profile (see
> below).
>
> Note: Testing randomness using statistical thresholds results in failures
> at a given probability. The 'maven-surefire-plugin' is configured to re-run
> tests that fail, and pass the build if they succeed within the allotted
> number of reruns (the test will be marked as 'flaky' in the report).
>
> I have tested this with 'mvn clean install' using:
>
> Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> Maven home: /usr/local/apache-maven-3
> Java version: 1.8.0_333, vendor: Oracle Corporation, runtime:
> /usr/lib/jvm/jdk1.8.0_333/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family:
> "unix"
>
> I have tested this with 'mvn clean package site site:stage
> -Pcommons-rng-examples' using:
>
> Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> Maven home: /usr/local/apache-maven-3
> Java version: 11.0.16, vendor: Ubuntu, runtime:
> /usr/lib/jvm/java-11-openjdk-amd64
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family:
> "unix"
>
> Details of changes since 1.4 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/RELEASE-NOTES.txt
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/changes-report.html
>
> Site:
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/index.html
> (note some *relative* links are broken and the 1.5 directories are not
> yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.4):
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-client-api/japicmp.html
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/japicmp.html
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-simple/japicmp.html
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-sampling/japicmp.html
>
> RevApi Report (compared to 1.4):
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-client-api/revapi-report.html
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/revapi-report.html
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-simple/revapi-report.html
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-sampling/revapi-report.html
>
> RAT Report:
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/rat-report.html
>
> KEYS:
> https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thank you,
>
> Alex Herbert,
> Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567)
>
> The following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==============================
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Extract the .tar.gz or .zip source archive from the release artifacts.
>
> unzip commons-rng-1.5-src.zip
> cd commons-rng-1.5-src
>
> Alternatively clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch
> commons-rng-1.5-RC1 commons-rng-1.5-RC1
> cd commons-rng-1.5-RC1
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you
> then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page which
> you then must check.
>
> mvn install -DskipTests -P japicmp japicmp:cmp
>
> 4) Build the package
>
> mvn -V clean verify
>
> You can record the Maven and Java version produced by -V in your VOTE
> reply.
> To gather OS information from a command line:
> Windows: ver
> Linux: uname -a
>
> 5) Build the site for a multi-module project
>
> mvn package site site:stage
>
> Check the site reports in:
> - Windows: target\site\index.html
> - Linux: target/site/index.html
>
> -the end-
>
>
Re: [VOTE][RC1] Release Commons RNG 1.5
Posted by Gilles Sadowski <gi...@gmail.com>.
Hello.
Le jeu. 6 oct. 2022 à 19:01, Alex Herbert <al...@gmail.com> a écrit :
>
> On Thu, 6 Oct 2022 at 16:09, Gilles Sadowski <gi...@gmail.com> wrote:
>
> >
> > > These are the artifacts and their hashes:
> > >
> > > #Release SHA-512s
> > > #Tue Oct 04 13:00:24 BST 2022
> > >
> > commons-rng-1.5-bin.tar.gz=9e98092cb123a1873cc4ab05ebd87681b9f5fe171ad53cd00488c33e0ab2c7fb8a0bdd9c903a3bde7bc2e4f4035b07cf223b0d921e35d00fcea226ec16f86b5c
> > >
> > commons-rng-1.5-bin.zip=ad01629da0ef089641c4a7a8fed8e2dd9f1ed0fec3e9cc6fd19df22e0516bc8c1a4699a8d2104b5878a13ad9fbec724b85ca0a71c1e3027673cbcab8a5911b30
> > >
> > commons-rng-1.5-src.tar.gz=7fdfcd9ee43ac51f73eb6781d8fae7f313bf20658af84383ff791779def56c690458b99f2e996ce7fec8588db3218f23eea6dc6c2ff7d692f4209b78eb4b4dd8
> > >
> > commons-rng-1.5-src.zip=e1624601d449eecca660839b592c4deb7386ef77a09d613002e8220149f244cbb5bc70c08100fe27eb0d448efea7aef8ac1ebe26f416d846ba3bccd4f43d82e5
> > >
> > > Signatures may be validated on a system supporting a bash unix shell by
> > > executing:
> > > svn co https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/
> > > cd 1.5-RC1
> > > chmod +x ./signature-validator.sh
> > > for m in client-api core simple sampling bom; do
> > > ./signature-validator.sh
> > >
> > https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/commons-rng-${m}/1.5/
> > ;
> > > done
> >
> > The output of this script without argument ends with
> > ---CUT---
> > SUCCESSFUL VALIDATION
> > ---CUT---
> > [Of course there are also hints that something went wrong, but the
> > final line is misleading.]
> >
> > Suggestions:
> > 1. Could the validating script be tailored to the corresponding release
> > (i.e. the above lines would be included (together with code that collects
> > all errors if multiple artefacts/modules must be checked)?
> > [The script itself would thus change for each component and release.]
> > 2. The above command line (bash loop) fails (although reporting success
> > as noted above) because the URL is not on the same line as
> > ./signature-validator.sh
> >
> > Signatures checked.
> >
> >
> I've not used the signature-validator script before. I presume it is
> deployed by the commons release plugin. I just pasted in a command that
> worked for me locally.
I presume that the issue stems from a newline having been
added by the editor or mail client.
> I hope that it did pull down artifacts for you.
Yes; I could see the status of "curl" downloading several files.
[By the way, the first came from "curl" not being installed, yet
the script happily produced "SUCCESSFUL VALIDATION".]
> When
> used incorrectly it retrieves the src/bin archives but nothing from the
> nexus repo. In that case it should be made to error but instead it silently
> pulls down nothing and says that (nothing) is OK.
Indeed.
> It could be made to accept multiple arguments for each module to pull them
> all down from the staged nexus repo. The release plugin generates the vote
> email so the command could be added in that. It is something I may look
> into.
>
> However it may not strictly be necessary for the nexus artifacts.
I was wondering about that too.
The script could be simpler if it just focused on the items that will end
up in "dist".
> I think
> nexus validates the artifacts match the checksums anyway. For the first
> release candidate the .asc file did not match the bom artifact and nexus
> had an error when trying to close the repo. So it does at least check the
> .asc files.
>
> The validator does download the source and binary distributions and
> validate those. These are not part of nexus and so it is useful to check
> the official releases.
>
>
> > >
> > > Details of changes since 1.4 are in the release notes:
> > >
> > >
> > https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/RELEASE-NOTES.txt
> > >
> > >
> > https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/changes-report.html
> > >
> > > Site:
> > >
> > https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/index.html
> > > (note some *relative* links are broken and the 1.5 directories are
> > not
> > > yet created - these will be OK once the site is deployed.)
> >
> > Still wondering why the (expectedly broken) site is part of the
> > release review...
> > [It is possible to break the site afterwards too anyways ;-).]
> >
> >
> I think the 'broken links' just refers to links to other apache and commons
> websites (because some are relative and so require the site to be in the
> official location) and also to the 1.5 javadocs. These are not created
> until the vote has passed. But the 'Latest API docs (development)' link
> does work and will take you to the release javadocs.
Yes, I know; but my remark was more general in that there isn't
anything special about the state of the site at the release date or
later on (it may or may not be up-to-date).
Building the site with "mvn" should work of course, but that is checked
by running the command (and possibly looking at the result locally).
Best,
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE][RC1] Release Commons RNG 1.5
Posted by Alex Herbert <al...@gmail.com>.
On Thu, 6 Oct 2022 at 16:09, Gilles Sadowski <gi...@gmail.com> wrote:
>
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Tue Oct 04 13:00:24 BST 2022
> >
> commons-rng-1.5-bin.tar.gz=9e98092cb123a1873cc4ab05ebd87681b9f5fe171ad53cd00488c33e0ab2c7fb8a0bdd9c903a3bde7bc2e4f4035b07cf223b0d921e35d00fcea226ec16f86b5c
> >
> commons-rng-1.5-bin.zip=ad01629da0ef089641c4a7a8fed8e2dd9f1ed0fec3e9cc6fd19df22e0516bc8c1a4699a8d2104b5878a13ad9fbec724b85ca0a71c1e3027673cbcab8a5911b30
> >
> commons-rng-1.5-src.tar.gz=7fdfcd9ee43ac51f73eb6781d8fae7f313bf20658af84383ff791779def56c690458b99f2e996ce7fec8588db3218f23eea6dc6c2ff7d692f4209b78eb4b4dd8
> >
> commons-rng-1.5-src.zip=e1624601d449eecca660839b592c4deb7386ef77a09d613002e8220149f244cbb5bc70c08100fe27eb0d448efea7aef8ac1ebe26f416d846ba3bccd4f43d82e5
> >
> > Signatures may be validated on a system supporting a bash unix shell by
> > executing:
> > svn co https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/
> > cd 1.5-RC1
> > chmod +x ./signature-validator.sh
> > for m in client-api core simple sampling bom; do
> > ./signature-validator.sh
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/commons-rng-${m}/1.5/
> ;
> > done
>
> The output of this script without argument ends with
> ---CUT---
> SUCCESSFUL VALIDATION
> ---CUT---
> [Of course there are also hints that something went wrong, but the
> final line is misleading.]
>
> Suggestions:
> 1. Could the validating script be tailored to the corresponding release
> (i.e. the above lines would be included (together with code that collects
> all errors if multiple artefacts/modules must be checked)?
> [The script itself would thus change for each component and release.]
> 2. The above command line (bash loop) fails (although reporting success
> as noted above) because the URL is not on the same line as
> ./signature-validator.sh
>
> Signatures checked.
>
>
I've not used the signature-validator script before. I presume it is
deployed by the commons release plugin. I just pasted in a command that
worked for me locally. I hope that it did pull down artifacts for you. When
used incorrectly it retrieves the src/bin archives but nothing from the
nexus repo. In that case it should be made to error but instead it silently
pulls down nothing and says that (nothing) is OK.
It could be made to accept multiple arguments for each module to pull them
all down from the staged nexus repo. The release plugin generates the vote
email so the command could be added in that. It is something I may look
into.
However it may not strictly be necessary for the nexus artifacts. I think
nexus validates the artifacts match the checksums anyway. For the first
release candidate the .asc file did not match the bom artifact and nexus
had an error when trying to close the repo. So it does at least check the
.asc files.
The validator does download the source and binary distributions and
validate those. These are not part of nexus and so it is useful to check
the official releases.
> >
> > Details of changes since 1.4 are in the release notes:
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/RELEASE-NOTES.txt
> >
> >
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/changes-report.html
> >
> > Site:
> >
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/index.html
> > (note some *relative* links are broken and the 1.5 directories are
> not
> > yet created - these will be OK once the site is deployed.)
>
> Still wondering why the (expectedly broken) site is part of the
> release review...
> [It is possible to break the site afterwards too anyways ;-).]
>
>
I think the 'broken links' just refers to links to other apache and commons
websites (because some are relative and so require the site to be in the
official location) and also to the 1.5 javadocs. These are not created
until the vote has passed. But the 'Latest API docs (development)' link
does work and will take you to the release javadocs.
Alex
Re: [VOTE][RC1] Release Commons RNG 1.5
Posted by Gilles Sadowski <gi...@gmail.com>.
Hello.
Le mer. 5 oct. 2022 à 12:25, Alex Herbert <ah...@apache.org> a écrit :
>
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons RNG 1.4 was released, so I would like to release
> Apache Commons RNG 1.5.
>
> Apache Commons RNG 1.5 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1 (svn
> revision 57177)
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/
>
> The Git tag commit for this RC is commons-rng-1.5-RC1 which you can browse
> here:
>
> https://gitbox.apache.org/repos/asf?p=commons-rng.git;a=commit;h=commons-rng-1.5-RC1
>
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-rng.git --branch
> commons-rng-1.5-RC1 commons-rng-1.5-RC1
> (signature can be checked from git using 'git tag -v commons-rng-1.5-RC1')
Tag checked.
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Tue Oct 04 13:00:24 BST 2022
> commons-rng-1.5-bin.tar.gz=9e98092cb123a1873cc4ab05ebd87681b9f5fe171ad53cd00488c33e0ab2c7fb8a0bdd9c903a3bde7bc2e4f4035b07cf223b0d921e35d00fcea226ec16f86b5c
> commons-rng-1.5-bin.zip=ad01629da0ef089641c4a7a8fed8e2dd9f1ed0fec3e9cc6fd19df22e0516bc8c1a4699a8d2104b5878a13ad9fbec724b85ca0a71c1e3027673cbcab8a5911b30
> commons-rng-1.5-src.tar.gz=7fdfcd9ee43ac51f73eb6781d8fae7f313bf20658af84383ff791779def56c690458b99f2e996ce7fec8588db3218f23eea6dc6c2ff7d692f4209b78eb4b4dd8
> commons-rng-1.5-src.zip=e1624601d449eecca660839b592c4deb7386ef77a09d613002e8220149f244cbb5bc70c08100fe27eb0d448efea7aef8ac1ebe26f416d846ba3bccd4f43d82e5
>
> Signatures may be validated on a system supporting a bash unix shell by
> executing:
> svn co https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/
> cd 1.5-RC1
> chmod +x ./signature-validator.sh
> for m in client-api core simple sampling bom; do
> ./signature-validator.sh
> https://repository.apache.org/content/repositories/orgapachecommons-1596/org/apache/commons/commons-rng-${m}/1.5/;
> done
The output of this script without argument ends with
---CUT---
SUCCESSFUL VALIDATION
---CUT---
[Of course there are also hints that something went wrong, but the
final line is misleading.]
Suggestions:
1. Could the validating script be tailored to the corresponding release
(i.e. the above lines would be included (together with code that collects
all errors if multiple artefacts/modules must be checked)?
[The script itself would thus change for each component and release.]
2. The above command line (bash loop) fails (although reporting success
as noted above) because the URL is not on the same line as
./signature-validator.sh
Signatures checked.
> [...]
>
> I have tested this with 'mvn clean package site site:stage
> -Pcommons-rng-examples' using:
>
> Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> Maven home: /usr/local/apache-maven-3
> Java version: 11.0.16, vendor: Ubuntu, runtime:
> /usr/lib/jvm/java-11-openjdk-amd64
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-193-generic", arch: "amd64", family:
> "unix"
Build successful:
$ mvn -v
Apache Maven 3.6.3
Maven home: /usr/share/maven
Java version: 11.0.16, vendor: Debian, runtime:
/usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.10.0-17-amd64", arch: "amd64", family: "unix"
>
> Details of changes since 1.4 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/rng/1.5-RC1/RELEASE-NOTES.txt
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/changes-report.html
>
> Site:
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/index.html
> (note some *relative* links are broken and the 1.5 directories are not
> yet created - these will be OK once the site is deployed.)
Still wondering why the (expectedly broken) site is part of the
release review...
[It is possible to break the site afterwards too anyways ;-).]
>
> [...]
>
> RevApi Report (compared to 1.4):
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-client-api/revapi-report.html
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-core/revapi-report.html
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-simple/revapi-report.html
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/commons-rng-sampling/revapi-report.html
Checked that the only changes reported as breaking are in package
org.apache.commons.rng.simple.internal
> RAT Report:
>
> https://home.apache.org/~aherbert/commons-rng-1.5-RC1-site/rat-report.html
Checked.
> KEYS:
> https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
[X] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
Thank you,
Gilles
> [...]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org