[GitHub] [activemq-artemis] gtully commented on a change in pull request #3464: ARTEMIS-3135 - track possible change in memory estimate when messages…

[GitBox <gi...@apache.org>]

gtully commented on a change in pull request #3464:
URL: https://github.com/apache/activemq-artemis/pull/3464#discussion_r581243825



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -3733,16 +3733,6 @@ private boolean deliver(final MessageReference ref) {
       }
    }
 
-   private static void accountForChangeInMemoryEstimate(final MessageReference ref, final int existingMemoryEstimate) {
-      final int delta = ref.getMessageMemoryEstimate() - existingMemoryEstimate;
-      if (delta > 0) {

Review comment:
       it is quite specific to the case of decoding application properties which will always increase the usage.  it is currently the only operation that will cause the memoryEstimate to change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org