You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/12/06 21:22:50 UTC
Review Request 41025: Unit tests fail for upgrade operations in
branch-2.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41025/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Sumit Mohanty.
Bugs: AMBARI-14239
https://issues.apache.org/jira/browse/AMBARI-14239
Repository: ambari
Description
-------
Failing unit tests on branch-2.2
Diffs
-----
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py 84849a4
Diff: https://reviews.apache.org/r/41025/diff/
Testing
-------
----------------------------------------------------------------------
Total run:850
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
Re: Review Request 41025: Unit tests fail for upgrade operations in
branch-2.2
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41025/#review109105
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Dec. 6, 2015, 8:22 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41025/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2015, 8:22 p.m.)
>
>
> Review request for Ambari, Nate Cole and Sumit Mohanty.
>
>
> Bugs: AMBARI-14239
> https://issues.apache.org/jira/browse/AMBARI-14239
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Failing unit tests on branch-2.2
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py 84849a4
>
> Diff: https://reviews.apache.org/r/41025/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Total run:850
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 41025: Unit tests fail for upgrade operations in
branch-2.2
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41025/#review109107
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py (lines 89 - 90)
<https://reviews.apache.org/r/41025/#comment168544>
I think you can light StackOverflow in fire with that comment :-)
- Sumit Mohanty
On Dec. 6, 2015, 8:22 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41025/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2015, 8:22 p.m.)
>
>
> Review request for Ambari, Nate Cole and Sumit Mohanty.
>
>
> Bugs: AMBARI-14239
> https://issues.apache.org/jira/browse/AMBARI-14239
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Failing unit tests on branch-2.2
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py 84849a4
>
> Diff: https://reviews.apache.org/r/41025/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Total run:850
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 41025: Unit tests fail for upgrade operations in
branch-2.2
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41025/#review109106
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py (lines 89 - 90)
<https://reviews.apache.org/r/41025/#comment168543>
This is actually the issue, but it won't show up in reviewboard b/c it's a whitespace change.
What idiot decided that it would be a good idea to have python control flow dictated by whitespace!
- Jonathan Hurley
On Dec. 6, 2015, 3:22 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41025/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2015, 3:22 p.m.)
>
>
> Review request for Ambari, Nate Cole and Sumit Mohanty.
>
>
> Bugs: AMBARI-14239
> https://issues.apache.org/jira/browse/AMBARI-14239
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Failing unit tests on branch-2.2
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py 84849a4
>
> Diff: https://reviews.apache.org/r/41025/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Total run:850
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 41025: Unit tests fail for upgrade operations in
branch-2.2
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41025/#review109134
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Dec. 6, 2015, 8:22 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41025/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2015, 8:22 p.m.)
>
>
> Review request for Ambari, Nate Cole and Sumit Mohanty.
>
>
> Bugs: AMBARI-14239
> https://issues.apache.org/jira/browse/AMBARI-14239
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Failing unit tests on branch-2.2
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py 84849a4
>
> Diff: https://reviews.apache.org/r/41025/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Total run:850
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jonathan Hurley
>
>