You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/09/13 11:39:20 UTC

[GitHub] [ratis] Xushaohong commented on a diff in pull request #745: RATIS-1707. Fix corner case when getPrevious in LogAppenderBase

Xushaohong commented on code in PR #745:
URL: https://github.com/apache/ratis/pull/745#discussion_r969510543


##########
ratis-server/src/main/java/org/apache/ratis/server/leader/LogAppenderBase.java:
##########
@@ -158,6 +158,11 @@ private TermIndex getPrevious(long nextIndex) {
       }
     }
 
+    final long raftLogLastPurgedIndex = getRaftLog().getStartIndex() - 1;
+    if (raftLogLastPurgedIndex == previousIndex) {
+      return TermIndex.valueOf(server.getInfo().getCurrentTerm(), raftLogLastPurgedIndex);

Review Comment:
   > We should check term-begin-index.
   
   Thx @szetszwo for the reply, but i have two doubt about the patch:



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org