You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "JackieTien97 (via GitHub)" <gi...@apache.org> on 2023/12/11 07:30:14 UTC
[PR] [IOTDB-6265] Construct SessionPool using empty nodeUrls should throw exception [iotdb]
JackieTien97 opened a new pull request, #11688:
URL: https://github.com/apache/iotdb/pull/11688
while we use an empty nodeUrls to construct SessionPool, we will succeed(using localhost and 6667 as default host and port) which is not we want. We expect it throw exception to tell us that nodeUrls shouldn't be empty.
```java
SessionPool sessionPool = new SessionPool(Collections.emptyList(), "root", "root", 3);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IOTDB-6265] Construct SessionPool using empty nodeUrls should throw exception [iotdb]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11688:
URL: https://github.com/apache/iotdb/pull/11688#issuecomment-1849525384
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/11688?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `2 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`60d66ae`)](https://app.codecov.io/gh/apache/iotdb/commit/60d66ae873fc7f9c60206a84ce6985ecec672d53?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.08% compared to head [(`3c44346`)](https://app.codecov.io/gh/apache/iotdb/pull/11688?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.07%.
> Report is 2 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/iotdb/pull/11688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...rc/main/java/org/apache/iotdb/session/Session.java](https://app.codecov.io/gh/apache/iotdb/pull/11688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L3Nlc3Npb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL3Nlc3Npb24vU2Vzc2lvbi5qYXZh) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ava/org/apache/iotdb/session/pool/SessionPool.java](https://app.codecov.io/gh/apache/iotdb/pull/11688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY2xpZW50L3Nlc3Npb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL3Nlc3Npb24vcG9vbC9TZXNzaW9uUG9vbC5qYXZh) | 80.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/11688?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #11688 +/- ##
============================================
- Coverage 49.08% 49.07% -0.01%
+ Complexity 24970 24956 -14
============================================
Files 2816 2816
Lines 176696 176704 +8
Branches 21181 21185 +4
============================================
- Hits 86730 86717 -13
- Misses 89966 89987 +21
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/11688?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IOTDB-6265] Construct SessionPool using empty nodeUrls should throw exception [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #11688:
URL: https://github.com/apache/iotdb/pull/11688#issuecomment-1849480685
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=11688)
[](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11688&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11688&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11688&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11688&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11688&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11688&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=11688&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=11688&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=11688&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11688&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11688&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=11688&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=11688&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=11688&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=11688&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=11688&metric=new_duplicated_lines_density&view=list)
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [IOTDB-6265] Construct SessionPool using empty nodeUrls should throw exception [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #11688:
URL: https://github.com/apache/iotdb/pull/11688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org