You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/07 10:03:07 UTC
[GitHub] [apisix-website] guoqqqi opened a new pull request #647: fix: homepage Events Article links
guoqqqi opened a new pull request #647:
URL: https://github.com/apache/apisix-website/pull/647
1. Fixed invalid link to Events article on home page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan closed pull request #647: fix: homepage Events Article links
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed pull request #647:
URL: https://github.com/apache/apisix-website/pull/647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #647: fix: homepage Events Article links
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on a change in pull request #647:
URL: https://github.com/apache/apisix-website/pull/647#discussion_r724136424
##########
File path: website/src/pages/sections/newsSection.jsx
##########
@@ -11,7 +11,7 @@ const NewsSection = () => {
.map((event) => {
const publishTime = event.fileName.slice(0, 10);
const splittedFileName = event.fileName.split("-");
- const url = `/events/${splittedFileName
+ const url = `/blog/${splittedFileName
Review comment:
You sure only doing this will work ?
For instance -
https://apisix.apache.org/events/2021/09/15/weekly-report (404)
After change `events` -> `blog`
https://apisix.apache.org/blog/2021/09/15/weekly-report (still 404)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #647: fix: homepage Events Article links
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on a change in pull request #647:
URL: https://github.com/apache/apisix-website/pull/647#discussion_r724140001
##########
File path: website/src/pages/sections/newsSection.jsx
##########
@@ -11,7 +11,7 @@ const NewsSection = () => {
.map((event) => {
const publishTime = event.fileName.slice(0, 10);
const splittedFileName = event.fileName.split("-");
- const url = `/events/${splittedFileName
+ const url = `/blog/${splittedFileName
Review comment:
Or are we planning to add all these articles under blog section ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #647: fix: homepage Events Article links
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on a change in pull request #647:
URL: https://github.com/apache/apisix-website/pull/647#discussion_r724136424
##########
File path: website/src/pages/sections/newsSection.jsx
##########
@@ -11,7 +11,7 @@ const NewsSection = () => {
.map((event) => {
const publishTime = event.fileName.slice(0, 10);
const splittedFileName = event.fileName.split("-");
- const url = `/events/${splittedFileName
+ const url = `/blog/${splittedFileName
Review comment:
You sure only doing this will work ?
For instance -
https://apisix.apache.org/events/2021/09/15/weekly-report (404)
After change `events` -> `blog`
https://apisix.apache.org/blog/2021/09/15/weekly-report (still 404)
##########
File path: website/src/pages/sections/newsSection.jsx
##########
@@ -11,7 +11,7 @@ const NewsSection = () => {
.map((event) => {
const publishTime = event.fileName.slice(0, 10);
const splittedFileName = event.fileName.split("-");
- const url = `/events/${splittedFileName
+ const url = `/blog/${splittedFileName
Review comment:
Or are we planning to add all these articles under blog section ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #647: fix: homepage Events Article links
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #647:
URL: https://github.com/apache/apisix-website/pull/647#issuecomment-938312623
I will handle this case :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] bzp2010 merged pull request #647: fix: homepage Events Article links
Posted by GitBox <gi...@apache.org>.
bzp2010 merged pull request #647:
URL: https://github.com/apache/apisix-website/pull/647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #647: fix: homepage Events Article links
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #647:
URL: https://github.com/apache/apisix-website/pull/647#discussion_r724677168
##########
File path: website/src/pages/sections/newsSection.jsx
##########
@@ -11,7 +11,7 @@ const NewsSection = () => {
.map((event) => {
const publishTime = event.fileName.slice(0, 10);
const splittedFileName = event.fileName.split("-");
- const url = `/events/${splittedFileName
+ const url = `/blog/${splittedFileName
Review comment:
No, we need to use the correct i18n way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org