[GitHub] [dolphinscheduler] JinyLeeChina commented on a change in pull request #6016: [Feature][JsonSplit-api] modify API to Restful

[GitBox <gi...@apache.org>]

JinyLeeChina commented on a change in pull request #6016:
URL: https://github.com/apache/dolphinscheduler/pull/6016#discussion_r693445700



##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
##########
@@ -138,12 +130,12 @@ public Result createProcessDefinition(@ApiIgnore @RequestAttribute(value = Const
      * @param targetProjectCode target project code
      * @return copy result code
      */
-    @ApiOperation(value = "copy", notes = "COPY_PROCESS_DEFINITION_NOTES")
+    @ApiOperation(value = "batchCopyProcessDefinitions", notes = "COPY_PROCESS_DEFINITION_NOTES")

Review comment:
       please check

##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java
##########
@@ -110,7 +102,7 @@
         @ApiImplicitParam(name = "locations", value = "PROCESS_DEFINITION_LOCATIONS", required = true, type = "String"),
         @ApiImplicitParam(name = "description", value = "PROCESS_DEFINITION_DESC", required = false, type = "String")
     })
-    @PostMapping(value = "/save")

Review comment:
       Should this be kept ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org