You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dolphinscheduler.apache.org by GabryWu <wu...@qq.com> on 2020/05/11 09:33:25 UTC
回复:introduce retryer for async function
I created one PR: https://github.com/apache/incubator-dolphinscheduler/pull/2679
------------------ 原始邮件 ------------------
发件人: "GabryWu"<wu_shao_jie@qq.com>;
发送时间: 2020年5月11日(星期一) 中午1:01
收件人: "dev"<dev@dolphinscheduler.apache.org>;
主题: introduce retryer for async function
Now, dolphin already refactor worker ,and netty is being used.
It can be predicted that async method will be more and more used ,and function retryer is necessary .
If we simply call function twice or more , it's ugly and beyonds understanding
So I suggest we introduce a retryer class ,for example https://github.com/rholder/guava-retrying
Re: 回复:introduce retryer for async function
Posted by "qiaozhanwei@outlook.com" <qi...@outlook.com>.
great
I think it is best to encapsulate a tool class, because it needs to be called in many places, not only in ack and response
―――――――――――――
DolphinScheduler(Incubator) PPMC
Zhanwei Qiao 乔占卫
qiaozhanwei@outlook.com
发件人: GabryWu
发送时间: 2020-05-11 17:33
收件人: dev
抄送: 我的QQ邮箱
主题: 回复:introduce retryer for async function
I created one PR: https://github.com/apache/incubator-dolphinscheduler/pull/2679
------------------ 原始邮件 ------------------
发件人: "GabryWu"<wu...@qq.com>;
发送时间: 2020年5月11日(星期一) 中午1:01
收件人: "dev"<de...@dolphinscheduler.apache.org>;
主题: introduce retryer for async function
Now, dolphin already refactor worker ,and netty is being used.
It can be predicted that async method will be more and more used ,and function retryer is necessary .
If we simply call function twice or more , it's ugly and beyonds understanding
So I suggest we introduce a retryer class ,for example https://github.com/rholder/guava-retrying