You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damondouglas (via GitHub)" <gi...@apache.org> on 2023/03/23 17:24:28 UTC
[GitHub] [beam] damondouglas opened a new pull request, #25951: Add modules to precommit checks
damondouglas opened a new pull request, #25951:
URL: https://github.com/apache/beam/pull/25951
This PR fixes #25949 by adding to PreCommit_Java_IOs:
- [sdks/java/io/csv](https://github.com/apache/beam/tree/master/sdks/java/io/csv)
- [sdks/java/io/file-schema-transform](https://github.com/apache/beam/tree/master/sdks/java/io/file-schema-transform)
R: @ahmedabu98
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
~Update `CHANGES.md` with noteworthy changes.~
~If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).~
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #25951: [25949] Add csv and file-schema-transform modules to PreCommit_Java_IO checks
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #25951:
URL: https://github.com/apache/beam/pull/25951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #25951: [25949] Add csv and file-schema-transform modules to PreCommit_Java_IO checks
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #25951:
URL: https://github.com/apache/beam/pull/25951#issuecomment-1481786378
Run Java_IOs_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25951: [25949] Add csv and file-schema-transform modules to PreCommit_Java_IO checks
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25951:
URL: https://github.com/apache/beam/pull/25951#issuecomment-1481708022
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #25951: [25949] Add csv and file-schema-transform modules to PreCommit_Java_IO checks
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #25951:
URL: https://github.com/apache/beam/pull/25951#issuecomment-1481611788
Thanks! Note that the current change will create PreCommit_Java_Csv_IO_Direct and PreCommit_Java_File-schema-transform_IO_Direct tests. To add it to the umbrella PreCommit_Java_IO still need to add the tasks here: https://github.com/apache/beam/blob/457391a0ccd8dc9bb348cebcf0b6550c95ad49e1/build.gradle.kts#L322
These two places need sync manually. I should have been added more clear comments there. Sorry if there is any confusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on pull request #25951: [25949] Add csv and file-schema-transform modules to PreCommit_Java_IO checks
Posted by "damondouglas (via GitHub)" <gi...@apache.org>.
damondouglas commented on PR #25951:
URL: https://github.com/apache/beam/pull/25951#issuecomment-1481672906
> Thanks! Note that the current change will create PreCommit_Java_Csv_IO_Direct and PreCommit_Java_File-schema-transform_IO_Direct tests. To add it to the umbrella PreCommit_Java_IO still need to add the tasks here:
>
> https://github.com/apache/beam/blob/457391a0ccd8dc9bb348cebcf0b6550c95ad49e1/build.gradle.kts#L322
>
> These two places need sync manually. I should have been added more clear comments there. Sorry if there is any confusion
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on pull request #25951: [25949] Add csv and file-schema-transform modules to PreCommit_Java_IO checks
Posted by "damondouglas (via GitHub)" <gi...@apache.org>.
damondouglas commented on PR #25951:
URL: https://github.com/apache/beam/pull/25951#issuecomment-1481676923
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #25951: [25949] Add csv and file-schema-transform modules to PreCommit_Java_IO checks
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on PR #25951:
URL: https://github.com/apache/beam/pull/25951#issuecomment-1481676884
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org