You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2023/10/16 13:07:52 UTC

Re: [PR] [SPARK-39420][SQL] Support `ANALYZE TABLE` on Datasource V2 tables [spark]

MaxGekk commented on code in PR #41111:
URL: https://github.com/apache/spark/pull/41111#discussion_r1360633362


##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -3177,6 +3177,11 @@
           "<variableName> is a VARIABLE and cannot be updated using the SET statement. Use SET VARIABLE <variableName> = ... instead."
         ]
       },
+      "TABLE_NOT_SUPPORTED_STATISTIC" : {
+        "message" : [
+          "Cannot gather statistics for the table <tableName> because it does not the feature."

Review Comment:
   The error class already has the words about unsupported feature, see:
   ```json
     "UNSUPPORTED_FEATURE" : {
       "message" : [
         "The feature is not supported:"
       ],
   ```
   Please, remove the tail:
   ```suggestion
             "Gather statistics for the table <tableName>."
   ```



##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -3177,6 +3177,11 @@
           "<variableName> is a VARIABLE and cannot be updated using the SET statement. Use SET VARIABLE <variableName> = ... instead."
         ]
       },
+      "TABLE_NOT_SUPPORTED_STATISTIC" : {

Review Comment:
   ```suggestion
         "TABLE_STATISTICS" : {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org