You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by wz...@apache.org on 2021/07/19 22:28:41 UTC
[impala] branch master updated: IMPALA-10802:
test_show_create_table and test_catalogs fails with Iceberg syntax error
This is an automated email from the ASF dual-hosted git repository.
wzhou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new 62028d0 IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error
62028d0 is described below
commit 62028d00e657c65cd23e16794dff18149f1dbe0e
Author: Zoltan Borok-Nagy <bo...@cloudera.com>
AuthorDate: Fri Jul 16 11:38:41 2021 +0200
IMPALA-10802: test_show_create_table and test_catalogs fails with Iceberg syntax error
Two Iceberg commits got into master branch in parallel. One of
them modified the DDL syntax, the other one added some tests.
They were correct on their own, but mixing the two causes
test failures.
The affected tests have been updated.
Change-Id: Id3cf6ff04b8da5782df2b84a580cdbd4a4a16d06
Reviewed-on: http://gerrit.cloudera.org:8080/17689
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
.../functional-query/queries/QueryTest/iceberg-catalogs.test | 6 +++---
.../functional-query/queries/QueryTest/show-create-table.test | 8 ++++----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/testdata/workloads/functional-query/queries/QueryTest/iceberg-catalogs.test b/testdata/workloads/functional-query/queries/QueryTest/iceberg-catalogs.test
index 92fad47..de4ab34 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/iceberg-catalogs.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/iceberg-catalogs.test
@@ -4,7 +4,7 @@ CREATE TABLE iceberg_hadoop_catalogs(
label STRING,
val decimal(10,2)
)
-PARTITION BY SPEC(label IDENTITY)
+PARTITIONED BY SPEC(label)
STORED AS ICEBERG
TBLPROPERTIES('iceberg.catalog'='ice_hadoop_cat');
====
@@ -22,7 +22,7 @@ CREATE TABLE iceberg_hadoop_catalogs_with_id(
label STRING,
val decimal(10,2)
)
-PARTITION BY SPEC(label IDENTITY)
+PARTITIONED BY SPEC(label)
STORED AS ICEBERG
TBLPROPERTIES('iceberg.catalog'='ice_hadoop_cat',
'iceberg.table_identifier'='org.db.tbl');
@@ -95,7 +95,7 @@ CREATE TABLE iceberg_hive_catalogs(
label STRING,
val decimal(10,2)
)
-PARTITION BY SPEC(label IDENTITY)
+PARTITIONED BY SPEC(label)
STORED AS ICEBERG
TBLPROPERTIES('iceberg.catalog'='ice_hive_cat');
====
diff --git a/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test b/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
index 10f2b4c..5389a01 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
@@ -819,12 +819,12 @@ TBLPROPERTIES ('external.table.purge'='TRUE', 'iceberg.file_format'='parquet',
====
---- CREATE_TABLE
CREATE TABLE iceberg_catalogs_hive (i int)
-PARTITION BY SPEC (i bucket 3)
+PARTITIONED BY SPEC (bucket(3, i))
STORED AS ICEBERG
TBLPROPERTIES ('iceberg.catalog'='ice_hive_cat')
---- RESULTS-HIVE-3
CREATE EXTERNAL TABLE show_create_table_test_db.iceberg_catalogs_hive (i INT NULL)
-PARTITION BY SPEC (i BUCKET 3)
+PARTITIONED BY SPEC (BUCKET(3, i))
STORED AS ICEBERG
LOCATION '$$location_uri$$'
TBLPROPERTIES ('external.table.purge'='TRUE', 'iceberg.file_format'='parquet',
@@ -832,12 +832,12 @@ TBLPROPERTIES ('external.table.purge'='TRUE', 'iceberg.file_format'='parquet',
====
---- CREATE_TABLE
CREATE TABLE iceberg_catalogs_hadoop (i int)
-PARTITION BY SPEC (i bucket 3)
+PARTITIONED BY SPEC (bucket(3, i))
STORED AS ICEBERG
TBLPROPERTIES ('iceberg.catalog'='ice_hadoop_cat')
---- RESULTS-HIVE-3
CREATE EXTERNAL TABLE show_create_table_test_db.iceberg_catalogs_hadoop (i INT NULL)
-PARTITION BY SPEC (i BUCKET 3)
+PARTITIONED BY SPEC (BUCKET(3, i))
STORED AS ICEBERG
LOCATION '$$location_uri$$'
TBLPROPERTIES ('external.table.purge'='TRUE', 'iceberg.file_format'='parquet',