You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "prashantwason (via GitHub)" <gi...@apache.org> on 2026/01/28 20:08:42 UTC

[PR] feat(common): add a flag for disabling append to log files [hudi]

prashantwason opened a new pull request, #18025:
URL: https://github.com/apache/hudi/pull/18025

   ### Describe the issue this Pull Request addresses
   
   This PR adds a configuration flag `hoodie.log.file.append.disabled` that allows users to disable appending to existing log files. When enabled, all appends go to a new log file instead of appending to an existing one.
   
   Issue: [HUDI-2350](https://issues.apache.org/jira/browse/HUDI-2350)
   
   ### Summary and Changelog
   
   **Summary:** Adds a new configuration option to control log file append behavior, useful for environments where appending to existing files is problematic.
   
   **Changelog:**
   - Added `LOG_FILE_APPEND_DISABLED` config property to `HoodieWriteConfig` with default value `false`
   - Added `withAppendDisabled(boolean)` method to `HoodieLogFormat.WriterBuilder`
   - Modified log file version computation to increment version when appends are disabled
   - Updated `TimelineArchiverV1` to use the new append disabled flag from config
   - Added unit test `testAppendDisabledFlag` in `TestHoodieLogFormat`
   
   ### Impact
   
   New configuration option for users who need to disable log file appending. No breaking changes - default behavior remains unchanged (appends enabled).
   
   ### Risk Level
   
   low - This is an additive change with a safe default value (disabled by default). Existing behavior is preserved unless explicitly opted into.
   
   ### Documentation Update
   
   The config description is included in the code. The new config is:
   - `hoodie.log.file.append.disabled` (default: `false`) - When enabled, all appends go to a new log file.
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Enough context is provided in the sections above
   - [x] Adequate tests were added if applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(common): add a flag for disabling append to log files [hudi]

Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason closed pull request #18025: feat(common): add a flag for disabling append to log files
URL: https://github.com/apache/hudi/pull/18025


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(common): add a flag for disabling append to log files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18025:
URL: https://github.com/apache/hudi/pull/18025#issuecomment-3814056992

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f7ad6c4812463730d2962500fd7a7474d47c0d16",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11457",
       "triggerID" : "f7ad6c4812463730d2962500fd7a7474d47c0d16",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f7ad6c4812463730d2962500fd7a7474d47c0d16 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11457) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(common): add a flag for disabling append to log files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18025:
URL: https://github.com/apache/hudi/pull/18025#issuecomment-3813707608

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f7ad6c4812463730d2962500fd7a7474d47c0d16",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11457",
       "triggerID" : "f7ad6c4812463730d2962500fd7a7474d47c0d16",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f7ad6c4812463730d2962500fd7a7474d47c0d16 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=11457) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(common): add a flag for disabling append to log files [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18025:
URL: https://github.com/apache/hudi/pull/18025#issuecomment-3813684704

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f7ad6c4812463730d2962500fd7a7474d47c0d16",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f7ad6c4812463730d2962500fd7a7474d47c0d16",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f7ad6c4812463730d2962500fd7a7474d47c0d16 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(common): add a flag for disabling append to log files [hudi]

Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on PR #18025:
URL: https://github.com/apache/hudi/pull/18025#issuecomment-3837656699

   Thanks for the review @nsivabalan. You're right - PR #9594 already removed log file appending completely, making this change obsolete. I'll close this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org