You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/03/20 06:37:10 UTC
Review Request 70248: Adapted the unversioned `VolumeCapability`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
Bugs: MESOS-9625
https://issues.apache.org/jira/browse/MESOS-9625
Repository: mesos
Description
-------
This patch makes the disk profile adaptors and the CSI volume state
protobuf to use the unversioned `VolumeCapability` instead of the CSI v0
protobuf, so the profile adaptors and the volume state checkpoints can
be upgraded to support CSI v1 in a backward compatible way.
Diffs
-----
include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
src/csi/utils.hpp 9145c6795c3ecdde5de5859a852763fe9aeb1ddf
src/csi/utils.cpp fd6f95d88caf69e2ae197cf940beb93c164565bc
src/csi/v0_volume_manager.hpp PRE-CREATION
src/csi/v0_volume_manager.cpp PRE-CREATION
src/csi/v0_volume_manager_process.hpp PRE-CREATION
src/csi/volume_manager.hpp PRE-CREATION
src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
src/resource_provider/storage/disk_profile.proto 1c97e9c62fb3154d6048d0e55352a1276adcbca8
src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
src/resource_provider/storage/disk_profile_utils.hpp 8a83a15ba555ce66bbb86b8df72178bce17a615a
src/resource_provider/storage/disk_profile_utils.cpp 82c69d8b916a933f13e1185ffbf8ec65afd04ccf
src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
Diff: https://reviews.apache.org/r/70248/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review213825
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70245, 70168, 70169, 70213, 70214, 70215, 70216, 70217, 70222, 70223, 70225, 70247, 70248]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 20, 2019, 6:37 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 6:37 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptors and the CSI volume state
> protobuf to use the unversioned `VolumeCapability` instead of the CSI v0
> protobuf, so the profile adaptors and the volume state checkpoints can
> be upgraded to support CSI v1 in a backward compatible way.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/utils.hpp 9145c6795c3ecdde5de5859a852763fe9aeb1ddf
> src/csi/utils.cpp fd6f95d88caf69e2ae197cf940beb93c164565bc
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile.proto 1c97e9c62fb3154d6048d0e55352a1276adcbca8
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/disk_profile_utils.hpp 8a83a15ba555ce66bbb86b8df72178bce17a615a
> src/resource_provider/storage/disk_profile_utils.cpp 82c69d8b916a933f13e1185ffbf8ec65afd04ccf
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review213838
-----------------------------------------------------------
src/csi/utils.hpp
Lines 182-183 (patched)
<https://reviews.apache.org/r/70248/#comment299908>
Do we also have a corresponding `devolve` function? In `compat.proto` we promise that we can always round-trip.
src/csi/utils.cpp
Lines 100 (patched)
<https://reviews.apache.org/r/70248/#comment299907>
Let's make this change in https://reviews.apache.org/r/70247/.
Such conversion functions should have tests.
- Benjamin Bannier
On March 20, 2019, 7:37 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 7:37 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptors and the CSI volume state
> protobuf to use the unversioned `VolumeCapability` instead of the CSI v0
> protobuf, so the profile adaptors and the volume state checkpoints can
> be upgraded to support CSI v1 in a backward compatible way.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/utils.hpp 9145c6795c3ecdde5de5859a852763fe9aeb1ddf
> src/csi/utils.cpp fd6f95d88caf69e2ae197cf940beb93c164565bc
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile.proto 1c97e9c62fb3154d6048d0e55352a1276adcbca8
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/disk_profile_utils.hpp 8a83a15ba555ce66bbb86b8df72178bce17a615a
> src/resource_provider/storage/disk_profile_utils.cpp 82c69d8b916a933f13e1185ffbf8ec65afd04ccf
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review213824
-----------------------------------------------------------
PASS: Mesos patch 70248 was successfully built and tested.
Reviews applied: `['70245', '70168', '70169', '70213', '70214', '70215', '70216', '70217', '70222', '70223', '70225', '70247', '70248']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2983/mesos-review-70248
- Mesos Reviewbot Windows
On March 19, 2019, 11:37 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 19, 2019, 11:37 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptors and the CSI volume state
> protobuf to use the unversioned `VolumeCapability` instead of the CSI v0
> protobuf, so the profile adaptors and the volume state checkpoints can
> be upgraded to support CSI v1 in a backward compatible way.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/utils.hpp 9145c6795c3ecdde5de5859a852763fe9aeb1ddf
> src/csi/utils.cpp fd6f95d88caf69e2ae197cf940beb93c164565bc
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile.proto 1c97e9c62fb3154d6048d0e55352a1276adcbca8
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/disk_profile_utils.hpp 8a83a15ba555ce66bbb86b8df72178bce17a615a
> src/resource_provider/storage/disk_profile_utils.cpp 82c69d8b916a933f13e1185ffbf8ec65afd04ccf
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review213930
-----------------------------------------------------------
Bad review!
Reviews applied: [70248, 70258, 70247, 70225, 70223, 70222, 70217, 70215, 70216, 70214, 70213, 70168, 70245]
Error:
2019-03-22 20:44:20 URL:https://reviews.apache.org/r/70222/diff/raw/ [80925/80925] -> "70222.patch" [1]
error: patch failed: src/csi/v0_volume_manager.cpp:423
error: src/csi/v0_volume_manager.cpp: patch does not apply
error: patch failed: src/csi/v0_volume_manager_process.hpp:118
error: src/csi/v0_volume_manager_process.hpp: patch does not apply
error: patch failed: src/resource_provider/storage/provider.cpp:74
error: src/resource_provider/storage/provider.cpp: patch does not apply
error: patch failed: src/resource_provider/storage/provider_process.hpp:52
error: src/resource_provider/storage/provider_process.hpp: patch does not apply
- Mesos Reviewbot
On March 20, 2019, 2:40 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 2:40 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review213862
-----------------------------------------------------------
PASS: Mesos patch 70248 was successfully built and tested.
Reviews applied: `['70245', '70168', '70169', '70213', '70214', '70215', '70216', '70217', '70222', '70223', '70225', '70247', '70258', '70248']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2987/mesos-review-70248
- Mesos Reviewbot Windows
On March 20, 2019, 9:40 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 9:40 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review213936
-----------------------------------------------------------
Bad review!
Reviews applied: [70248, 70258, 70247, 70225, 70223, 70222, 70217, 70215, 70216, 70214, 70213, 70168, 70245]
Error:
2019-03-22 23:37:41 URL:https://reviews.apache.org/r/70222/diff/raw/ [80925/80925] -> "70222.patch" [1]
error: patch failed: src/csi/v0_volume_manager.cpp:423
error: src/csi/v0_volume_manager.cpp: patch does not apply
error: patch failed: src/csi/v0_volume_manager_process.hpp:118
error: src/csi/v0_volume_manager_process.hpp: patch does not apply
error: patch failed: src/resource_provider/storage/provider.cpp:74
error: src/resource_provider/storage/provider.cpp: patch does not apply
error: patch failed: src/resource_provider/storage/provider_process.hpp:52
error: src/resource_provider/storage/provider_process.hpp: patch does not apply
- Mesos Reviewbot
On March 20, 2019, 9:40 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 9:40 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review213937
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 70222.
Failed command: `python.exe .\support\apply-reviews.py -n -r 70222`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3000/mesos-review-70248
Relevant logs:
- [apply-review-70222.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3000/mesos-review-70248/logs/apply-review-70222.log):
```
error: patch failed: src/csi/v0_volume_manager.cpp:423
error: src/csi/v0_volume_manager.cpp: patch does not apply
error: patch failed: src/csi/v0_volume_manager_process.hpp:118
error: src/csi/v0_volume_manager_process.hpp: patch does not apply
error: patch failed: src/resource_provider/storage/provider.cpp:74
error: src/resource_provider/storage/provider.cpp: patch does not apply
error: patch failed: src/resource_provider/storage/provider_process.hpp:52
error: src/resource_provider/storage/provider_process.hpp: patch does not apply
```
- Mesos Reviewbot Windows
On March 20, 2019, 9:40 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 9:40 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review213945
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70245, 70168, 70213, 70214, 70216, 70215, 70217, 70284, 70222, 70285, 70223, 70225, 70247, 70258, 70248]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 22, 2019, 11:39 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 22, 2019, 11:39 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by James DeFelice <ja...@gmail.com>.
> On March 27, 2019, 12:01 p.m., James DeFelice wrote:
> > src/csi/state.proto
> > Line 19 (original), 19 (patched)
> > <https://reviews.apache.org/r/70248/diff/5/?file=2134483#file2134483line19>
> >
> > are the protos in src/csi considered part of the "stable" mesos v1 API? if so, should they follow the same directory naming convention as the other mesos v1 APIs?
>
> Chun-Hung Hsiao wrote:
> No. Protos in `src/` are for internal use. Specically, this one is for checkpointing. It needs to be "stable" in the backward-compatible way, but never exposed in any API. This is the pattern we use in may other places: public-facing in `include`, internal use in `src`. Dropping.
>
> James DeFelice wrote:
> Disagree that this is an example of "for internal use only". In this case, these protos are explicitly used when Mesos communicates with an external component via some URI endpoint. Hence, there should be some guarantee of API stability for them.
>
> Benjamin Bannier wrote:
> @jdef, I think I agree with @chhsia0 here. While these 3rdparty protos are used to communicate with non-Mesos components and we e.g., do not change message contents, the used directory naming convention (which can translate the namespaces) is not exposed over that interface and Mesos can treat that as an internal detail. Or am I missing something?
OK, I think I confused the proto changes here w/ the changes in the prior commit: https://reviews.apache.org/r/70247/diff/6#1
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review214098
-----------------------------------------------------------
On March 28, 2019, 7:53 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 28, 2019, 7:53 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by James DeFelice <ja...@gmail.com>.
> On March 27, 2019, 12:01 p.m., James DeFelice wrote:
> > src/csi/state.proto
> > Line 19 (original), 19 (patched)
> > <https://reviews.apache.org/r/70248/diff/5/?file=2134483#file2134483line19>
> >
> > are the protos in src/csi considered part of the "stable" mesos v1 API? if so, should they follow the same directory naming convention as the other mesos v1 APIs?
>
> Chun-Hung Hsiao wrote:
> No. Protos in `src/` are for internal use. Specically, this one is for checkpointing. It needs to be "stable" in the backward-compatible way, but never exposed in any API. This is the pattern we use in may other places: public-facing in `include`, internal use in `src`. Dropping.
Disagree that this is an example of "for internal use only". In this case, these protos are explicitly used when Mesos communicates with an external component via some URI endpoint. Hence, there should be some guarantee of API stability for them.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review214098
-----------------------------------------------------------
On March 28, 2019, 7:53 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 28, 2019, 7:53 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On March 27, 2019, 1:01 p.m., James DeFelice wrote:
> > src/csi/state.proto
> > Line 19 (original), 19 (patched)
> > <https://reviews.apache.org/r/70248/diff/5/?file=2134483#file2134483line19>
> >
> > are the protos in src/csi considered part of the "stable" mesos v1 API? if so, should they follow the same directory naming convention as the other mesos v1 APIs?
>
> Chun-Hung Hsiao wrote:
> No. Protos in `src/` are for internal use. Specically, this one is for checkpointing. It needs to be "stable" in the backward-compatible way, but never exposed in any API. This is the pattern we use in may other places: public-facing in `include`, internal use in `src`. Dropping.
>
> James DeFelice wrote:
> Disagree that this is an example of "for internal use only". In this case, these protos are explicitly used when Mesos communicates with an external component via some URI endpoint. Hence, there should be some guarantee of API stability for them.
@jdef, I think I agree with @chhsia0 here. While these 3rdparty protos are used to communicate with non-Mesos components and we e.g., do not change message contents, the used directory naming convention (which can translate the namespaces) is not exposed over that interface and Mesos can treat that as an internal detail. Or am I missing something?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review214098
-----------------------------------------------------------
On March 28, 2019, 8:53 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 28, 2019, 8:53 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On March 27, 2019, 12:01 p.m., James DeFelice wrote:
> > src/csi/state.proto
> > Line 19 (original), 19 (patched)
> > <https://reviews.apache.org/r/70248/diff/5/?file=2134483#file2134483line19>
> >
> > are the protos in src/csi considered part of the "stable" mesos v1 API? if so, should they follow the same directory naming convention as the other mesos v1 APIs?
No. Protos in `src/` are for internal use. Specically, this one is for checkpointing. It needs to be "stable" in the backward-compatible way, but never exposed in any API. This is the pattern we use in may other places: public-facing in `include`, internal use in `src`. Dropping.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review214098
-----------------------------------------------------------
On March 27, 2019, 5:54 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 27, 2019, 5:54 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by James DeFelice <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review214098
-----------------------------------------------------------
src/csi/state.proto
Line 19 (original), 19 (patched)
<https://reviews.apache.org/r/70248/#comment300271>
are the protos in src/csi considered part of the "stable" mesos v1 API? if so, should they follow the same directory naming convention as the other mesos v1 APIs?
- James DeFelice
On March 27, 2019, 5:54 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 27, 2019, 5:54 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review214331
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On March 28, 2019, 8:53 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 28, 2019, 8:53 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/
-----------------------------------------------------------
(Updated March 28, 2019, 7:53 a.m.)
Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-9625
https://issues.apache.org/jira/browse/MESOS-9625
Repository: mesos
Description
-------
This patch makes the disk profile adaptor module API and the CSI volume
state protobuf to use the unversioned `VolumeCapability`, so the profile
adaptors and the volume state checkpoints can be upgraded to support CSI
v1 in a backward compatible way.
The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
however, still uses CSI v0 `VolumeCapability` for now, and devolve it
to the unversioned protobuf during profile translation.
Diffs (updated)
-----
include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af
src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
Diff: https://reviews.apache.org/r/70248/diff/6/
Changes: https://reviews.apache.org/r/70248/diff/5-6/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/
-----------------------------------------------------------
(Updated March 27, 2019, 5:54 a.m.)
Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
Changes
-------
Reordered the patch.
Bugs: MESOS-9625
https://issues.apache.org/jira/browse/MESOS-9625
Repository: mesos
Description
-------
This patch makes the disk profile adaptor module API and the CSI volume
state protobuf to use the unversioned `VolumeCapability`, so the profile
adaptors and the volume state checkpoints can be upgraded to support CSI
v1 in a backward compatible way.
The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
however, still uses CSI v0 `VolumeCapability` for now, and devolve it
to the unversioned protobuf during profile translation.
Diffs (updated)
-----
include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af
src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
Diff: https://reviews.apache.org/r/70248/diff/5/
Changes: https://reviews.apache.org/r/70248/diff/4-5/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review214027
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 70222.
Failed command: `python.exe .\support\apply-reviews.py -n -r 70222`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3013/mesos-review-70248
Relevant logs:
- [apply-review-70222.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3013/mesos-review-70248/logs/apply-review-70222.log):
```
error: patch failed: src/csi/v0_volume_manager_process.hpp:27
error: src/csi/v0_volume_manager_process.hpp: patch does not apply
```
- Mesos Reviewbot Windows
On March 22, 2019, 11:39 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 22, 2019, 11:39 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review214030
-----------------------------------------------------------
PASS: Mesos patch 70248 was successfully built and tested.
Reviews applied: `['70245', '70168', '70213', '70214', '70216', '70215', '70217', '70284', '70222', '70285', '70223', '70225', '70247', '70258', '70248']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3014/mesos-review-70248
- Mesos Reviewbot Windows
On March 22, 2019, 11:39 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 22, 2019, 11:39 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/4/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review213939
-----------------------------------------------------------
PASS: Mesos patch 70248 was successfully built and tested.
Reviews applied: `['70245', '70168', '70213', '70214', '70216', '70215', '70217', '70284', '70222', '70285', '70223', '70225', '70247', '70258', '70248']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3001/mesos-review-70248
- Mesos Reviewbot Windows
On March 22, 2019, 11:39 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 22, 2019, 11:39 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/
-----------------------------------------------------------
(Updated March 22, 2019, 11:39 p.m.)
Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-9625
https://issues.apache.org/jira/browse/MESOS-9625
Repository: mesos
Description
-------
This patch makes the disk profile adaptor module API and the CSI volume
state protobuf to use the unversioned `VolumeCapability`, so the profile
adaptors and the volume state checkpoints can be upgraded to support CSI
v1 in a backward compatible way.
The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
however, still uses CSI v0 `VolumeCapability` for now, and devolve it
to the unversioned protobuf during profile translation.
Diffs (updated)
-----
include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
src/csi/v0_volume_manager.hpp PRE-CREATION
src/csi/v0_volume_manager.cpp PRE-CREATION
src/csi/v0_volume_manager_process.hpp PRE-CREATION
src/csi/volume_manager.hpp PRE-CREATION
src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
Diff: https://reviews.apache.org/r/70248/diff/3/
Changes: https://reviews.apache.org/r/70248/diff/2-3/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review213903
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 70217.
Failed command: `python.exe .\support\apply-reviews.py -n -r 70217`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2991/mesos-review-70248
Relevant logs:
- [apply-review-70217.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2991/mesos-review-70248/logs/apply-review-70217.log):
```
error: patch failed: src/csi/v0_volume_manager.cpp:32
error: src/csi/v0_volume_manager.cpp: patch does not apply
error: patch failed: src/csi/v0_volume_manager_process.hpp:134
error: src/csi/v0_volume_manager_process.hpp: patch does not apply
```
- Mesos Reviewbot Windows
On March 20, 2019, 9:40 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 9:40 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review213925
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 70222.
Failed command: `python.exe .\support\apply-reviews.py -n -r 70222`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2997/mesos-review-70248
Relevant logs:
- [apply-review-70222.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2997/mesos-review-70248/logs/apply-review-70222.log):
```
error: patch failed: src/csi/v0_volume_manager.cpp:423
error: src/csi/v0_volume_manager.cpp: patch does not apply
error: patch failed: src/csi/v0_volume_manager_process.hpp:118
error: src/csi/v0_volume_manager_process.hpp: patch does not apply
error: patch failed: src/resource_provider/storage/provider.cpp:74
error: src/resource_provider/storage/provider.cpp: patch does not apply
error: patch failed: src/resource_provider/storage/provider_process.hpp:52
error: src/resource_provider/storage/provider_process.hpp: patch does not apply
```
- Mesos Reviewbot Windows
On March 20, 2019, 9:40 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 9:40 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review213904
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 70222.
Failed command: `python.exe .\support\apply-reviews.py -n -r 70222`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2993/mesos-review-70248
Relevant logs:
- [apply-review-70222.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2993/mesos-review-70248/logs/apply-review-70222.log):
```
error: patch failed: src/csi/v0_volume_manager.cpp:423
error: src/csi/v0_volume_manager.cpp: patch does not apply
error: patch failed: src/csi/v0_volume_manager_process.hpp:118
error: src/csi/v0_volume_manager_process.hpp: patch does not apply
error: patch failed: src/resource_provider/storage/provider.cpp:74
error: src/resource_provider/storage/provider.cpp: patch does not apply
error: patch failed: src/resource_provider/storage/provider_process.hpp:52
error: src/resource_provider/storage/provider_process.hpp: patch does not apply
```
- Mesos Reviewbot Windows
On March 20, 2019, 9:40 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 9:40 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review213866
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70245, 70168, 70169, 70213, 70214, 70215, 70216, 70217, 70222, 70223, 70225, 70247, 70258, 70248]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 20, 2019, 9:40 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 20, 2019, 9:40 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/#review213912
-----------------------------------------------------------
Bad review!
Reviews applied: [70248, 70258, 70247, 70225, 70223, 70222, 70217, 70215, 70216, 70214, 70213, 70169, 70168, 70245]
Error:
2019-03-22 09:48:23 URL:https://reviews.apache.org/r/70222/diff/raw/ [80925/80925] -> "70222.patch" [1]
error: patch failed: src/csi/v0_volume_manager.cpp:423
error: src/csi/v0_volume_manager.cpp: patch does not apply
error: patch failed: src/csi/v0_volume_manager_process.hpp:118
error: src/csi/v0_volume_manager_process.hpp: patch does not apply
error: patch failed: src/resource_provider/storage/provider.cpp:74
error: src/resource_provider/storage/provider.cpp: patch does not apply
error: patch failed: src/resource_provider/storage/provider_process.hpp:52
error: src/resource_provider/storage/provider_process.hpp: patch does not apply
- Mesos Reviewbot
On March 21, 2019, 3:10 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70248/
> -----------------------------------------------------------
>
> (Updated March 21, 2019, 3:10 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
>
>
> Bugs: MESOS-9625
> https://issues.apache.org/jira/browse/MESOS-9625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes the disk profile adaptor module API and the CSI volume
> state protobuf to use the unversioned `VolumeCapability`, so the profile
> adaptors and the volume state checkpoints can be upgraded to support CSI
> v1 in a backward compatible way.
>
> The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
> however, still uses CSI v0 `VolumeCapability` for now, and devolve it
> to the unversioned protobuf during profile translation.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
> src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
> src/csi/v0_volume_manager.hpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager_process.hpp PRE-CREATION
> src/csi/volume_manager.hpp PRE-CREATION
> src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
> src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
> src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
> src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
> src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
>
>
> Diff: https://reviews.apache.org/r/70248/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70248: Adapted the unversioned `VolumeCapability`.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70248/
-----------------------------------------------------------
(Updated March 20, 2019, 9:40 p.m.)
Review request for mesos, Benjamin Bannier, James DeFelice, and Jan Schlicht.
Changes
-------
Addressed Benjamin's comments and make `UriDiskProfileAdaptor` remain using the CSI v0 protobuf.
Bugs: MESOS-9625
https://issues.apache.org/jira/browse/MESOS-9625
Repository: mesos
Description (updated)
-------
This patch makes the disk profile adaptor module API and the CSI volume
state protobuf to use the unversioned `VolumeCapability`, so the profile
adaptors and the volume state checkpoints can be upgraded to support CSI
v1 in a backward compatible way.
The `DiskProfileMapping` protobuf used by `UriDiskProfileAdaptor`,
however, still uses CSI v0 `VolumeCapability` for now, and devolve it
to the unversioned protobuf during profile translation.
Diffs (updated)
-----
include/mesos/resource_provider/storage/disk_profile_adaptor.hpp 739585b84245a85649d36ddde3a6086a5cf309cc
src/csi/state.proto b5ccf165255864072a7f7276ea50035d14d571f4
src/csi/v0_volume_manager.hpp PRE-CREATION
src/csi/v0_volume_manager.cpp PRE-CREATION
src/csi/v0_volume_manager_process.hpp PRE-CREATION
src/csi/volume_manager.hpp PRE-CREATION
src/resource_provider/state.proto eb56a9129f522eee4295fa2fd2fe0beced4c31a2
src/resource_provider/storage/disk_profile_adaptor.cpp b4551a681addcf70f3fe93c7e5ffbb4a6434c50a
src/resource_provider/storage/uri_disk_profile_adaptor.hpp 7e610d30110f22cd6ee0745979ef8ced3a07765e
src/resource_provider/storage/uri_disk_profile_adaptor.cpp cb574be2a4b4e443248b2001f822d739e5bbe7b9
src/tests/disk_profile_adaptor_tests.cpp 0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
Diff: https://reviews.apache.org/r/70248/diff/2/
Changes: https://reviews.apache.org/r/70248/diff/1-2/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao