You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Charlie Carson <ch...@gmail.com> on 2014/01/31 01:18:27 UTC
Review Request 17564: Introduce a repair coordinator class to master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17564/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Jeff Currier.
Bugs: https://issues.apache.org/jira/browse/MESOS-957
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-957
Repository: mesos-git
Description
-------
Introduce a repair coordinator class to master.
Add a RepairCoordinator class to master. Currently it is just
a stub, but it will soon get wired up to the new observe end-point
in master and recieve slave state updates. From there, it will be
responsible for persisting the state and ultimately performing
repairs on unhealthy slaves.
The RepairCoordinator has virtual methods and destructor so that
it can easily be mocked for testing.
Updated the existing master constructor to take a RepairCoordinator*
and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new
up a RepairCoordinator, pass it to master's constructor and delete
the RepairCoordinator when it's finished.
Diffs
-----
src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4
src/local/local.cpp 83a7f913afb1441e9137c7fcec8fd81815714905
src/master/main.cpp b1e45766281c5ea0b8a3cee89e390ea60a97c5e4
src/master/master.hpp 7649737283f5f5d786ac40504e943a3be4c1d62b
src/master/master.cpp 77872ece66601043ddeb280cceba5a7676e8a6be
src/master/repair_coordinator.hpp PRE-CREATION
src/master/repair_coordinator.cpp PRE-CREATION
src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
Diff: https://reviews.apache.org/r/17564/diff/
Testing
-------
make check
Thanks,
Charlie Carson
Re: Review Request 17564: Introduce a repair coordinator class to master.
Posted by Charlie Carson <ch...@gmail.com>.
> On Feb. 10, 2014, 7:19 a.m., Benjamin Hindman wrote:
> > The skeleton looks good to me. I'm curious what the interplay between the RepairCoordinator and the Master is going to be and how/if that will influence future API considerations. For example, should the RepairCoordinator be an actor? Also, I like the name Autopilot, I think this is a fine foundation to build on though.
I _think_ RepairCoordinator should be an actor, but I was going to wait until I got to talk to you guys about that.
- Charlie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17564/#review34056
-----------------------------------------------------------
On Feb. 10, 2014, 10:27 p.m., Charlie Carson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17564/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2014, 10:27 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone.
>
>
> Bugs: https://issues.apache.org/jira/browse/MESOS-957
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-957
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduce a repair coordinator class to master.
>
> Add a RepairCoordinator class to master. Currently it is just
> a stub, but it will soon get wired up to the new observe end-point
> in master and recieve slave state updates. From there, it will be
> responsible for persisting the state and ultimately performing
> repairs on unhealthy slaves.
>
> The RepairCoordinator has virtual methods and destructor so that
> it can easily be mocked for testing.
>
> Updated the existing master constructor to take a RepairCoordinator*
> and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new
> up a RepairCoordinator, pass it to master's constructor and delete
> the RepairCoordinator when it's finished.
>
>
> Diffs
> -----
>
> src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4
> src/local/local.cpp 83a7f913afb1441e9137c7fcec8fd81815714905
> src/master/main.cpp 4f1859fba15c3f6c581d098337dc3262ec68bf3c
> src/master/master.hpp 7649737283f5f5d786ac40504e943a3be4c1d62b
> src/master/master.cpp 241b0069902cd125fdd933096ddd7e1c841d1559
> src/master/repair_coordinator.hpp PRE-CREATION
> src/master/repair_coordinator.cpp PRE-CREATION
> src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
>
> Diff: https://reviews.apache.org/r/17564/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Charlie Carson
>
>
Re: Review Request 17564: Introduce a repair coordinator class to master.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17564/#review34056
-----------------------------------------------------------
Ship it!
The skeleton looks good to me. I'm curious what the interplay between the RepairCoordinator and the Master is going to be and how/if that will influence future API considerations. For example, should the RepairCoordinator be an actor? Also, I like the name Autopilot, I think this is a fine foundation to build on though.
src/master/master.hpp
<https://reviews.apache.org/r/17564/#comment64045>
s/ */* /g
src/master/repair_coordinator.cpp
<https://reviews.apache.org/r/17564/#comment64046>
We are pretty consistent here and do:
} // namespace master {
} // namespace internal {
} // namespace mesos {
- Benjamin Hindman
On Jan. 31, 2014, 12:18 a.m., Charlie Carson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17564/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2014, 12:18 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone.
>
>
> Bugs: https://issues.apache.org/jira/browse/MESOS-957
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-957
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduce a repair coordinator class to master.
>
> Add a RepairCoordinator class to master. Currently it is just
> a stub, but it will soon get wired up to the new observe end-point
> in master and recieve slave state updates. From there, it will be
> responsible for persisting the state and ultimately performing
> repairs on unhealthy slaves.
>
> The RepairCoordinator has virtual methods and destructor so that
> it can easily be mocked for testing.
>
> Updated the existing master constructor to take a RepairCoordinator*
> and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new
> up a RepairCoordinator, pass it to master's constructor and delete
> the RepairCoordinator when it's finished.
>
>
> Diffs
> -----
>
> src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4
> src/local/local.cpp 83a7f913afb1441e9137c7fcec8fd81815714905
> src/master/main.cpp b1e45766281c5ea0b8a3cee89e390ea60a97c5e4
> src/master/master.hpp 7649737283f5f5d786ac40504e943a3be4c1d62b
> src/master/master.cpp 77872ece66601043ddeb280cceba5a7676e8a6be
> src/master/repair_coordinator.hpp PRE-CREATION
> src/master/repair_coordinator.cpp PRE-CREATION
> src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
>
> Diff: https://reviews.apache.org/r/17564/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Charlie Carson
>
>
Re: Review Request 17564: Introduce a Repairer class to master.
Posted by Charlie Carson <ch...@gmail.com>.
> On Feb. 16, 2014, 1:44 a.m., Ben Mahler wrote:
> >
switched to Repairer :-)
- Charlie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17564/#review34577
-----------------------------------------------------------
On Feb. 18, 2014, 9:45 p.m., Charlie Carson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17564/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2014, 9:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone.
>
>
> Bugs: MESOS-957
> https://issues.apache.org/jira/browse/MESOS-957
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduce a Repairer class to master.
>
> Add a Repairer class to master. Currently it is just a stub, but it will
> soon get wired up to the new observe end-point in master and recieve slave
> state updates. From there, it will be responsible for persisting the state
> and ultimately performing repairs on unhealthy slaves.
>
> The Repairer has virtual methods and destructor so that it can easily be
> mocked for testing.
>
> Updated the existing master constructor to take a Repairer*
> and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new
> up a Repairer, pass it to master's constructor and delete
> the Repairer when it's finished.
>
> Review: https://reviews.apache.org/r/17564
>
>
> Diffs
> -----
>
> src/Makefile.am 768c66a5369a05e5633454200880d13620ecb5e6
> src/local/local.cpp 51123911595a7a2ac48458707ded2835935cbcbc
> src/master/main.cpp ab4846eaebc13fe619c335c7763ac0b711df3d47
> src/master/master.hpp 9d1b56c6b02eb21130f165848297ae0695ac2af7
> src/master/master.cpp f4f5e04e3f98428137e986f24a0bc897801be482
> src/master/repairer.hpp PRE-CREATION
> src/master/repairer.cpp PRE-CREATION
> src/tests/cluster.hpp 5100959f5de1e8e93bfbdeba26c95a33fe59f7e1
>
> Diff: https://reviews.apache.org/r/17564/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Charlie Carson
>
>
Re: Review Request 17564: Introduce a RepairMan class to master.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17564/#review34577
-----------------------------------------------------------
src/master/repair_man.hpp
<https://reviews.apache.org/r/17564/#comment64723>
I like Vinod's suggestion of 'Repairer' since repairman is not gender neutral, and repairer describes the functionality more purely. Thoughts?
- Ben Mahler
On Feb. 15, 2014, 1:56 a.m., Charlie Carson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17564/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2014, 1:56 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone.
>
>
> Bugs: MESOS-957
> https://issues.apache.org/jira/browse/MESOS-957
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduce a RepairMan class to master.
>
> Add a RepairMan class to master. Currently it is just a stub, but it will
> soon get wired up to the new observe end-point in master and recieve slave
> state updates. From there, it will be responsible for persisting the state
> and ultimately performing repairs on unhealthy slaves.
>
> The RepairMan has virtual methods and destructor so that it can easily be
> mocked for testing.
>
> Updated the existing master constructor to take a RepairMan*
> and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new
> up a RepairMan, pass it to master's constructor and delete
> the RepairMan when it's finished.
>
>
> Diffs
> -----
>
> src/Makefile.am aa8bb2b492e4d37b14db294f48c074e631143b68
> src/local/local.cpp 51123911595a7a2ac48458707ded2835935cbcbc
> src/master/main.cpp ab4846eaebc13fe619c335c7763ac0b711df3d47
> src/master/master.hpp 737bd8b5a1cd88a98a7f094795c50547079921ba
> src/master/master.cpp a4e1b1f7327f01eb16f14c3fa08fc7a62048d36c
> src/master/repair_man.hpp PRE-CREATION
> src/master/repair_man.cpp PRE-CREATION
> src/tests/cluster.hpp 5100959f5de1e8e93bfbdeba26c95a33fe59f7e1
>
> Diff: https://reviews.apache.org/r/17564/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Charlie Carson
>
>
Re: Review Request 17564: Introduce a Repairer class to master.
Posted by Charlie Carson <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17564/
-----------------------------------------------------------
(Updated Feb. 18, 2014, 9:45 p.m.)
Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone.
Changes
-------
changed from RepairMan -> Repairer
Summary (updated)
-----------------
Introduce a Repairer class to master.
Bugs: MESOS-957
https://issues.apache.org/jira/browse/MESOS-957
Repository: mesos-git
Description (updated)
-------
Introduce a Repairer class to master.
Add a Repairer class to master. Currently it is just a stub, but it will
soon get wired up to the new observe end-point in master and recieve slave
state updates. From there, it will be responsible for persisting the state
and ultimately performing repairs on unhealthy slaves.
The Repairer has virtual methods and destructor so that it can easily be
mocked for testing.
Updated the existing master constructor to take a Repairer*
and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new
up a Repairer, pass it to master's constructor and delete
the Repairer when it's finished.
Review: https://reviews.apache.org/r/17564
Diffs (updated)
-----
src/Makefile.am 768c66a5369a05e5633454200880d13620ecb5e6
src/local/local.cpp 51123911595a7a2ac48458707ded2835935cbcbc
src/master/main.cpp ab4846eaebc13fe619c335c7763ac0b711df3d47
src/master/master.hpp 9d1b56c6b02eb21130f165848297ae0695ac2af7
src/master/master.cpp f4f5e04e3f98428137e986f24a0bc897801be482
src/master/repairer.hpp PRE-CREATION
src/master/repairer.cpp PRE-CREATION
src/tests/cluster.hpp 5100959f5de1e8e93bfbdeba26c95a33fe59f7e1
Diff: https://reviews.apache.org/r/17564/diff/
Testing
-------
make check
Thanks,
Charlie Carson
Re: Review Request 17564: Introduce a RepairMan class to master.
Posted by Charlie Carson <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17564/
-----------------------------------------------------------
(Updated Feb. 15, 2014, 1:56 a.m.)
Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone.
Summary (updated)
-----------------
Introduce a RepairMan class to master.
Bugs: MESOS-957
https://issues.apache.org/jira/browse/MESOS-957
Repository: mesos-git
Description (updated)
-------
Introduce a RepairMan class to master.
Add a RepairMan class to master. Currently it is just a stub, but it will
soon get wired up to the new observe end-point in master and recieve slave
state updates. From there, it will be responsible for persisting the state
and ultimately performing repairs on unhealthy slaves.
The RepairMan has virtual methods and destructor so that it can easily be
mocked for testing.
Updated the existing master constructor to take a RepairMan*
and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new
up a RepairMan, pass it to master's constructor and delete
the RepairMan when it's finished.
Diffs (updated)
-----
src/Makefile.am aa8bb2b492e4d37b14db294f48c074e631143b68
src/local/local.cpp 51123911595a7a2ac48458707ded2835935cbcbc
src/master/main.cpp ab4846eaebc13fe619c335c7763ac0b711df3d47
src/master/master.hpp 737bd8b5a1cd88a98a7f094795c50547079921ba
src/master/master.cpp a4e1b1f7327f01eb16f14c3fa08fc7a62048d36c
src/master/repair_man.hpp PRE-CREATION
src/master/repair_man.cpp PRE-CREATION
src/tests/cluster.hpp 5100959f5de1e8e93bfbdeba26c95a33fe59f7e1
Diff: https://reviews.apache.org/r/17564/diff/
Testing
-------
make check
Thanks,
Charlie Carson
Re: Review Request 17564: Introduce a RepairMan class to master.
Posted by Charlie Carson <ch...@gmail.com>.
> On Feb. 11, 2014, 2:34 a.m., Vinod Kone wrote:
> > FYI, when you attach a bug to the RB you should just give the issue key (e.g., MESOS-800) not the whole url :)
fixed :-)
> On Feb. 11, 2014, 2:34 a.m., Vinod Kone wrote:
> > src/local/local.cpp, line 58
> > <https://reviews.apache.org/r/17564/diff/2/?file=482203#file482203line58>
> >
> > In interest of short names how about
> >
> > s/RepairCoordinator/Repairer/ ?
renamed to RepairMan per Ben & Jeff's vote
- Charlie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17564/#review34162
-----------------------------------------------------------
On Feb. 15, 2014, 1:56 a.m., Charlie Carson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17564/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2014, 1:56 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone.
>
>
> Bugs: MESOS-957
> https://issues.apache.org/jira/browse/MESOS-957
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduce a RepairMan class to master.
>
> Add a RepairMan class to master. Currently it is just a stub, but it will
> soon get wired up to the new observe end-point in master and recieve slave
> state updates. From there, it will be responsible for persisting the state
> and ultimately performing repairs on unhealthy slaves.
>
> The RepairMan has virtual methods and destructor so that it can easily be
> mocked for testing.
>
> Updated the existing master constructor to take a RepairMan*
> and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new
> up a RepairMan, pass it to master's constructor and delete
> the RepairMan when it's finished.
>
>
> Diffs
> -----
>
> src/Makefile.am aa8bb2b492e4d37b14db294f48c074e631143b68
> src/local/local.cpp 51123911595a7a2ac48458707ded2835935cbcbc
> src/master/main.cpp ab4846eaebc13fe619c335c7763ac0b711df3d47
> src/master/master.hpp 737bd8b5a1cd88a98a7f094795c50547079921ba
> src/master/master.cpp a4e1b1f7327f01eb16f14c3fa08fc7a62048d36c
> src/master/repair_man.hpp PRE-CREATION
> src/master/repair_man.cpp PRE-CREATION
> src/tests/cluster.hpp 5100959f5de1e8e93bfbdeba26c95a33fe59f7e1
>
> Diff: https://reviews.apache.org/r/17564/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Charlie Carson
>
>
Re: Review Request 17564: Introduce a repair coordinator class to master.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17564/#review34162
-----------------------------------------------------------
Ship it!
FYI, when you attach a bug to the RB you should just give the issue key (e.g., MESOS-800) not the whole url :)
src/local/local.cpp
<https://reviews.apache.org/r/17564/#comment64181>
In interest of short names how about
s/RepairCoordinator/Repairer/ ?
- Vinod Kone
On Feb. 10, 2014, 10:27 p.m., Charlie Carson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17564/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2014, 10:27 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone.
>
>
> Bugs: https://issues.apache.org/jira/browse/MESOS-957
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-957
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Introduce a repair coordinator class to master.
>
> Add a RepairCoordinator class to master. Currently it is just
> a stub, but it will soon get wired up to the new observe end-point
> in master and recieve slave state updates. From there, it will be
> responsible for persisting the state and ultimately performing
> repairs on unhealthy slaves.
>
> The RepairCoordinator has virtual methods and destructor so that
> it can easily be mocked for testing.
>
> Updated the existing master constructor to take a RepairCoordinator*
> and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new
> up a RepairCoordinator, pass it to master's constructor and delete
> the RepairCoordinator when it's finished.
>
>
> Diffs
> -----
>
> src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4
> src/local/local.cpp 83a7f913afb1441e9137c7fcec8fd81815714905
> src/master/main.cpp 4f1859fba15c3f6c581d098337dc3262ec68bf3c
> src/master/master.hpp 7649737283f5f5d786ac40504e943a3be4c1d62b
> src/master/master.cpp 241b0069902cd125fdd933096ddd7e1c841d1559
> src/master/repair_coordinator.hpp PRE-CREATION
> src/master/repair_coordinator.cpp PRE-CREATION
> src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
>
> Diff: https://reviews.apache.org/r/17564/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Charlie Carson
>
>
Re: Review Request 17564: Introduce a repair coordinator class to master.
Posted by Charlie Carson <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17564/
-----------------------------------------------------------
(Updated Feb. 10, 2014, 10:27 p.m.)
Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone.
Bugs: https://issues.apache.org/jira/browse/MESOS-957
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-957
Repository: mesos-git
Description
-------
Introduce a repair coordinator class to master.
Add a RepairCoordinator class to master. Currently it is just
a stub, but it will soon get wired up to the new observe end-point
in master and recieve slave state updates. From there, it will be
responsible for persisting the state and ultimately performing
repairs on unhealthy slaves.
The RepairCoordinator has virtual methods and destructor so that
it can easily be mocked for testing.
Updated the existing master constructor to take a RepairCoordinator*
and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new
up a RepairCoordinator, pass it to master's constructor and delete
the RepairCoordinator when it's finished.
Diffs (updated)
-----
src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4
src/local/local.cpp 83a7f913afb1441e9137c7fcec8fd81815714905
src/master/main.cpp 4f1859fba15c3f6c581d098337dc3262ec68bf3c
src/master/master.hpp 7649737283f5f5d786ac40504e943a3be4c1d62b
src/master/master.cpp 241b0069902cd125fdd933096ddd7e1c841d1559
src/master/repair_coordinator.hpp PRE-CREATION
src/master/repair_coordinator.cpp PRE-CREATION
src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
Diff: https://reviews.apache.org/r/17564/diff/
Testing
-------
make check
Thanks,
Charlie Carson
Re: Review Request 17564: Introduce a repair coordinator class to master.
Posted by Charlie Carson <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17564/
-----------------------------------------------------------
(Updated Jan. 31, 2014, 12:18 a.m.)
Review request for mesos, Benjamin Hindman, Jeff Currier, and Vinod Kone.
Bugs: https://issues.apache.org/jira/browse/MESOS-957
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-957
Repository: mesos-git
Description
-------
Introduce a repair coordinator class to master.
Add a RepairCoordinator class to master. Currently it is just
a stub, but it will soon get wired up to the new observe end-point
in master and recieve slave state updates. From there, it will be
responsible for persisting the state and ultimately performing
repairs on unhealthy slaves.
The RepairCoordinator has virtual methods and destructor so that
it can easily be mocked for testing.
Updated the existing master constructor to take a RepairCoordinator*
and local/local.cpp, master/main.cpp, & tests/cluster.hpp to new
up a RepairCoordinator, pass it to master's constructor and delete
the RepairCoordinator when it's finished.
Diffs
-----
src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4
src/local/local.cpp 83a7f913afb1441e9137c7fcec8fd81815714905
src/master/main.cpp b1e45766281c5ea0b8a3cee89e390ea60a97c5e4
src/master/master.hpp 7649737283f5f5d786ac40504e943a3be4c1d62b
src/master/master.cpp 77872ece66601043ddeb280cceba5a7676e8a6be
src/master/repair_coordinator.hpp PRE-CREATION
src/master/repair_coordinator.cpp PRE-CREATION
src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108
Diff: https://reviews.apache.org/r/17564/diff/
Testing
-------
make check
Thanks,
Charlie Carson