You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/22 11:16:27 UTC

[GitHub] [flink-kubernetes-operator] rgsriram opened a new pull request, #408: Added improvements on the flink python example Dockerfile

rgsriram opened a new pull request, #408:
URL: https://github.com/apache/flink-kubernetes-operator/pull/408

   ## What is the purpose of the change
   
   *Added improvements in the dockerfile for the python example. This change decouples the tight binding with flink minor version in the dockerfile.*
   
   ## Brief change log
   - Added improvements on the flink python example Dockerfile
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage. Just fixed the example flink python docker file.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
     - Core observer or reconciler logic that is regularly executed: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] rgsriram commented on a diff in pull request #408: Added improvements on the flink python example Dockerfile

Posted by GitBox <gi...@apache.org>.
rgsriram commented on code in PR #408:
URL: https://github.com/apache/flink-kubernetes-operator/pull/408#discussion_r1002928530


##########
examples/flink-python-example/Dockerfile:
##########
@@ -36,7 +36,7 @@ apt-get clean && \
 rm -rf /var/lib/apt/lists/*
 
 # install PyFlink
-RUN pip3 install apache-flink==1.15.0
+RUN pip3 install "apache-flink>=1.15.0,<1.16.0"

Review Comment:
   Suggesting to be `RUN pip3 install "apache-flink>=1.15.0"`?. As per my understanding, we are using flink 1.15 in this example (`FROM flink:1.15`).  That could be the reason for `apache-flink>=1.15.0,<1.16.0`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] rgsriram commented on a diff in pull request #408: Added improvements on the flink python example Dockerfile

Posted by GitBox <gi...@apache.org>.
rgsriram commented on code in PR #408:
URL: https://github.com/apache/flink-kubernetes-operator/pull/408#discussion_r1002928530


##########
examples/flink-python-example/Dockerfile:
##########
@@ -36,7 +36,7 @@ apt-get clean && \
 rm -rf /var/lib/apt/lists/*
 
 # install PyFlink
-RUN pip3 install apache-flink==1.15.0
+RUN pip3 install "apache-flink>=1.15.0,<1.16.0"

Review Comment:
   Suggesting to be `RUN pip3 install "apache-flink>=1.15.0"`?.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] bgeng777 commented on pull request #408: Added improvements on the flink python example Dockerfile

Posted by GitBox <gi...@apache.org>.
bgeng777 commented on PR #408:
URL: https://github.com/apache/flink-kubernetes-operator/pull/408#issuecomment-1287770774

   Thanks for the pr. LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #408: Added improvements on the flink python example Dockerfile

Posted by GitBox <gi...@apache.org>.
gyfora merged PR #408:
URL: https://github.com/apache/flink-kubernetes-operator/pull/408


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #408: Added improvements on the flink python example Dockerfile

Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #408:
URL: https://github.com/apache/flink-kubernetes-operator/pull/408#discussion_r1002926848


##########
examples/flink-python-example/Dockerfile:
##########
@@ -36,7 +36,7 @@ apt-get clean && \
 rm -rf /var/lib/apt/lists/*
 
 # install PyFlink
-RUN pip3 install apache-flink==1.15.0
+RUN pip3 install "apache-flink>=1.15.0,<1.16.0"

Review Comment:
   Is this necessary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org