You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/16 11:19:12 UTC

[GitHub] [fineract] kiran-vsm opened a new pull request #895: FINERACT-976 : Client date of birth can not be greater than the client submitted on date

kiran-vsm opened a new pull request #895:
URL: https://github.com/apache/fineract/pull/895


   
   
   ## Description
   Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
   
   - [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger merged pull request #895: FINERACT-976 : Client date of birth can not be greater than the client submitted on date

Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #895:
URL: https://github.com/apache/fineract/pull/895


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #895: FINERACT-976 : Client date of birth can not be greater than the client submitted on date

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #895:
URL: https://github.com/apache/fineract/pull/895#issuecomment-644968196


   @kiran-vsm please make more contributions!! :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #895: FINERACT-976 : Client date of birth can not be greater than the client submitted on date

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #895:
URL: https://github.com/apache/fineract/pull/895#issuecomment-629643430


   Checkstyle failed, you can run it locally and fix it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #895: FINERACT-976 : Client date of birth can not be greater than the client submitted on date

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #895:
URL: https://github.com/apache/fineract/pull/895#issuecomment-629646249


   Dear first time contributor,
   
   Welcome to Apache Fineract!!
   
   Have you read https://github.com/apache/fineract/#pull-requests?
   
   Already subscribed to our mailing list, by sending an (empty) email to dev-subscribe@fineract.apache.org?
   
   Created your JIRA account on https://issues.apache.org/jira/projects/FINERACT/?
   
   Played with our server at https://www.fineract.dev?
   
   We're very excited to have you onboard contributing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] awasum commented on pull request #895: FINERACT-976 : Client date of birth can not be greater than the client submitted on date

Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #895:
URL: https://github.com/apache/fineract/pull/895#issuecomment-631410838


   @kiran-vsm . Do you want to address the feedback given to your by fixing the issue and making Travis show green? Do you have a specific problem blocking you ? This will be a valuable contribution?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] kiran-vsm commented on pull request #895: FINERACT-976 : Client date of birth can not be greater than the client submitted on date

Posted by GitBox <gi...@apache.org>.
kiran-vsm commented on pull request #895:
URL: https://github.com/apache/fineract/pull/895#issuecomment-644625346


   @vorburger: Thanks for your above guidelines.
   Corrected Checkstyle issues and re-sent the PR. 
   Please check it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org