You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Balázs Palcsó (JIRA)" <ji...@apache.org> on 2012/11/22 08:10:58 UTC
[jira] [Created] (TAP5-2028)
org.apache.tapestry5.ioc.internal.util.MessagesImpl should load messages
with UTF-8 encoding
Balázs Palcsó created TAP5-2028:
-----------------------------------
Summary: org.apache.tapestry5.ioc.internal.util.MessagesImpl should load messages with UTF-8 encoding
Key: TAP5-2028
URL: https://issues.apache.org/jira/browse/TAP5-2028
Project: Tapestry 5
Issue Type: Improvement
Components: tapestry-ioc
Affects Versions: 5.3.6
Reporter: Balázs Palcsó
In my tests I'd like to verify the content of the generated HTML. Instead of duplicating and hard coding the output messages that already exist in properties file I would like to load the messages from the properties file of the page classes I am testing.
I was looking around the possibilities and I found that MessagesImpl would fit my needs. (and also asked on the users list: http://tapestry.1045711.n5.nabble.com/Unable-to-load-messages-in-UTF-8-encoding-in-test-class-in-different-class-than-messages-belong-to-tp5717808.html)
private final Messages messages = MessagesImpl.forClass(Registration.class);
would be the proper solution to load messages of my Registration page if
MessagesImpl.forClass(Class) used UTF-8 encoding instead of the default
ISO-8859-1 (latin1) when loading properties files.
In pages and components my UTF-8 encoded properties files work correctly as
documented at http://tapestry.apache.org/localization.html
Currently MessagesImpl is part of the internal package, but I think this class would be useful wider usage therefore I would suggest moving this class to a "public" package.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-2028)
org.apache.tapestry5.ioc.internal.util.MessagesImpl should load messages
with UTF-8 encoding
Posted by "Balázs Palcsó (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Balázs Palcsó updated TAP5-2028:
--------------------------------
Attachment: MessagesImplUTF8.patch
I have attached my patch. I have done a successful full build with all tests.
This patch does not include unit test for the change. I can provide this later this week.
> org.apache.tapestry5.ioc.internal.util.MessagesImpl should load messages with UTF-8 encoding
> --------------------------------------------------------------------------------------------
>
> Key: TAP5-2028
> URL: https://issues.apache.org/jira/browse/TAP5-2028
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-ioc
> Affects Versions: 5.3.6
> Reporter: Balázs Palcsó
> Labels: patch
> Attachments: MessagesImplUTF8.patch
>
>
> In my tests I'd like to verify the content of the generated HTML. Instead of duplicating and hard coding the output messages that already exist in properties file I would like to load the messages from the properties file of the page classes I am testing.
> I was looking around the possibilities and I found that MessagesImpl would fit my needs. (and also asked on the users list: http://tapestry.1045711.n5.nabble.com/Unable-to-load-messages-in-UTF-8-encoding-in-test-class-in-different-class-than-messages-belong-to-tp5717808.html)
> private final Messages messages = MessagesImpl.forClass(Registration.class);
> would be the proper solution to load messages of my Registration page if
> MessagesImpl.forClass(Class) used UTF-8 encoding instead of the default
> ISO-8859-1 (latin1) when loading properties files.
> In pages and components my UTF-8 encoded properties files work correctly as
> documented at http://tapestry.apache.org/localization.html
> Currently MessagesImpl is part of the internal package, but I think this class would be useful wider usage therefore I would suggest moving this class to a "public" package.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-2028)
org.apache.tapestry5.ioc.internal.util.MessagesImpl should load messages
with UTF-8 encoding
Posted by "Balázs Palcsó (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Balázs Palcsó updated TAP5-2028:
--------------------------------
Attachment: MessagesImplUTF8.patch
I have attached my patch. I have done a successful full build with all tests.
This patch does not include unit test for the change. I can provide this later this week.
> org.apache.tapestry5.ioc.internal.util.MessagesImpl should load messages with UTF-8 encoding
> --------------------------------------------------------------------------------------------
>
> Key: TAP5-2028
> URL: https://issues.apache.org/jira/browse/TAP5-2028
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-ioc
> Affects Versions: 5.3.6
> Reporter: Balázs Palcsó
> Labels: patch
> Attachments: MessagesImplUTF8.patch
>
>
> In my tests I'd like to verify the content of the generated HTML. Instead of duplicating and hard coding the output messages that already exist in properties file I would like to load the messages from the properties file of the page classes I am testing.
> I was looking around the possibilities and I found that MessagesImpl would fit my needs. (and also asked on the users list: http://tapestry.1045711.n5.nabble.com/Unable-to-load-messages-in-UTF-8-encoding-in-test-class-in-different-class-than-messages-belong-to-tp5717808.html)
> private final Messages messages = MessagesImpl.forClass(Registration.class);
> would be the proper solution to load messages of my Registration page if
> MessagesImpl.forClass(Class) used UTF-8 encoding instead of the default
> ISO-8859-1 (latin1) when loading properties files.
> In pages and components my UTF-8 encoded properties files work correctly as
> documented at http://tapestry.apache.org/localization.html
> Currently MessagesImpl is part of the internal package, but I think this class would be useful wider usage therefore I would suggest moving this class to a "public" package.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-2028)
org.apache.tapestry5.ioc.internal.util.MessagesImpl should load messages
with UTF-8 encoding
Posted by "Balázs Palcsó (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502885#comment-13502885 ]
Balázs Palcsó commented on TAP5-2028:
-------------------------------------
I will write the tests after a committer agrees with using UFT-8 encoding.
> org.apache.tapestry5.ioc.internal.util.MessagesImpl should load messages with UTF-8 encoding
> --------------------------------------------------------------------------------------------
>
> Key: TAP5-2028
> URL: https://issues.apache.org/jira/browse/TAP5-2028
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-ioc
> Affects Versions: 5.3.6
> Reporter: Balázs Palcsó
> Labels: patch
> Attachments: MessagesImplUTF8.patch
>
>
> In my tests I'd like to verify the content of the generated HTML. Instead of duplicating and hard coding the output messages that already exist in properties file I would like to load the messages from the properties file of the page classes I am testing.
> I was looking around the possibilities and I found that MessagesImpl would fit my needs. (and also asked on the users list: http://tapestry.1045711.n5.nabble.com/Unable-to-load-messages-in-UTF-8-encoding-in-test-class-in-different-class-than-messages-belong-to-tp5717808.html)
> private final Messages messages = MessagesImpl.forClass(Registration.class);
> would be the proper solution to load messages of my Registration page if
> MessagesImpl.forClass(Class) used UTF-8 encoding instead of the default
> ISO-8859-1 (latin1) when loading properties files.
> In pages and components my UTF-8 encoded properties files work correctly as
> documented at http://tapestry.apache.org/localization.html
> Currently MessagesImpl is part of the internal package, but I think this class would be useful wider usage therefore I would suggest moving this class to a "public" package.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-2028)
org.apache.tapestry5.ioc.internal.util.MessagesImpl should load messages
with UTF-8 encoding
Posted by "Balázs Palcsó (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502885#comment-13502885 ]
Balázs Palcsó commented on TAP5-2028:
-------------------------------------
I will write the tests after a committer agrees with using UFT-8 encoding.
> org.apache.tapestry5.ioc.internal.util.MessagesImpl should load messages with UTF-8 encoding
> --------------------------------------------------------------------------------------------
>
> Key: TAP5-2028
> URL: https://issues.apache.org/jira/browse/TAP5-2028
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-ioc
> Affects Versions: 5.3.6
> Reporter: Balázs Palcsó
> Labels: patch
> Attachments: MessagesImplUTF8.patch
>
>
> In my tests I'd like to verify the content of the generated HTML. Instead of duplicating and hard coding the output messages that already exist in properties file I would like to load the messages from the properties file of the page classes I am testing.
> I was looking around the possibilities and I found that MessagesImpl would fit my needs. (and also asked on the users list: http://tapestry.1045711.n5.nabble.com/Unable-to-load-messages-in-UTF-8-encoding-in-test-class-in-different-class-than-messages-belong-to-tp5717808.html)
> private final Messages messages = MessagesImpl.forClass(Registration.class);
> would be the proper solution to load messages of my Registration page if
> MessagesImpl.forClass(Class) used UTF-8 encoding instead of the default
> ISO-8859-1 (latin1) when loading properties files.
> In pages and components my UTF-8 encoded properties files work correctly as
> documented at http://tapestry.apache.org/localization.html
> Currently MessagesImpl is part of the internal package, but I think this class would be useful wider usage therefore I would suggest moving this class to a "public" package.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira