You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/23 20:18:22 UTC
[GitHub] [airflow] porterdarby opened a new pull request #15509: Remove condition field from depends_on for Docker Compose version 3 file.
porterdarby opened a new pull request #15509:
URL: https://github.com/apache/airflow/pull/15509
Docker Compose version 3 does not support the `condition` field for `depends_on` objects (see https://docs.docker.com/compose/compose-file/compose-file-v3/#depends_on). The current use of `condition` can be confusing (I was confused by it at first).
This change removes the `condition` fields and makes the `depends_on` a list.
This should present no problems with the current state of the application as it simply fixes a yaml file structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] porterdarby closed pull request #15509: Remove condition field from depends_on for Docker Compose version 3 file.
Posted by GitBox <gi...@apache.org>.
porterdarby closed pull request #15509:
URL: https://github.com/apache/airflow/pull/15509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #15509: Remove condition field from depends_on for Docker Compose version 3 file.
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #15509:
URL: https://github.com/apache/airflow/pull/15509#issuecomment-826120396
Docker Compose supports condition field. This prevents the container from running until the service reports that it is healthy.
https://github.com/docker/compose/blob/c81046aac0ce1360f1bab64368f9a318c593d82a/compose/config/compose_spec.json#L184-L195
https://github.com/docker/compose/blob/0bea52b18dda3de8c28fcfb0c80cc08b8950645e/compose/service.py#L756-L757
It is also supported by compose spec:
https://github.com/compose-spec/compose-spec/blob/b7fb5b65fff19651ecdb2d4d3232b01fb6866f70/schema/compose-spec.json#L184-L196
To me, it looks like an issue in the docker documentation.
See also: https://github.com/apache/airflow/pull/13446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15509: Remove condition field from depends_on for Docker Compose version 3 file.
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15509:
URL: https://github.com/apache/airflow/pull/15509#issuecomment-825896641
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #15509: Remove condition field from depends_on for Docker Compose version 3 file.
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #15509:
URL: https://github.com/apache/airflow/pull/15509#issuecomment-826120396
Docker Compose supports condition field. This prevents the container from running until the service reports that it is healthy.
https://github.com/docker/compose/blob/c81046aac0ce1360f1bab64368f9a318c593d82a/compose/config/compose_spec.json#L184-L195
https://github.com/docker/compose/blob/0bea52b18dda3de8c28fcfb0c80cc08b8950645e/compose/service.py#L756-L757
It is also supported by compose spec:
https://github.com/compose-spec/compose-spec/blob/b7fb5b65fff19651ecdb2d4d3232b01fb6866f70/schema/compose-spec.json#L184-L196
To me, it looks like an issue in the docker documentation.
See also: https://github.com/apache/airflow/pull/13446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] porterdarby commented on pull request #15509: Remove condition field from depends_on for Docker Compose version 3 file.
Posted by GitBox <gi...@apache.org>.
porterdarby commented on pull request #15509:
URL: https://github.com/apache/airflow/pull/15509#issuecomment-826180634
Thanks for correcting me here. I'll see if there are some tests or something over on the Docker side and attempt to clarify that documentation. I made a quick little test locally, and the "depender" service timed out while waiting for the "dependee" service to become healthy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] porterdarby closed pull request #15509: Remove condition field from depends_on for Docker Compose version 3 file.
Posted by GitBox <gi...@apache.org>.
porterdarby closed pull request #15509:
URL: https://github.com/apache/airflow/pull/15509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] porterdarby commented on pull request #15509: Remove condition field from depends_on for Docker Compose version 3 file.
Posted by GitBox <gi...@apache.org>.
porterdarby commented on pull request #15509:
URL: https://github.com/apache/airflow/pull/15509#issuecomment-826180634
Thanks for correcting me here. I'll see if there are some tests or something over on the Docker side and attempt to clarify that documentation. I made a quick little test locally, and the "depender" service timed out while waiting for the "dependee" service to become healthy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org