[jira] [Commented] (TEZ-3981) UnorderedPartitionedKVWriter.getInitialMemoryRequirement may return negative memory

["Jonathan Eagles (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626538#comment-16626538 ] 

Jonathan Eagles commented on TEZ-3981:
--------------------------------------

+1. This looks like a corresponding unordered output change that TEZ-1800 added to ordered output. A little surprised to see 2^12+ unsort buffer are allowed since ordered output prevents 1800+. But the change is correct.

> UnorderedPartitionedKVWriter.getInitialMemoryRequirement may return negative memory
> -----------------------------------------------------------------------------------
>
>                 Key: TEZ-3981
>                 URL: https://issues.apache.org/jira/browse/TEZ-3981
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.9.1
>            Reporter: Jaume M
>            Assignee: Jaume M
>            Priority: Major
>         Attachments: TEZ-3981.1.patch
>
>
> The reason for this is because [here|https://github.com/apache/tez/blob/4b9a7be1b98cff00c44e7d3ffb2486bb59ca6804/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/writers/UnorderedPartitionedKVWriter.java#L678] first we shift the int, and then we assign it to the long, therefore if the int is bigger than {{2^12}} when shifting {{20}} it becomes a negative value. We should cast to long and then do the shift. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)