You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/27 23:43:12 UTC
[GitHub] [incubator-mxnet] szha opened a new pull request #17453: [CD]
update publish path
szha opened a new pull request #17453: [CD] update publish path
URL: https://github.com/apache/incubator-mxnet/pull/17453
## Description ##
update publish path
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [x] update publish path to put wheels in its own namespace
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request
#17453: [CD] update publish path
Posted by GitBox <gi...@apache.org>.
marcoabreu commented on a change in pull request #17453: [CD] update publish path
URL: https://github.com/apache/incubator-mxnet/pull/17453#discussion_r372173063
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -2048,7 +2048,7 @@ cd_s3_publish() {
if [ -z "${variant}" ]; then
variant="cpu"
fi
- aws s3 cp ${filepath} s3://apache-mxnet/dist/${variant}/${filename} --grants read=uri=http://acs.amazonaws.com/groups/global/AllUsers full=id=43f628fab72838a4f0b929d7f1993b14411f4b0294b011261bc6bd3e950a6822
+ aws s3 cp ${filepath} s3://apache-mxnet/dist/python/${variant}/${filename} --grants read=uri=http://acs.amazonaws.com/groups/global/AllUsers full=id=43f628fab72838a4f0b929d7f1993b14411f4b0294b011261bc6bd3e950a6822
Review comment:
The CodeBuild pipeline no longer publishes to that bucket, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] szha commented on a change in pull request
#17453: [CD] update publish path
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #17453: [CD] update publish path
URL: https://github.com/apache/incubator-mxnet/pull/17453#discussion_r371553445
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -2048,7 +2048,7 @@ cd_s3_publish() {
if [ -z "${variant}" ]; then
variant="cpu"
fi
- aws s3 cp ${filepath} s3://apache-mxnet/dist/${variant}/${filename} --grants read=uri=http://acs.amazonaws.com/groups/global/AllUsers full=id=43f628fab72838a4f0b929d7f1993b14411f4b0294b011261bc6bd3e950a6822
+ aws s3 cp ${filepath} s3://apache-mxnet/dist/python/${variant}/${filename} --grants read=uri=http://acs.amazonaws.com/groups/global/AllUsers full=id=43f628fab72838a4f0b929d7f1993b14411f4b0294b011261bc6bd3e950a6822
Review comment:
Yes, they will need to be copied. Those date-based folders will no longer be kept in the CD pipeline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu merged pull request #17453: [CD] update
publish path
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #17453: [CD] update publish path
URL: https://github.com/apache/incubator-mxnet/pull/17453
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on a change in pull request
#17453: [CD] update publish path
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #17453: [CD] update publish path
URL: https://github.com/apache/incubator-mxnet/pull/17453#discussion_r371551188
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -2048,7 +2048,7 @@ cd_s3_publish() {
if [ -z "${variant}" ]; then
variant="cpu"
fi
- aws s3 cp ${filepath} s3://apache-mxnet/dist/${variant}/${filename} --grants read=uri=http://acs.amazonaws.com/groups/global/AllUsers full=id=43f628fab72838a4f0b929d7f1993b14411f4b0294b011261bc6bd3e950a6822
+ aws s3 cp ${filepath} s3://apache-mxnet/dist/python/${variant}/${filename} --grants read=uri=http://acs.amazonaws.com/groups/global/AllUsers full=id=43f628fab72838a4f0b929d7f1993b14411f4b0294b011261bc6bd3e950a6822
Review comment:
How about the date? I see there are `2020-01-27` folders at s3://apache-mxnet/dist/ but `20200127` folders at `s3://apache-mxnet/dist/python/`.
Is any further change required to assimilate the date format among both pipelines?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services