[GitHub] [accumulo] keith-turner edited a comment on issue #1358: Fix race conditions with commitsInProgress counter

[GitBox <gi...@apache.org>]

keith-turner edited a comment on issue #1358: Fix race conditions with commitsInProgress counter
URL: https://github.com/apache/accumulo/pull/1358#issuecomment-530861250
 
 
   > Update to use Java Concurrency classes (as an example for the rest of the code base)
   
   I think this could be a nice solution long term solution.  Create a Java lock object in tablet and pass it around, making things very explicit in the code, making the code easier to understand.  Java's reentrant lock has the method `isHeldByCurrentThread()` that could be used for precondition checks.  Still having a single lock makes reasoning about concurrency correctness easier.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services