You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mimaison (via GitHub)" <gi...@apache.org> on 2025/04/06 12:42:20 UTC
[PR] KAFKA-14523: Decouple RemoteLogManager and Partition [kafka]
mimaison opened a new pull request, #19391:
URL: https://github.com/apache/kafka/pull/19391
Remove the last dependency in the core module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14523: Decouple RemoteLogManager and Partition [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #19391:
URL: https://github.com/apache/kafka/pull/19391#issuecomment-2801137856
> Looks like all it needs is access to the broker id config. Perhaps this config should be made available from server-common or something like that.
Yes solving this last issue shouldn't be hard!
If you have time, you can review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14523: Decouple RemoteLogManager and Partition [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #19391:
URL: https://github.com/apache/kafka/pull/19391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14523: Decouple RemoteLogManager and Partition [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #19391:
URL: https://github.com/apache/kafka/pull/19391#issuecomment-2781406235
After that the last remaining piece of work before being able to move the `kafka.log.remote` classes to the storage module is to figure what to do with `ServerConfigs`. `RemoteLogManager` depends on it and it is in the `server` module and depends on `LogConfig` in the `storage` module so we can't just move it to `server-common`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14523: Decouple RemoteLogManager and Partition [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #19391:
URL: https://github.com/apache/kafka/pull/19391#issuecomment-2800171113
> RemoteLogManager depends on it and it is in the server module and depends on LogConfig in the storage module so we can't just move it to server-common.
Looks like all it needs is access to the broker id config. Perhaps this config should be made available from `server-common` or something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14523: Decouple RemoteLogManager and Partition [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #19391:
URL: https://github.com/apache/kafka/pull/19391#discussion_r2030649656
##########
storage/src/main/java/org/apache/kafka/server/log/remote/TopicPartitionLog.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.log.remote;
+
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.storage.internals.log.UnifiedLog;
+
+import java.util.Optional;
+
+/**
+ * Interface to decouple RemoteLogManager and Partition
+ */
+public interface TopicPartitionLog {
Review Comment:
To be honest I don't know at the moment. It depends where `Partition` ends up going but there's still a lot of work to do before we can move it, so I think we'll need this interface for a little while.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-14523: Decouple RemoteLogManager and Partition [kafka]
Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on code in PR #19391:
URL: https://github.com/apache/kafka/pull/19391#discussion_r2030535364
##########
storage/src/main/java/org/apache/kafka/server/log/remote/TopicPartitionLog.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.log.remote;
+
+import org.apache.kafka.common.TopicPartition;
+import org.apache.kafka.storage.internals.log.UnifiedLog;
+
+import java.util.Optional;
+
+/**
+ * Interface to decouple RemoteLogManager and Partition
+ */
+public interface TopicPartitionLog {
Review Comment:
Will this interface be removed after we migrate all code out of core module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org