You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2018/07/05 23:37:04 UTC
[kudu-CR] KUDU-2492: Make the use of SO REUSEPORT conditional on it being defined
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10875
Change subject: KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined
......................................................................
KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined
A recent commit to Kudu, "rpc: add experimental rpc_reuseport flag",
added the use of the rpc flag SO_REUSEREPORT. This flag is not
available with older versions of Linux, resulting in a compiler error.
This flag is just a performance optimization, so this patch just skips
setting it when it is not available.
Change-Id: I673fa09619955de162e2e2742480672b1e5c4d1d
---
M src/kudu/util/net/socket.cc
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/10875/1
--
To view, visit http://gerrit.cloudera.org:8080/10875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I673fa09619955de162e2e2742480672b1e5c4d1d
Gerrit-Change-Number: 10875
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
[kudu-CR] KUDU-2492: Make the use of SO REUSEPORT conditional on it being defined
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10875 )
Change subject: KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined
......................................................................
KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined
A recent commit to Kudu, "rpc: add experimental rpc_reuseport flag",
added the use of the rpc flag SO_REUSEREPORT. This flag is not
available with older versions of Linux, resulting in a compiler error.
This patch avoids the compiler error with a macro that checks if
SO_REUSEPORT is defined, and if it's not attempting to set it will
return an error.
Change-Id: I673fa09619955de162e2e2742480672b1e5c4d1d
Reviewed-on: http://gerrit.cloudera.org:8080/10875
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/util/net/socket.cc
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I673fa09619955de162e2e2742480672b1e5c4d1d
Gerrit-Change-Number: 10875
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[kudu-CR] KUDU-2492: Make the use of SO REUSEPORT conditional on it being defined
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10875 )
Change subject: KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined
......................................................................
Patch Set 3: Code-Review+2
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/10875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I673fa09619955de162e2e2742480672b1e5c4d1d
Gerrit-Change-Number: 10875
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Fri, 06 Jul 2018 22:42:41 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2492: Make the use of SO REUSEPORT conditional on it being defined
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10875 )
Change subject: KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10875/2/src/kudu/util/net/socket.cc
File src/kudu/util/net/socket.cc:
http://gerrit.cloudera.org:8080/#/c/10875/2/src/kudu/util/net/socket.cc@254
PS2, Line 254: NotSupporte
> use NotSupported
Done
--
To view, visit http://gerrit.cloudera.org:8080/10875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I673fa09619955de162e2e2742480672b1e5c4d1d
Gerrit-Change-Number: 10875
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Fri, 06 Jul 2018 22:27:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2492: Make the use of SO REUSEPORT conditional on it being defined
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10875 )
Change subject: KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10875/2/src/kudu/util/net/socket.cc
File src/kudu/util/net/socket.cc:
http://gerrit.cloudera.org:8080/#/c/10875/2/src/kudu/util/net/socket.cc@254
PS2, Line 254: ailed
'failed'
http://gerrit.cloudera.org:8080/#/c/10875/2/src/kudu/util/net/socket.cc@254
PS2, Line 254: NetworkErro
use NotSupported
--
To view, visit http://gerrit.cloudera.org:8080/10875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I673fa09619955de162e2e2742480672b1e5c4d1d
Gerrit-Change-Number: 10875
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Fri, 06 Jul 2018 17:58:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2492: Make the use of SO REUSEPORT conditional on it being defined
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10875 )
Change subject: KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10875/1/src/kudu/util/net/socket.cc
File src/kudu/util/net/socket.cc:
http://gerrit.cloudera.org:8080/#/c/10875/1/src/kudu/util/net/socket.cc@252
PS1, Line 252: return Status::OK();
> I think it'd be better to return an error status if SO_REUSEPORT isn't set,
Done
--
To view, visit http://gerrit.cloudera.org:8080/10875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I673fa09619955de162e2e2742480672b1e5c4d1d
Gerrit-Change-Number: 10875
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Fri, 06 Jul 2018 00:12:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2492: Make the use of SO REUSEPORT conditional on it being defined
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10875
to look at the new patch set (#2).
Change subject: KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined
......................................................................
KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined
A recent commit to Kudu, "rpc: add experimental rpc_reuseport flag",
added the use of the rpc flag SO_REUSEREPORT. This flag is not
available with older versions of Linux, resulting in a compiler error.
This patch avoids the compiler error with a macro that checks if
SO_REUSEPORT is defined, and if it's not attempting to set it will
return an error.
Change-Id: I673fa09619955de162e2e2742480672b1e5c4d1d
---
M src/kudu/util/net/socket.cc
1 file changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/10875/2
--
To view, visit http://gerrit.cloudera.org:8080/10875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I673fa09619955de162e2e2742480672b1e5c4d1d
Gerrit-Change-Number: 10875
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2492: Make the use of SO REUSEPORT conditional on it being defined
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10875
to look at the new patch set (#3).
Change subject: KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined
......................................................................
KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined
A recent commit to Kudu, "rpc: add experimental rpc_reuseport flag",
added the use of the rpc flag SO_REUSEREPORT. This flag is not
available with older versions of Linux, resulting in a compiler error.
This patch avoids the compiler error with a macro that checks if
SO_REUSEPORT is defined, and if it's not attempting to set it will
return an error.
Change-Id: I673fa09619955de162e2e2742480672b1e5c4d1d
---
M src/kudu/util/net/socket.cc
1 file changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/10875/3
--
To view, visit http://gerrit.cloudera.org:8080/10875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I673fa09619955de162e2e2742480672b1e5c4d1d
Gerrit-Change-Number: 10875
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[kudu-CR] KUDU-2492: Make the use of SO REUSEPORT conditional on it being defined
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10875 )
Change subject: KUDU-2492: Make the use of SO_REUSEPORT conditional on it being defined
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10875/1/src/kudu/util/net/socket.cc
File src/kudu/util/net/socket.cc:
http://gerrit.cloudera.org:8080/#/c/10875/1/src/kudu/util/net/socket.cc@252
PS1, Line 252: #endif
I think it'd be better to return an error status if SO_REUSEPORT isn't set, otherwise it's almost certain that a later call to bind the port will fail, and that will be harder to track down than a 'not supported' error message coming right from here.
--
To view, visit http://gerrit.cloudera.org:8080/10875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I673fa09619955de162e2e2742480672b1e5c4d1d
Gerrit-Change-Number: 10875
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 05 Jul 2018 23:52:33 +0000
Gerrit-HasComments: Yes