You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by JonZeolla <gi...@git.apache.org> on 2018/11/09 21:11:47 UTC
[GitHub] metron-bro-plugin-kafka pull request #16: METRON-1865: Fix metron-bro-plugin...
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/16
METRON-1865: Fix metron-bro-plugin-kafka tests
## Contributor Comments
This fixes the btests which were unintentionally broken as a part of apache/metron-bro-plugin-kafka#6.
An easy way to test this is to use `bro-pkg` to install the plugin (which runs all of the tests by default), or you can go on a properly configured box (wrt `btest`) and run `cd metron-bro-plugin-kafka/tests/ && btest -d`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JonZeolla/metron-bro-plugin-kafka METRON-1865
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron-bro-plugin-kafka/pull/16.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16
----
commit af396e13be872a14bc89856e33c2395ed53adeef
Author: Jon Zeolla <ze...@...>
Date: 2018-11-09T21:10:03Z
METRON-1865: Fix metron-bro-plugin-kafka tests
----
---
[GitHub] metron-bro-plugin-kafka pull request #16: METRON-1865: Fix metron-bro-plugin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron-bro-plugin-kafka/pull/16
---
[GitHub] metron-bro-plugin-kafka issue #16: METRON-1865: Fix metron-bro-plugin-kafka ...
Posted by nickwallen <gi...@git.apache.org>.
Github user nickwallen commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/16
+1 Thanks!
I was able to test like this...
```
bro-pkg install http://github.com/jonzeolla/metron-bro-plugin-kafka --version=METRON-1865
```
---