You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/28 04:08:10 UTC

[GitHub] [pulsar] RobertIndie commented on a diff in pull request #16256: [fix][client] Specify the init parameters value in the OpSendMsg

RobertIndie commented on code in PR #16256:
URL: https://github.com/apache/pulsar/pull/16256#discussion_r908009895


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java:
##########
@@ -1337,15 +1337,15 @@ protected static final class OpSendMsg {
         SendCallback callback;
         Runnable rePopulate;
         ChunkedMessageCtx chunkedMessageCtx;
-        long uncompressedSize;
-        long sequenceId;
-        long createdAt;
-        long firstSentAt;
-        long lastSentAt;
-        int retryCount;

Review Comment:
   Yes. These initial values are all relied upon by other codes. Such as here:
   https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java#L1409-L1422



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org