You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2017/09/22 16:13:00 UTC

[jira] [Comment Edited] (HBASE-18861) [C++] Use boost::optional instead of std::experimental::optional

    [ https://issues.apache.org/jira/browse/HBASE-18861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175675#comment-16175675 ] 

Josh Elser edited comment on HBASE-18861 at 9/22/17 4:12 PM:
-------------------------------------------------------------

\+1 -- Patch looks good and works on local platforms that don't have C++17 support to include Centos 7.3 and Mac Sierra. 


was (Author: phrocker):
+1 -- Patch looks good and works on local platforms that don't have C++17 support to include Centos 7.3 and Mac Sierra. 

> [C++] Use boost::optional instead of std::experimental::optional
> ----------------------------------------------------------------
>
>                 Key: HBASE-18861
>                 URL: https://issues.apache.org/jira/browse/HBASE-18861
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>         Attachments: hbase-18861_v1.patch
>
>
> Our Marc Parisi indicates that using std::experimental is not prefered in production code, and causes compilation problems especially for compilers which do not have C++17 support. 
> Our usage of {{std::experimental::optional}} is very small and can be easily replaced with {{boost::optional}}. We depend on boost anyways for other reasons. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)