You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/14 06:01:46 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #6106: ui: Fix CreateKubernetesCluster for ha
davidjumani opened a new pull request #6106:
URL: https://github.com/apache/cloudstack/pull/6106
### Description
Fixes the issue of always sending 2 control plan nodes in the CreateKubernetesCluster vue
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6106: ui: Fix CreateKubernetesCluster for ha
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6106:
URL: https://github.com/apache/cloudstack/pull/6106#issuecomment-1066414491
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6106 (SL-JID-1254)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6106: ui: Fix CreateKubernetesCluster for ha
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6106:
URL: https://github.com/apache/cloudstack/pull/6106#issuecomment-1067069846
Thanks @davidjumani @utchoang @shwstppr - if possible let's continue with this PR for this specific issue and address the rest of the common issues on a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6106: ui: Fix CreateKubernetesCluster for ha
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6106:
URL: https://github.com/apache/cloudstack/pull/6106#issuecomment-1066410605
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #6106: ui: Fix CreateKubernetesCluster for ha
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #6106:
URL: https://github.com/apache/cloudstack/pull/6106#issuecomment-1066410476
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6106: ui: Fix CreateKubernetesCluster for ha
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6106:
URL: https://github.com/apache/cloudstack/pull/6106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6106: ui: Fix CreateKubernetesCluster for ha
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #6106:
URL: https://github.com/apache/cloudstack/pull/6106#issuecomment-1066432823
@davidjumani @utchoang this could be a common issue with other forms as well (saw it in add network offering form as well). Earlier when v-if was used, check for form items on which v-if was added was not needed. Now even though the form-item is not shown, value must still be there in `values` during form submit. Anything we can do address all of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org