You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by pe...@apache.org on 2012/01/25 20:51:04 UTC
git commit: WICKET-4357 Calling WebResponse#enableCaching() is
insufficient to enable caching on WebPage (which by default is non-cacheable)
Updated Branches:
refs/heads/master 285beae65 -> 532199a1e
WICKET-4357 Calling WebResponse#enableCaching() is insufficient to enable caching on WebPage (which by default is non-cacheable)
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/532199a1
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/532199a1
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/532199a1
Branch: refs/heads/master
Commit: 532199a1eb82bd0af12ec7fce4ca50bb4ec06659
Parents: 285beae
Author: Peter Ertl <pe...@apache.org>
Authored: Wed Jan 25 20:50:37 2012 +0100
Committer: Peter Ertl <pe...@apache.org>
Committed: Wed Jan 25 20:50:37 2012 +0100
----------------------------------------------------------------------
.../apache/wicket/request/http/WebResponse.java | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/532199a1/wicket-request/src/main/java/org/apache/wicket/request/http/WebResponse.java
----------------------------------------------------------------------
diff --git a/wicket-request/src/main/java/org/apache/wicket/request/http/WebResponse.java b/wicket-request/src/main/java/org/apache/wicket/request/http/WebResponse.java
index c865a62..3b1cd9a 100644
--- a/wicket-request/src/main/java/org/apache/wicket/request/http/WebResponse.java
+++ b/wicket-request/src/main/java/org/apache/wicket/request/http/WebResponse.java
@@ -194,6 +194,9 @@ public abstract class WebResponse extends Response
/**
* Make this response cacheable
+ * <p/>
+ * when trying to enable caching for web pages check this out:
+ * <a href="https://issues.apache.org/jira/browse/WICKET-4357">WICKET-4357</a>
*
* @param duration
* maximum duration before the response must be invalidated by any caches. It should
@@ -201,7 +204,7 @@ public abstract class WebResponse extends Response
* href="http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html">RFC-2616</a>.
* @param scope
* controls which caches are allowed to cache the response
- *
+ *
* @see WebResponse#MAX_CACHE_DURATION
*/
public void enableCaching(Duration duration, final WebResponse.CacheScope scope)