[jira] [Updated] (INFRA-11367) pgp.lua may fail to process last entry

["Sebb (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/INFRA-11367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb updated INFRA-11367:
-------------------------
    Attachment: INFRA-11367.patch

> pgp.lua may fail to process last entry
> --------------------------------------
>
>                 Key: INFRA-11367
>                 URL: https://issues.apache.org/jira/browse/INFRA-11367
>             Project: Infrastructure
>          Issue Type: Bug
>          Components: Website
>         Environment: https://svn.apache.org/repos/infra/infrastructure/trunk/projects/home/tools/pgp.lua
> http://home.apache.org/keys/committer/
>            Reporter: Sebb
>         Attachments: INFRA-11367.patch
>
>
> The pgp.lua script currently parses the ldapsearch output by looking for enties that start with "uid=" and end with "\dn". However this assumes that there will always be a "dn" line after the last entry. This is not the case.
> This does not cause a problem at present, because there are many more people than there are pgp entries, so mostly the last entry will not have a key.
> There is another bug: the index file is repeatedly recreated, once per uid that is processed. Also even invalid key ids are stored in the index - have a look at henkp and jsirota.
> Patch to follow fixes these items, and also adds a comment to the start of each key to show the key id used to download the key.
> The key server offers machine-redable output which avoids the need to parse the response.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)