You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2025/08/26 20:32:02 UTC
[PR] fix: provide correct extra to on_asset_changed listener [airflow]
hussein-awala opened a new pull request, #54957:
URL: https://github.com/apache/airflow/pull/54957
Today, the `on_asset_changed` listener receives a copy of the asset loaded from the database. However, the extra metadata may be added or updated at runtime.
This PR updates the asset instance sent to the listener to ensure it includes the correct extra metadata.
## Summary of tests without the fix:
```
============================================================================= short test summary info =============================================================================
FAILED airflow-core/tests/unit/listeners/test_asset_listener.py::test_asset_listener_on_asset_changed_with_dynamic_extra - AssertionError: assert equals failed
{} {'key': 'value'}
FAILED airflow-core/tests/unit/listeners/test_asset_listener.py::test_asset_listener_on_asset_changed_with_template_extra - AssertionError: assert equals failed
{'task_id': '{{ ti.task_id }}'} {'task_id': 'test_task'}
===================================================================== 2 failed, 1 passed, 1 warning in 6.51s ======================================================================
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: provide correct extra to on_asset_changed listener [airflow]
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on PR #54957:
URL: https://github.com/apache/airflow/pull/54957#issuecomment-3240214768
@uranusjr could you please check https://github.com/apache/airflow/pull/55115?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: provide correct extra to on_asset_changed listener [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #54957: fix: provide correct extra to on_asset_changed listener
URL: https://github.com/apache/airflow/pull/54957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: provide correct extra to on_asset_changed listener [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #54957:
URL: https://github.com/apache/airflow/pull/54957#issuecomment-3429997822
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: provide correct extra to on_asset_changed listener [airflow]
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on PR #54957:
URL: https://github.com/apache/airflow/pull/54957#issuecomment-3228970935
> Asset event extra is not the same as asset extra. This is wrong.
My plan B: what about creating a new listener `on_asset_event_created`, actually it is better because we have information about the task instance which created the event
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org