You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2023/06/13 11:53:32 UTC

[GitHub] [incubator-kvrocks] git-hulk opened a new issue, #1495: [proposal] Reduce the block cache configurations into a single one

git-hulk opened a new issue, #1495:
URL: https://github.com/apache/incubator-kvrocks/issues/1495

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   For historical reasons, we have three configurations to control the block cache behavior:
   
   - [rocksdb.metadata_block_cache_size](https://github.com/apache/incubator-kvrocks/blob/unstable/kvrocks.conf#LL530C1-L530C34) which will determine the block cache size of the metadata column family
   - [rocksdb.subkey_block_cache_size](https://github.com/apache/incubator-kvrocks/blob/unstable/kvrocks.conf#LL535C1-L535C32) which will determine the block cache size of other column families
   - [rocksdb.share_metadata_and_subkey_block_cache](https://github.com/apache/incubator-kvrocks/blob/unstable/kvrocks.conf#L542) which is used to determine whether to share the same block cache between column families.
   
   But most users don't understand why we need to configure two block cache sizes without investigating the implementation. And it also didn't make sense to separate them since the user data may change as time elapsed.
   
   ### Solution
   
   We can reduce them into a single one like `rocksdb.block_cache_size` and deprecate old configurations, and also remove them from the kvrocks.conf.
   
   1. If the `rocksdb.block_cache_size` was set, then use it as the block cache and ignore old configurations.
   
   2. If the `rocksdb.block_cache_size` was NOT and `rocksdb.share_metadata_and_subkey_block_cache` was enabled, then calculate the `rocksdb.block_cache_size` from `rocksdb.metadata_block_cache_size` and `rocksdb.share_metadata_and_subkey_block_cache`
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1495: [proposal] Reduce the block cache configurations into a single one

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1495:
URL: https://github.com/apache/incubator-kvrocks/issues/1495#issuecomment-1596015342

   Sure, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kvrocks] PragmaTwice closed issue #1495: [proposal] Reduce the block cache configurations into a single one

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice closed issue #1495: [proposal] Reduce the block cache configurations into a single one
URL: https://github.com/apache/kvrocks/issues/1495


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] caipengbo commented on issue #1495: [proposal] Reduce the block cache configurations into a single one

Posted by "caipengbo (via GitHub)" <gi...@apache.org>.
caipengbo commented on issue #1495:
URL: https://github.com/apache/incubator-kvrocks/issues/1495#issuecomment-1589159672

   I think this is a good proposal. It's more user friendly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1495: [proposal] Reduce the block cache configurations into a single one

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1495:
URL: https://github.com/apache/incubator-kvrocks/issues/1495#issuecomment-1589152928

   @ShooterIT @PragmaTwice @torwig @caipengbo How do you think about this proposal?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] Yangsx-1 commented on issue #1495: [proposal] Reduce the block cache configurations into a single one

Posted by "Yangsx-1 (via GitHub)" <gi...@apache.org>.
Yangsx-1 commented on issue #1495:
URL: https://github.com/apache/incubator-kvrocks/issues/1495#issuecomment-1595986313

   Can you assign this task to me? @git-hulk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org