[GitHub] [hadoop-ozone] mbsharp commented on a change in pull request #143: HDDS-2418 Add the list trash command to the server side handling

[GitBox <gi...@apache.org>]

mbsharp commented on a change in pull request #143: HDDS-2418 Add the list trash command to the server side handling
URL: https://github.com/apache/hadoop-ozone/pull/143#discussion_r346454833
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
 ##########
 @@ -827,6 +827,18 @@ private boolean isKeyEmpty(OmKeyInfo keyInfo) {
         startKey, keyPrefix, maxKeys);
   }
 
+  @Override
+  public List<RepeatedOmKeyInfo> listTrash(String volumeName,
+      String bucketName, String startKeyName, String keyPrefix,
+      int maxKeys) throws IOException {
+
+    Preconditions.checkNotNull(volumeName);
+    Preconditions.checkNotNull(bucketName);
+
 
 Review comment:
   A preconditions check was added for the maxKeys to make sure that is below a cluster level max (new config).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org