You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/03/10 10:17:15 UTC
[GitHub] [incubator-iotdb] Alima777 opened a new pull request #898:
[IOTDB-552] Restrictions of predicates in ALIGN_BY_DEVICE statements are
not well stated
Alima777 opened a new pull request #898: [IOTDB-552] Restrictions of predicates in ALIGN_BY_DEVICE statements are not well stated
URL: https://github.com/apache/incubator-iotdb/pull/898
Although value predicates are newly allowed in ALIGN_BY_DEVICE statements, their statements are not well stated in the documents, like that wildcard cannot be used in it.
So the documents should be updated with those restrictions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin merged pull request #898: [IOTDB-552]
Restrictions of predicates in ALIGN_BY_DEVICE statements are not well stated
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #898: [IOTDB-552] Restrictions of predicates in ALIGN_BY_DEVICE statements are not well stated
URL: https://github.com/apache/incubator-iotdb/pull/898
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request
#898: [IOTDB-552] Restrictions of predicates in ALIGN_BY_DEVICE statements
are not well stated
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #898: [IOTDB-552] Restrictions of predicates in ALIGN_BY_DEVICE statements are not well stated
URL: https://github.com/apache/incubator-iotdb/pull/898#discussion_r390729143
##########
File path: docs/Documentation/UserGuide/5-Operation Manual/4-SQL Reference.md
##########
@@ -406,12 +406,19 @@ For example. "select s0,s1 from root.sg.*,root.sg.d0 align by device" is equal t
7. The duplicated measurements in the suffix paths are not neglected.
For example, "select s0,s0,s1 from root.sg.* align by device" is not equal to "select s0,s1 from root.sg.* align by device".
-8. More correct examples:
+8. Both time predicates and value predicates are allowed in Where Clause. The paths of the value predicates can be single level or full path started with ROOT. And wildcard is not allowed here. For example:
Review comment:
```suggestion
8. Both time predicates and value predicates are allowed in Where Clause. The paths of the value predicates can be the leaf node or full path started with ROOT. And wildcard is not allowed here. For example:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request
#898: [IOTDB-552] Restrictions of predicates in ALIGN_BY_DEVICE statements
are not well stated
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #898: [IOTDB-552] Restrictions of predicates in ALIGN_BY_DEVICE statements are not well stated
URL: https://github.com/apache/incubator-iotdb/pull/898#discussion_r390729057
##########
File path: docs/Documentation-CHN/UserGuide/5-Operation Manual/4-SQL Reference.md
##########
@@ -396,12 +396,19 @@ root.sg1.d0.s0 is INT32 while root.sg2.d3.s0 is FLOAT.
7. 在Select子句中重复写列名是生效的。例如, "select s0,s0,s1 from root.sg.* align by device" 不等于 "select s0,s1 from root.sg.* align by device".
-8. 更多正例:
+8. 在Where子句中时间过滤条件和值过滤条件均可以使用，值过滤条件可以使用单层 path，或以 root 开头的整个 path，不允许存在通配符。例如，
Review comment:
```suggestion
8. 在Where子句中时间过滤条件和值过滤条件均可以使用，值过滤条件可以使用叶子节点 path，或以 root 开头的整个 path，不允许存在通配符。例如，
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services