You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/18 03:17:48 UTC
[GitHub] [flink] fredia opened a new pull request, #19502: [FLINK-27260][Runtime/REST] Expose changelog configurations in Rest API and Web UI
fredia opened a new pull request, #19502:
URL: https://github.com/apache/flink/pull/19502
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This PR wants to add two fields:
- changelog_storage
- changelog_periodic_materialization_interval
into the checkpoints-config response, and show these fields on web UI when changelog is enabled.
## Brief change log
- *Add `changelog_storage` and `changelog_periodic_materialization_interval` to rest api*
- *Add `changelog_storage` and `changelog_periodic_materialization_interval` to web ui*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change is already covered by existing tests, such as *(please describe tests)*.
- `RestAPIStabilityTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: ( no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on a diff in pull request #19502: [FLINK-27260][Runtime/REST] Expose changelog configurations in Rest API and Web UI
Posted by GitBox <gi...@apache.org>.
fredia commented on code in PR #19502:
URL: https://github.com/apache/flink/pull/19502#discussion_r869248802
##########
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html:
##########
@@ -550,6 +550,24 @@
{{ checkPointConfig['checkpoints_after_tasks_finish'] ? 'Enabled' : 'Disabled' }}
</td>
</tr>
+ <tr
+ *ngIf="
Review Comment:
Thanks for reviewing, and I add one `Changelog` line. Here are pictures:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on pull request #19502: [FLINK-27260][Runtime/REST] Expose changelog configurations in Rest API and Web UI
Posted by GitBox <gi...@apache.org>.
fredia commented on PR #19502:
URL: https://github.com/apache/flink/pull/19502#issuecomment-1121904893
Sure. I run `SocketWindowWordCount` to get WEB UI. Here are pictures:
- when changelog enable, display `changelog_storage` and `changelog_periodic_materialization_interval` in checkpoint configuration tab:
- when changelog disable, don't show `changelog_storage` and `changelog_periodic_materialization_interval`:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a diff in pull request #19502: [FLINK-27260][Runtime/REST] Expose changelog configurations in Rest API and Web UI
Posted by GitBox <gi...@apache.org>.
Myasuka commented on code in PR #19502:
URL: https://github.com/apache/flink/pull/19502#discussion_r869059525
##########
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html:
##########
@@ -550,6 +550,24 @@
{{ checkPointConfig['checkpoints_after_tasks_finish'] ? 'Enabled' : 'Disabled' }}
</td>
</tr>
+ <tr
+ *ngIf="
Review Comment:
I think we can add a more line to tell whether changelog state-backend is enabled. If enabled, we print `true` with two more lines. Otherwise, we just print `false` without another two lines.
##########
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html:
##########
@@ -550,6 +550,24 @@
{{ checkPointConfig['checkpoints_after_tasks_finish'] ? 'Enabled' : 'Disabled' }}
</td>
</tr>
+ <tr
+ *ngIf="
+ checkPointConfig['state_backend'] === 'ChangelogStateBackend' &&
+ checkPointConfig['interval'] !== '0x7fffffffffffffff'
Review Comment:
Actually, even we do not set the checkpoint interval, the changelog state-backend is still enabled. Thus, I think we don't need to check the checkpoint interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka merged pull request #19502: [FLINK-27260][Runtime/REST] Expose changelog configurations in Rest API and Web UI
Posted by GitBox <gi...@apache.org>.
Myasuka merged PR #19502:
URL: https://github.com/apache/flink/pull/19502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on a diff in pull request #19502: [FLINK-27260][Runtime/REST] Expose changelog configurations in Rest API and Web UI
Posted by GitBox <gi...@apache.org>.
fredia commented on code in PR #19502:
URL: https://github.com/apache/flink/pull/19502#discussion_r869854865
##########
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html:
##########
@@ -550,6 +550,19 @@
{{ checkPointConfig['checkpoints_after_tasks_finish'] ? 'Enabled' : 'Disabled' }}
</td>
</tr>
+ <tr>
+ <td>Changelog</td>
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19502: [FLINK-27260][Runtime/REST] Expose changelog configurations in Rest API and Web UI
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19502:
URL: https://github.com/apache/flink/pull/19502#issuecomment-1101055961
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90e93c790260205288d07295f6ab3a76e02dac71",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "90e93c790260205288d07295f6ab3a76e02dac71",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90e93c790260205288d07295f6ab3a76e02dac71 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #19502: [FLINK-27260][Runtime/REST] Expose changelog configurations in Rest API and Web UI
Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #19502:
URL: https://github.com/apache/flink/pull/19502#issuecomment-1121834299
@fredia would you please share the picture that how the UI looks like with this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a diff in pull request #19502: [FLINK-27260][Runtime/REST] Expose changelog configurations in Rest API and Web UI
Posted by GitBox <gi...@apache.org>.
Myasuka commented on code in PR #19502:
URL: https://github.com/apache/flink/pull/19502#discussion_r869823074
##########
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html:
##########
@@ -550,6 +550,19 @@
{{ checkPointConfig['checkpoints_after_tasks_finish'] ? 'Enabled' : 'Disabled' }}
</td>
</tr>
+ <tr>
+ <td>Changelog</td>
Review Comment:
I think the description of `Changelog state-backend` looks better.
##########
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html:
##########
@@ -550,6 +550,19 @@
{{ checkPointConfig['checkpoints_after_tasks_finish'] ? 'Enabled' : 'Disabled' }}
</td>
</tr>
+ <tr>
+ <td>Changelog</td>
+ <td *ngIf="checkPointConfig['state_backend'] === 'ChangelogStateBackend'">Enabled</td>
+ <td *ngIf="checkPointConfig['state_backend'] !== 'ChangelogStateBackend'">Disabled</td>
+ </tr>
+ <tr *ngIf="checkPointConfig['state_backend'] === 'ChangelogStateBackend'">
+ <td>Changelog Storage</td>
+ <td>{{ checkPointConfig['changelog_storage'] }}</td>
+ </tr>
+ <tr *ngIf="checkPointConfig['state_backend'] === 'ChangelogStateBackend'">
+ <td>Changelog Periodic Materialization Interval</td>
+ <td>{{ checkPointConfig['changelog_periodic_materialization_interval'] }}</td>
Review Comment:
I noticed that the curent UI does not show the time unit of interval.
I think you can change this to `{{ checkPointConfig['changelog_periodic_materialization_interval'] | humanizeDuration}}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #19502: [FLINK-27260][Runtime/REST] Expose changelog configurations in Rest API and Web UI
Posted by GitBox <gi...@apache.org>.
Myasuka commented on PR #19502:
URL: https://github.com/apache/flink/pull/19502#issuecomment-1123772301
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org