You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/12 09:55:55 UTC

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #210: [FLINK-28511] Improve Spark dependencies and document

JingsongLi opened a new pull request, #210:
URL: https://github.com/apache/flink-table-store/pull/210

   - Include Hive metastore dependency in Spark bundled jar.
   - Improve document of Spark.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #210: [FLINK-28511] Improve Spark dependencies and document

Posted by GitBox <gi...@apache.org>.
LadyForest commented on code in PR #210:
URL: https://github.com/apache/flink-table-store/pull/210#discussion_r919642060


##########
docs/content/docs/engines/spark.md:
##########
@@ -41,17 +41,33 @@ Download [flink-table-store-spark-{{< version >}}.jar](https://repo.maven.apache
 You are using an unreleased version of Table Store, you need to manually [Build Spark Bundled Jar]({{< ref "docs/engines/build" >}}) from the source code.
 {{< /unstable >}}
 
-Copy Table Store Spark bundle jar to `spark/jars`.
+Use `--jars` in spark-sql:
+```bash
+spark-sql ... --jars flink-table-store-spark-{{< version >}}.jar
+```
 
-## Table Store Catalog
+You can also copy `flink-table-store-spark-{{< version >}}.jar` to `spark/jars` in your Spark installation.

Review Comment:
   ```suggestion
   Alternatively, you can copy `flink-table-store-spark-{{< version >}}.jar` under `spark/jars` in your Spark installation.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #210: [FLINK-28511] Improve Spark dependencies and document

Posted by GitBox <gi...@apache.org>.
LadyForest commented on code in PR #210:
URL: https://github.com/apache/flink-table-store/pull/210#discussion_r919649696


##########
docs/content/docs/engines/spark.md:
##########
@@ -41,17 +41,33 @@ Download [flink-table-store-spark-{{< version >}}.jar](https://repo.maven.apache
 You are using an unreleased version of Table Store, you need to manually [Build Spark Bundled Jar]({{< ref "docs/engines/build" >}}) from the source code.
 {{< /unstable >}}
 
-Copy Table Store Spark bundle jar to `spark/jars`.
+Use `--jars` in spark-sql:
+```bash
+spark-sql ... --jars flink-table-store-spark-{{< version >}}.jar
+```
 
-## Table Store Catalog
+You can also copy `flink-table-store-spark-{{< version >}}.jar` to `spark/jars` in your Spark installation.
+
+## Catalog
 
 The following command registers the Table Store's Spark catalog with the name `table_store`:
 
 ```bash
-spark-sql --conf spark.sql.catalog.table_store=org.apache.flink.table.store.spark.SparkCatalog \
+spark-sql ... \
+    --conf spark.sql.catalog.table_store=org.apache.flink.table.store.spark.SparkCatalog \
     --conf spark.sql.catalog.table_store.warehouse=file:/tmp/warehouse
 ```
 
+If you are using the Hive Metastore, you will need to add some configuration:

Review Comment:
   ```suggestion
   Some extra configurations are needed if your Spark application uses the Hive Metastore to manage metadata.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-table-store] JingsongLi merged pull request #210: [FLINK-28511] Improve Spark dependencies and document

Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #210:
URL: https://github.com/apache/flink-table-store/pull/210


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org