You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/18 01:55:25 UTC
[GitHub] [incubator-superset] zuzana-vej opened a new issue #12108: Cosmetic: Expanding three dots on filter box is rendered behind, not all options visible
zuzana-vej opened a new issue #12108:
URL: https://github.com/apache/incubator-superset/issues/12108
Cosmetic issue (regression) - when you click the three dots on a smaller filter box, the popup with list of options renders in the background (inside the filter box component) instead of over (previous behavior) meaning it's hard for user to select their action. This is especially visible on the filter box, (could be in small charts too in theory).
### Expected results
Render over so that all options are visible
### Actual results
renders behind (lilmited to filter box size)
#### Screenshots
#### How to reproduce the bug
1. Create a small (in terms of height) filter box
2. Click on the three dots
3. See issue
### Environment
(please complete the following information):
- superset version: `master`
- python version: `python --version`
- node.js version: `node -v`
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Regression
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #12108: Cosmetic: Expanding three dots on filter box is rendered behind, not all options visible
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #12108:
URL: https://github.com/apache/incubator-superset/issues/12108#issuecomment-747817303
This one is certainly low priority, probably introduced together with https://github.com/apache/incubator-superset/issues/12107 and https://github.com/apache/incubator-superset/issues/12105
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on issue #12108: [cosmetic][dashboard] Expanding three dots on filter box is rendered behind, not all options visible
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #12108:
URL: https://github.com/apache/incubator-superset/issues/12108#issuecomment-747969230
Most likely it's caused by `visibilty: hidden` in 1 of Antd's components. Overriding it to `visible` should do the trick. I can take a look once I'm done with tasks related to explore redesign
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on issue #12108: [cosmetic][dashboard] Expanding three dots on filter box is rendered behind, not all options visible
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #12108:
URL: https://github.com/apache/incubator-superset/issues/12108#issuecomment-747967319
I think I see what's happening here... in `SliceHeaderControls.jsx` you can see that AntD's `getPopupContainer` is used to render the Dropdown within the chart, where it used to be rendered in the `body` (the default behavior). This happened to show/hide the menu when taking a screenshot, which was fixed in https://github.com/apache/incubator-superset/pulls/11778
CCing for context: @kgabryje @nikolagigic @geido @maloun96
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] maloun96 commented on issue #12108: [cosmetic][dashboard] Expanding three dots on filter box is rendered behind, not all options visible
Posted by GitBox <gi...@apache.org>.
maloun96 commented on issue #12108:
URL: https://github.com/apache/incubator-superset/issues/12108#issuecomment-751725993
https://github.com/apache/incubator-superset/issues/12108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas edited a comment on issue #12108: [cosmetic][dashboard] Expanding three dots on filter box is rendered behind, not all options visible
Posted by GitBox <gi...@apache.org>.
rusackas edited a comment on issue #12108:
URL: https://github.com/apache/incubator-superset/issues/12108#issuecomment-747967319
I think I see what's happening here... in `SliceHeaderControls.jsx` you can see that AntD's `getPopupContainer` is used to render the Dropdown within the chart, where it used to be rendered in the `body` (the default behavior). This was done to for taking a screenshot of the viz (with the "download as image" menu item) which would hide the menu, take the screenshot, and show the menu again. This took place in https://github.com/apache/incubator-superset/pulls/11778
CCing for context: @kgabryje @nikolagigic @geido @maloun96
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org