You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/08/21 18:05:36 UTC
Review Request 61788: ATLAS-2074: AtlasType.resolveReferences()
method made package-private
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61788/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-2074
https://issues.apache.org/jira/browse/ATLAS-2074
Repository: atlas
Description
-------
Currently AtlasType.resolveReferences() method is marked as public. Implementations in sub-types likely to update the state of the type object; hence this method is only called during initialization/updates to type-registry. To prevent potential misuse of this method, which can result in errors, resolveReference() method is made package-private.
Diffs
-----
intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java de3394f1
intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 56c3ed38
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 9dad95df
intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java 1cd27b39
intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 90c898a3
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 934dffce
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2
intg/src/main/java/org/apache/atlas/type/AtlasType.java c99eb7f1
Diff: https://reviews.apache.org/r/61788/diff/1/
Testing
-------
Verified that Atlas builds successfully after this change in method accessor.
Thanks,
Madhan Neethiraj
Re: Review Request 61788: ATLAS-2074: AtlasType.resolveReferences()
method made package-private
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61788/#review183364
-----------------------------------------------------------
Ship it!
Ship It!
- David Radley
On Aug. 21, 2017, 6:05 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61788/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 6:05 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-2074
> https://issues.apache.org/jira/browse/ATLAS-2074
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently AtlasType.resolveReferences() method is marked as public. Implementations in sub-types likely to update the state of the type object; hence this method is only called during initialization/updates to type-registry. To prevent potential misuse of this method, which can result in errors, resolveReference() method is made package-private.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java de3394f1
> intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 56c3ed38
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 9dad95df
> intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java 1cd27b39
> intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 90c898a3
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 934dffce
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2
> intg/src/main/java/org/apache/atlas/type/AtlasType.java c99eb7f1
>
>
> Diff: https://reviews.apache.org/r/61788/diff/1/
>
>
> Testing
> -------
>
> Verified that Atlas builds successfully after this change in method accessor.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 61788: ATLAS-2074: AtlasType.resolveReferences()
method made package-private
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61788/#review183357
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On Aug. 21, 2017, 6:05 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61788/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 6:05 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-2074
> https://issues.apache.org/jira/browse/ATLAS-2074
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently AtlasType.resolveReferences() method is marked as public. Implementations in sub-types likely to update the state of the type object; hence this method is only called during initialization/updates to type-registry. To prevent potential misuse of this method, which can result in errors, resolveReference() method is made package-private.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java de3394f1
> intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 56c3ed38
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 9dad95df
> intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java 1cd27b39
> intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 90c898a3
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 934dffce
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2
> intg/src/main/java/org/apache/atlas/type/AtlasType.java c99eb7f1
>
>
> Diff: https://reviews.apache.org/r/61788/diff/1/
>
>
> Testing
> -------
>
> Verified that Atlas builds successfully after this change in method accessor.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 61788: ATLAS-2074: AtlasType.resolveReferences()
method made package-private
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61788/#review183363
-----------------------------------------------------------
Ship it!
Ship It!
- David Radley
On Aug. 21, 2017, 6:05 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61788/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 6:05 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-2074
> https://issues.apache.org/jira/browse/ATLAS-2074
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently AtlasType.resolveReferences() method is marked as public. Implementations in sub-types likely to update the state of the type object; hence this method is only called during initialization/updates to type-registry. To prevent potential misuse of this method, which can result in errors, resolveReference() method is made package-private.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java de3394f1
> intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 56c3ed38
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 9dad95df
> intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java 1cd27b39
> intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 90c898a3
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 934dffce
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2
> intg/src/main/java/org/apache/atlas/type/AtlasType.java c99eb7f1
>
>
> Diff: https://reviews.apache.org/r/61788/diff/1/
>
>
> Testing
> -------
>
> Verified that Atlas builds successfully after this change in method accessor.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 61788: ATLAS-2074: AtlasType.resolveReferences()
method made package-private
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61788/#review183366
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Aug. 21, 2017, 11:05 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61788/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 11:05 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-2074
> https://issues.apache.org/jira/browse/ATLAS-2074
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently AtlasType.resolveReferences() method is marked as public. Implementations in sub-types likely to update the state of the type object; hence this method is only called during initialization/updates to type-registry. To prevent potential misuse of this method, which can result in errors, resolveReference() method is made package-private.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java de3394f1
> intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 56c3ed38
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 9dad95df
> intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java 1cd27b39
> intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 90c898a3
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 934dffce
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2
> intg/src/main/java/org/apache/atlas/type/AtlasType.java c99eb7f1
>
>
> Diff: https://reviews.apache.org/r/61788/diff/1/
>
>
> Testing
> -------
>
> Verified that Atlas builds successfully after this change in method accessor.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 61788: ATLAS-2074: AtlasType.resolveReferences()
method made package-private
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61788/#review183362
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasType.java
Line 54 (original), 54 (patched)
<https://reviews.apache.org/r/61788/#comment259392>
I suggest adding some comments to these methods along the lines of the wording in the Jira.
- David Radley
On Aug. 21, 2017, 6:05 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61788/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 6:05 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-2074
> https://issues.apache.org/jira/browse/ATLAS-2074
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently AtlasType.resolveReferences() method is marked as public. Implementations in sub-types likely to update the state of the type object; hence this method is only called during initialization/updates to type-registry. To prevent potential misuse of this method, which can result in errors, resolveReference() method is made package-private.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java de3394f1
> intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 56c3ed38
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 9dad95df
> intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java 1cd27b39
> intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 90c898a3
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 934dffce
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2
> intg/src/main/java/org/apache/atlas/type/AtlasType.java c99eb7f1
>
>
> Diff: https://reviews.apache.org/r/61788/diff/1/
>
>
> Testing
> -------
>
> Verified that Atlas builds successfully after this change in method accessor.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>