[jira] [Commented] (OFBIZ-8153) LabelManager doesn't search .groovy files

["Suraj Khurana (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130131#comment-16130131 ] 

Suraj Khurana commented on OFBIZ-8153:
--------------------------------------

I am still unable to find reference of all uiLabels used in groovy files hence re-opening the issue.

Tried for *uiLabelMap.AccountingTotalAssets* in BalanceSheet.groovy in the accounting component, didn't get any luck.

IMO, the logic written needs more use cases to be covered for groovy files, existing findUiLabelMapInFile is not fit for groovy files.
Following patterns are currently used in groovy files:

1. uiLabelMap.xxxxx
2. uiLabelMap.get("xxxxx")
3. Should not be like uiLabelMap.xxxxx(              (As it might be calling a method of ResourceBundleMapWrapper class)


> LabelManager doesn't search .groovy files
> -----------------------------------------
>
>                 Key: OFBIZ-8153
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-8153
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework/webtools
>    Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>            Reporter: Pierre Smits
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 13.07, Release Branch 14.12, 16.11.01, Release Branch 15.12
>
>
> There are over 60 labels used in groovy files. These don't get reflected in the counts of the label manager and in the search for labels not used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)