You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2017/01/23 14:11:56 UTC
[GitHub] nifi pull request #1438: NIFI-3291: Continue addressing issues from jQuery u...
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1438
NIFI-3291: Continue addressing issues from jQuery upgrade
NIFI-3291:
- Fixing overflow calculation to determine if scrollbars are necessary.
- Fixing styles with jquery ui slider usage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-3291
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1438.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1438
----
commit c46ee76b0f9fd83694079235f0bcbd56c4fd1e2d
Author: Matt Gilman <ma...@gmail.com>
Date: 2017-01-23T14:10:49Z
NIFI-3291:
- Fixing overflow calculation to determine if scrollbars are necessary.
- Fixing styles with jquery ui slider usage.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1438: NIFI-3291: Continue addressing issues from jQuery u...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1438#discussion_r98240235
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/provenance/nf-provenance-table.js ---
@@ -617,7 +617,7 @@
// adjust the field width for a potential scrollbar
var searchFieldContainer = $('#searchable-fields-container');
- if (searchFieldContainer.get(0).scrollHeight > searchFieldContainer.innerHeight()) {
+ if (searchFieldContainer.get(0).scrollHeight > Math.round(searchFieldContainer.innerHeight())) {
--- End diff --
Yep, agreed. Will update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1438: NIFI-3291: Continue addressing issues from jQuery u...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1438
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1438: NIFI-3291: Continue addressing issues from jQuery u...
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1438#discussion_r98239800
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/provenance/nf-provenance-table.js ---
@@ -617,7 +617,7 @@
// adjust the field width for a potential scrollbar
var searchFieldContainer = $('#searchable-fields-container');
- if (searchFieldContainer.get(0).scrollHeight > searchFieldContainer.innerHeight()) {
+ if (searchFieldContainer.get(0).scrollHeight > Math.round(searchFieldContainer.innerHeight())) {
--- End diff --
@mcgilman I think this whole block of code is dead. The widths of the inputs for the "Search Events" dialog of the "Data Provenance" shell's $('#searchable-fields-container') are defined by CSS (in provenance.css line #141) and the widths being applied with this code are causing those inputs not to fill their available space.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1438: NIFI-3291: Continue addressing issues from jQuery upgrade
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/1438
Thanks @mcgilman this has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1438: NIFI-3291: Continue addressing issues from jQuery upgrade
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/1438
Reviewing....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---