[GitHub] [superset] kasiazjc commented on a change in pull request #18988: fix(column-header-tooltip): make that hide the tooltip when the cloum…

[GitBox <gi...@apache.org>]

kasiazjc commented on a change in pull request #18988:
URL: https://github.com/apache/superset/pull/18988#discussion_r832047184



##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -95,6 +100,7 @@ const StyledFilterableTable = styled.div`
 
 // when more than MAX_COLUMNS_FOR_TABLE are returned, switch from table to grid view
 export const MAX_COLUMNS_FOR_TABLE = 50;
+export const MAX_COLUMN_WIDTH = 200;

Review comment:
       Sorry for the late response, but re: columns setting max/min width can be tricky I think. To do it well we would have to go through different types of data there are in the columns and define min/max... If we would introduce max width for columns and let's say we would have 2 columns it could look weird as the table would not be stretched from left or right. 
   
   Easy solution would be to scale the column width, so depending on the width of the table all columns always have the same width 🤔 but still, lot's of edge case.
   
   That is, if I understand the problem correctly 🙃 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org