You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/06/02 01:03:43 UTC
[GitHub] [incubator-mxnet] mseth10 opened a new pull request #18465: [v1.x] Cherry-pick #17776 #17681
mseth10 opened a new pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465
## Description ##
Cherry-pick #17776 #17681 to update PyPI description
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-640509798
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-640937405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-641611495
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-638364850
Did you look at the docker build pipeline in more detail? From the last time I checked it, I believe the pipeline always publishes to a "latest" tag. Running the pipeline as is on both the master and 1.x branch would thus lead to a race condition and it'd be unclear if the 1.x or master version of the image is published.
Besides the technical issue, I'm currently not sure about the legal status of the pipeline. But that can be discussed in a separate issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-642444565
Ping @TaoLv , @pengzhao-intel to help merge :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-640937448
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mseth10 commented on a change in pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#discussion_r434748850
##########
File path: cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy
##########
@@ -24,7 +24,7 @@
// NOTE: the following variables are referenced in the mxnet_lib_pipeline jenkins file imported bellow
// libmxnet location
-libmxnet = 'lib/libmxnet.so'
Review comment:
I reverted this line. Rest of the code changes look good?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-641611468
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-637206707
Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [website, centos-gpu, miscellaneous, centos-cpu, windows-gpu, unix-gpu, clang, windows-cpu, sanity, unix-cpu, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-639257691
Hi @mseth10 @leezu , seems v1.7.x branch also need this PR to update the pypi desc, can you help to backport to v1.7.x as well. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#discussion_r434742570
##########
File path: cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy
##########
@@ -24,7 +24,7 @@
// NOTE: the following variables are referenced in the mxnet_lib_pipeline jenkins file imported bellow
// libmxnet location
-libmxnet = 'lib/libmxnet.so'
Review comment:
Thank you Manu. As with the 1.7 PR: Changing this line is done when switching to cmake build on CD. I don't think it's done yet (but we certainly want to do it at some point to decrease the infrastructure code divergence between 1.x and master branch)
So I suggest to remove this line in the PR and have a separate PR for the build change later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-640509873
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-638346295
@leezu please help review and merge this PR. This fixes #18462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-639990226
@ciyongch Created another PR for 1.7 branch #18464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-638370712
Clarification of the legal status of the pipeline as of early 2019 is at https://issues.apache.org/jira/browse/LEGAL-427 The major change since then is that the pipeline is managed as part of the https://github.com/apache/incubator-mxnet/ and executed by the Jenkins Server. This may put it under control of the PPMC. If that is true and if that affects it's status as third-party releases pends clarification of ASF Legal in https://issues.apache.org/jira/browse/LEGAL-515
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-639990262
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu removed a comment on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
leezu removed a comment on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-638370712
Clarification of the legal status of the pipeline as of early 2019 is at https://issues.apache.org/jira/browse/LEGAL-427 The major change since then is that the pipeline is managed as part of the https://github.com/apache/incubator-mxnet/ and executed by the Jenkins Server. This may put it under control of the PPMC. If that is true and if that affects it's status as third-party releases pends clarification of ASF Legal in https://issues.apache.org/jira/browse/LEGAL-515
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-641728815
@leezu please merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#discussion_r434742570
##########
File path: cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy
##########
@@ -24,7 +24,7 @@
// NOTE: the following variables are referenced in the mxnet_lib_pipeline jenkins file imported bellow
// libmxnet location
-libmxnet = 'lib/libmxnet.so'
Review comment:
As with the 1.7 PR: Changing this line is done when switching to cmake build on CD. I don't think it's done yet (but we certainly want to do it at some point to decrease the infrastructure code divergence between 1.x and master branch)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465#issuecomment-639990251
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu merged pull request #18465: [v1.x] Cherry-pick #17776 #17681
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #18465:
URL: https://github.com/apache/incubator-mxnet/pull/18465
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org