You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/12/12 23:42:35 UTC
Review Request 54682: Fixed the tests by turning off agent subsystems
in IOSwitchboard tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54682/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Repository: mesos
Description
-------
Agent subsystems should be not be used if the corresponding cgroups
isolator is not used. Ideally, we should add a check in Mesos to
disallow such a combination.
Diffs
-----
src/tests/containerizer/io_switchboard_tests.cpp a1ac75549697ba13cbb7c38fcab4a724aefbb402
Diff: https://reviews.apache.org/r/54682/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 54682: Fixed the tests by turning off agent
subsystems in IOSwitchboard tests.
Posted by Jie Yu <yu...@gmail.com>.
> On Dec. 13, 2016, 12:01 a.m., Kevin Klues wrote:
> > Should we add TODOs above all of these so we know to fix it once we add a proper dependency check?
Yup, will add a TODO in the agent code.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54682/#review158931
-----------------------------------------------------------
On Dec. 12, 2016, 11:42 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54682/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2016, 11:42 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Agent subsystems should be not be used if the corresponding cgroups
> isolator is not used. Ideally, we should add a check in Mesos to
> disallow such a combination.
>
>
> Diffs
> -----
>
> src/tests/containerizer/io_switchboard_tests.cpp a1ac75549697ba13cbb7c38fcab4a724aefbb402
>
> Diff: https://reviews.apache.org/r/54682/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 54682: Fixed the tests by turning off agent
subsystems in IOSwitchboard tests.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54682/#review158931
-----------------------------------------------------------
Ship it!
Should we add TODOs above all of these so we know to fix it once we add a proper dependency check?
- Kevin Klues
On Dec. 12, 2016, 11:42 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54682/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2016, 11:42 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Agent subsystems should be not be used if the corresponding cgroups
> isolator is not used. Ideally, we should add a check in Mesos to
> disallow such a combination.
>
>
> Diffs
> -----
>
> src/tests/containerizer/io_switchboard_tests.cpp a1ac75549697ba13cbb7c38fcab4a724aefbb402
>
> Diff: https://reviews.apache.org/r/54682/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 54682: Fixed the tests by turning off agent
subsystems in IOSwitchboard tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Dec. 13, 2016, 12:28 p.m., Benjamin Bannier wrote:
> > src/tests/containerizer/io_switchboard_tests.cpp, line 471
> > <https://reviews.apache.org/r/54682/diff/1/?file=1582319#file1582319line471>
> >
> > Note that this flag only exists on Linux, so this change suddenly causes this test to fail on e.g., OS X. `#ifdef`'ing these statements leads to passing tests.
> >
> > Here and below.
Sorry, meant to write _faile to build_.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54682/#review158986
-----------------------------------------------------------
On Dec. 13, 2016, 12:42 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54682/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 12:42 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Agent subsystems should be not be used if the corresponding cgroups
> isolator is not used. Ideally, we should add a check in Mesos to
> disallow such a combination.
>
>
> Diffs
> -----
>
> src/tests/containerizer/io_switchboard_tests.cpp a1ac75549697ba13cbb7c38fcab4a724aefbb402
>
> Diff: https://reviews.apache.org/r/54682/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 54682: Fixed the tests by turning off agent
subsystems in IOSwitchboard tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54682/#review158986
-----------------------------------------------------------
src/tests/containerizer/io_switchboard_tests.cpp (line 471)
<https://reviews.apache.org/r/54682/#comment229897>
Note that this flag only exists on Linux, so this change suddenly causes this test to fail on e.g., OS X. `#ifdef`'ing these statements leads to passing tests.
Here and below.
- Benjamin Bannier
On Dec. 13, 2016, 12:42 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54682/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 12:42 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Agent subsystems should be not be used if the corresponding cgroups
> isolator is not used. Ideally, we should add a check in Mesos to
> disallow such a combination.
>
>
> Diffs
> -----
>
> src/tests/containerizer/io_switchboard_tests.cpp a1ac75549697ba13cbb7c38fcab4a724aefbb402
>
> Diff: https://reviews.apache.org/r/54682/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>