You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/11/20 23:47:15 UTC
[GitHub] [incubator-gobblin] codecov-io commented on issue #2820:
[GOBBLIN-974] Avoid updating job/flow status if messages arrive out of order
codecov-io commented on issue #2820: [GOBBLIN-974] Avoid updating job/flow status if messages arrive out of order
URL: https://github.com/apache/incubator-gobblin/pull/2820#issuecomment-556552697
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2820?src=pr&el=h1) Report
> Merging [#2820](https://codecov.io/gh/apache/incubator-gobblin/pull/2820?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/e41fd943f096792598c213ec016f207a9a8f87fc?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `90%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2820?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2820 +/- ##
============================================
+ Coverage 45.63% 45.64% +0.01%
- Complexity 8966 8969 +3
============================================
Files 1900 1900
Lines 71222 71232 +10
Branches 7857 7860 +3
============================================
+ Hits 32499 32514 +15
+ Misses 35734 35726 -8
- Partials 2989 2992 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2820?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...blin/service/monitoring/KafkaJobStatusMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9LYWZrYUpvYlN0YXR1c01vbml0b3IuamF2YQ==) | `65.78% <90%> (+3.66%)` | `14 <0> (+2)` | :arrow_up: |
| [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.2% <0%> (-0.68%)` | `24% <0%> (-1%)` | |
| [...pache/gobblin/runtime/GobblinMultiTaskAttempt.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvR29iYmxpbk11bHRpVGFza0F0dGVtcHQuamF2YQ==) | `55.85% <0%> (-0.46%)` | `26% <0%> (-1%)` | |
| [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `72.22% <0%> (+2.22%)` | `13% <0%> (ø)` | :arrow_down: |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2820/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `39.25% <0%> (+6.54%)` | `13% <0%> (+2%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2820?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2820?src=pr&el=footer). Last update [e41fd94...476b180](https://codecov.io/gh/apache/incubator-gobblin/pull/2820?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services