You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/02/15 08:40:21 UTC
Review Request 69994: Added a test
`ROOT_EmptyCheckpointFileSlaveRecovery`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69994/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-9507
https://issues.apache.org/jira/browse/MESOS-9507
Repository: mesos
Description
-------
Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
Diffs
-----
src/tests/containerizer/docker_volume_isolator_tests.cpp 1503290bf62d5718df0a530a660b519649e76789
Diff: https://reviews.apache.org/r/69994/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 69994: Added a test
`ROOT_EmptyCheckpointFileSlaveRecovery`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69994/#review212866
-----------------------------------------------------------
PASS: Mesos patch 69994 was successfully built and tested.
Reviews applied: `['69972', '69994']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2892/mesos-review-69994
- Mesos Reviewbot Windows
On Feb. 15, 2019, 10:08 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69994/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2019, 10:08 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9507
> https://issues.apache.org/jira/browse/MESOS-9507
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_volume_isolator_tests.cpp 1503290bf62d5718df0a530a660b519649e76789
>
>
> Diff: https://reviews.apache.org/r/69994/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
> This test will fail without the patch https://reviews.apache.org/r/69972
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69994: Added a test
`ROOT_EmptyCheckpointFileSlaveRecovery`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69994/#review212983
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Feb. 19, 2019, 5:48 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69994/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2019, 5:48 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9507
> https://issues.apache.org/jira/browse/MESOS-9507
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_volume_isolator_tests.cpp 1503290bf62d5718df0a530a660b519649e76789
>
>
> Diff: https://reviews.apache.org/r/69994/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
> This test will fail without the patch https://reviews.apache.org/r/69972
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69994: Added a test
`ROOT_EmptyCheckpointFileSlaveRecovery`.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69994/#review212957
-----------------------------------------------------------
Ship it!
Ship It!
- Andrei Budnik
On Feb. 19, 2019, 1:48 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69994/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2019, 1:48 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9507
> https://issues.apache.org/jira/browse/MESOS-9507
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_volume_isolator_tests.cpp 1503290bf62d5718df0a530a660b519649e76789
>
>
> Diff: https://reviews.apache.org/r/69994/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
> This test will fail without the patch https://reviews.apache.org/r/69972
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69994: Added a test
`ROOT_EmptyCheckpointFileSlaveRecovery`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69994/
-----------------------------------------------------------
(Updated Feb. 19, 2019, 9:48 p.m.)
Review request for mesos, Andrei Budnik and Gilbert Song.
Changes
-------
Disabled checkpoint for the framework so that we can test orphan container.
Bugs: MESOS-9507
https://issues.apache.org/jira/browse/MESOS-9507
Repository: mesos
Description
-------
Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
Diffs (updated)
-----
src/tests/containerizer/docker_volume_isolator_tests.cpp 1503290bf62d5718df0a530a660b519649e76789
Diff: https://reviews.apache.org/r/69994/diff/3/
Changes: https://reviews.apache.org/r/69994/diff/2-3/
Testing
-------
sudo make check
This test will fail without the patch https://reviews.apache.org/r/69972
Thanks,
Qian Zhang
Re: Review Request 69994: Added a test
`ROOT_EmptyCheckpointFileSlaveRecovery`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69994/
-----------------------------------------------------------
(Updated Feb. 18, 2019, 4:20 p.m.)
Review request for mesos, Andrei Budnik and Gilbert Song.
Changes
-------
Addressed review comments.
Bugs: MESOS-9507
https://issues.apache.org/jira/browse/MESOS-9507
Repository: mesos
Description
-------
Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
Diffs (updated)
-----
src/tests/containerizer/docker_volume_isolator_tests.cpp 1503290bf62d5718df0a530a660b519649e76789
Diff: https://reviews.apache.org/r/69994/diff/2/
Changes: https://reviews.apache.org/r/69994/diff/1-2/
Testing
-------
sudo make check
This test will fail without the patch https://reviews.apache.org/r/69972
Thanks,
Qian Zhang
Re: Review Request 69994: Added a test
`ROOT_EmptyCheckpointFileSlaveRecovery`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69994/#review212879
-----------------------------------------------------------
Patch looks great!
Reviews applied: [69972, 69994]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 15, 2019, 9:08 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69994/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2019, 9:08 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9507
> https://issues.apache.org/jira/browse/MESOS-9507
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_volume_isolator_tests.cpp 1503290bf62d5718df0a530a660b519649e76789
>
>
> Diff: https://reviews.apache.org/r/69994/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
> This test will fail without the patch https://reviews.apache.org/r/69972
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69994: Added a test
`ROOT_EmptyCheckpointFileSlaveRecovery`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Feb. 15, 2019, 2:39 p.m., Andrei Budnik wrote:
> > src/tests/containerizer/docker_volume_isolator_tests.cpp
> > Lines 851 (patched)
> > <https://reviews.apache.org/r/69994/diff/1/?file=2125491#file2125491line851>
> >
> > Consider `Owned<MockDockerVolumeDriverClient> mockClient`?
>
> Qian Zhang wrote:
> What is the benefit of using `Owned`? I see we use raw pointer for `mockClient` in this whole file, if you think `Owned` is better, we could post a separate patch to update it in this file.
>
> Andrei Budnik wrote:
> In this, test we are leaking the object of type `MockDockerVolumeDriverClient` assigned to `mockClient` variable.
> `Owned` automatically deletes previous objects. You can use `delete mockClient` instead of `Owned` though.
Note that a manual `delete` would not be triggered if e.g., any `ASSERT` triggered. That's why using any smart pointer is strictly preferable to raw pointers in tests (this is analogue to why one needs RAII in the face of exceptions).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69994/#review212869
-----------------------------------------------------------
On Feb. 18, 2019, 9:20 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69994/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2019, 9:20 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9507
> https://issues.apache.org/jira/browse/MESOS-9507
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_volume_isolator_tests.cpp 1503290bf62d5718df0a530a660b519649e76789
>
>
> Diff: https://reviews.apache.org/r/69994/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
> This test will fail without the patch https://reviews.apache.org/r/69972
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69994: Added a test
`ROOT_EmptyCheckpointFileSlaveRecovery`.
Posted by Qian Zhang <zh...@gmail.com>.
> On Feb. 15, 2019, 9:39 p.m., Andrei Budnik wrote:
> > src/tests/containerizer/docker_volume_isolator_tests.cpp
> > Lines 745-748 (patched)
> > <https://reviews.apache.org/r/69994/diff/1/?file=2125491#file2125491line745>
> >
> > If we need "options", we could pass `{{"iops", "150"}}` directly to the first invokation of `createDockerVolume`?
It is not related to what we want to test, let me remove it to simply this unit test.
> On Feb. 15, 2019, 9:39 p.m., Andrei Budnik wrote:
> > src/tests/containerizer/docker_volume_isolator_tests.cpp
> > Lines 851 (patched)
> > <https://reviews.apache.org/r/69994/diff/1/?file=2125491#file2125491line851>
> >
> > Consider `Owned<MockDockerVolumeDriverClient> mockClient`?
What is the benefit of using `Owned`? I see we use raw pointer for `mockClient` in this whole file, if you think `Owned` is better, we could post a separate patch to update it in this file.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69994/#review212869
-----------------------------------------------------------
On Feb. 15, 2019, 5:08 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69994/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2019, 5:08 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9507
> https://issues.apache.org/jira/browse/MESOS-9507
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_volume_isolator_tests.cpp 1503290bf62d5718df0a530a660b519649e76789
>
>
> Diff: https://reviews.apache.org/r/69994/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
> This test will fail without the patch https://reviews.apache.org/r/69972
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69994: Added a test
`ROOT_EmptyCheckpointFileSlaveRecovery`.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On Feb. 15, 2019, 1:39 p.m., Andrei Budnik wrote:
> > src/tests/containerizer/docker_volume_isolator_tests.cpp
> > Lines 851 (patched)
> > <https://reviews.apache.org/r/69994/diff/1/?file=2125491#file2125491line851>
> >
> > Consider `Owned<MockDockerVolumeDriverClient> mockClient`?
>
> Qian Zhang wrote:
> What is the benefit of using `Owned`? I see we use raw pointer for `mockClient` in this whole file, if you think `Owned` is better, we could post a separate patch to update it in this file.
In this, test we are leaking the object of type `MockDockerVolumeDriverClient` assigned to `mockClient` variable.
`Owned` automatically deletes previous objects. You can use `delete mockClient` instead of `Owned` though.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69994/#review212869
-----------------------------------------------------------
On Feb. 18, 2019, 8:20 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69994/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2019, 8:20 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9507
> https://issues.apache.org/jira/browse/MESOS-9507
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_volume_isolator_tests.cpp 1503290bf62d5718df0a530a660b519649e76789
>
>
> Diff: https://reviews.apache.org/r/69994/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
> This test will fail without the patch https://reviews.apache.org/r/69972
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69994: Added a test
`ROOT_EmptyCheckpointFileSlaveRecovery`.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On Feb. 15, 2019, 1:39 p.m., Andrei Budnik wrote:
> > src/tests/containerizer/docker_volume_isolator_tests.cpp
> > Lines 851 (patched)
> > <https://reviews.apache.org/r/69994/diff/1/?file=2125491#file2125491line851>
> >
> > Consider `Owned<MockDockerVolumeDriverClient> mockClient`?
>
> Qian Zhang wrote:
> What is the benefit of using `Owned`? I see we use raw pointer for `mockClient` in this whole file, if you think `Owned` is better, we could post a separate patch to update it in this file.
>
> Andrei Budnik wrote:
> In this, test we are leaking the object of type `MockDockerVolumeDriverClient` assigned to `mockClient` variable.
> `Owned` automatically deletes previous objects. You can use `delete mockClient` instead of `Owned` though.
>
> Benjamin Bannier wrote:
> Note that a manual `delete` would not be triggered if e.g., any `ASSERT` triggered. That's why using any smart pointer is strictly preferable to raw pointers in tests (this is analogue to why one needs RAII in the face of exceptions).
>
> Qian Zhang wrote:
> I tried to change
> ```
> MockDockerVolumeDriverClient* mockClient = new MockDockerVolumeDriverClient;`
> ```
> to
> ```
> Owned<MockDockerVolumeDriverClient> mockClient(new MockDockerVolumeDriverClient());
> ```
>
> But the test failed with SIGSEGV at https://github.com/apache/mesos/blob/1.7.1/3rdparty/libprocess/include/process/owned.hpp#L204 , seems like a double free?
It turns out, that we move the ownership of `MockDockerVolumeDriverClient` object to `containerizer`. Once `containerizer` object is destroyed, `MockDockerVolumeDriverClient` is freed.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69994/#review212869
-----------------------------------------------------------
On Feb. 19, 2019, 1:48 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69994/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2019, 1:48 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9507
> https://issues.apache.org/jira/browse/MESOS-9507
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_volume_isolator_tests.cpp 1503290bf62d5718df0a530a660b519649e76789
>
>
> Diff: https://reviews.apache.org/r/69994/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
> This test will fail without the patch https://reviews.apache.org/r/69972
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69994: Added a test
`ROOT_EmptyCheckpointFileSlaveRecovery`.
Posted by Qian Zhang <zh...@gmail.com>.
> On Feb. 15, 2019, 9:39 p.m., Andrei Budnik wrote:
> > src/tests/containerizer/docker_volume_isolator_tests.cpp
> > Lines 851 (patched)
> > <https://reviews.apache.org/r/69994/diff/1/?file=2125491#file2125491line851>
> >
> > Consider `Owned<MockDockerVolumeDriverClient> mockClient`?
>
> Qian Zhang wrote:
> What is the benefit of using `Owned`? I see we use raw pointer for `mockClient` in this whole file, if you think `Owned` is better, we could post a separate patch to update it in this file.
>
> Andrei Budnik wrote:
> In this, test we are leaking the object of type `MockDockerVolumeDriverClient` assigned to `mockClient` variable.
> `Owned` automatically deletes previous objects. You can use `delete mockClient` instead of `Owned` though.
>
> Benjamin Bannier wrote:
> Note that a manual `delete` would not be triggered if e.g., any `ASSERT` triggered. That's why using any smart pointer is strictly preferable to raw pointers in tests (this is analogue to why one needs RAII in the face of exceptions).
I tried to change
```
MockDockerVolumeDriverClient* mockClient = new MockDockerVolumeDriverClient;`
```
to
```
Owned<MockDockerVolumeDriverClient> mockClient(new MockDockerVolumeDriverClient());
```
But the test failed with SIGSEGV at https://github.com/apache/mesos/blob/1.7.1/3rdparty/libprocess/include/process/owned.hpp#L204 , seems like a double free?
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69994/#review212869
-----------------------------------------------------------
On Feb. 19, 2019, 9:48 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69994/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2019, 9:48 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9507
> https://issues.apache.org/jira/browse/MESOS-9507
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_volume_isolator_tests.cpp 1503290bf62d5718df0a530a660b519649e76789
>
>
> Diff: https://reviews.apache.org/r/69994/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
> This test will fail without the patch https://reviews.apache.org/r/69972
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69994: Added a test
`ROOT_EmptyCheckpointFileSlaveRecovery`.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69994/#review212869
-----------------------------------------------------------
src/tests/containerizer/docker_volume_isolator_tests.cpp
Lines 691 (patched)
<https://reviews.apache.org/r/69994/#comment298759>
The comment from the previous patch that describes the root cause of empty files might be helpful to understand why we need this test. This comment can be copy-pasted here.
src/tests/containerizer/docker_volume_isolator_tests.cpp
Lines 745-748 (patched)
<https://reviews.apache.org/r/69994/#comment298758>
If we need "options", we could pass `{{"iops", "150"}}` directly to the first invokation of `createDockerVolume`?
src/tests/containerizer/docker_volume_isolator_tests.cpp
Lines 851 (patched)
<https://reviews.apache.org/r/69994/#comment298757>
Consider `Owned<MockDockerVolumeDriverClient> mockClient`?
- Andrei Budnik
On Feb. 15, 2019, 9:08 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69994/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2019, 9:08 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Gilbert Song.
>
>
> Bugs: MESOS-9507
> https://issues.apache.org/jira/browse/MESOS-9507
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_volume_isolator_tests.cpp 1503290bf62d5718df0a530a660b519649e76789
>
>
> Diff: https://reviews.apache.org/r/69994/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
> This test will fail without the patch https://reviews.apache.org/r/69972
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69994: Added a test
`ROOT_EmptyCheckpointFileSlaveRecovery`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69994/
-----------------------------------------------------------
(Updated Feb. 15, 2019, 5:08 p.m.)
Review request for mesos, Andrei Budnik and Gilbert Song.
Bugs: MESOS-9507
https://issues.apache.org/jira/browse/MESOS-9507
Repository: mesos
Description
-------
Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
Diffs
-----
src/tests/containerizer/docker_volume_isolator_tests.cpp 1503290bf62d5718df0a530a660b519649e76789
Diff: https://reviews.apache.org/r/69994/diff/1/
Testing (updated)
-------
sudo make check
This test will fail without the patch https://reviews.apache.org/r/69972
Thanks,
Qian Zhang