[GitHub] [spark] Kimahriman commented on a change in pull request #34166: [SPARK-36918] Ignore types when comparing structs for unionByName

[GitBox <gi...@apache.org>]

Kimahriman commented on a change in pull request #34166:
URL: https://github.com/apache/spark/pull/34166#discussion_r720981905



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala
##########
@@ -428,6 +428,33 @@ object DataType {
     }
   }
 
+  /**
+   * Returns true if the two data types share the same shape by name, i.e. the names
+   * are the same, but the types don't need to be the same.
+   */
+  def equalsStructurallyByName(

Review comment:
       Open to another name. I was original thinking `equalsStructurally`, but that already exists and does basically the exact opposite of what I was going for hah




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org