You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "BradWalker (via GitHub)" <gi...@apache.org> on 2025/05/05 21:22:19 UTC
[PR] update: update TextMark/Markdown tooling [netbeans]
BradWalker opened a new pull request, #8490:
URL: https://github.com/apache/netbeans/pull/8490
update: update TextMark/Markdown tooling
desc: The TextMark JSON description is very much out of date (i.e. years). This change brings in the latest version of the JSON description.
In addition, update the TextMark plugin to 0.14.1 version.
testing: built with no issues. Loaded a README.md file into the IDE and it previewed correctly.
---
**^Add meaningful description above**
<details open>
<summary>Click to collapse/expand PR instructions</summary>
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
### PR approval and merge checklist:
1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)), did the right tests run? When did they run?
2. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
3. [ ] Are author name / email address correct? Are [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates?
3. [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?
If this PR targets the delivery branch: [don't merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery). ([full wiki article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] update TextMark/Markdown tooling [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #8490:
URL: https://github.com/apache/netbeans/pull/8490#issuecomment-2888469868
@mbien my understanding is, that these warnings come from the textmate grammars, when the corresponding grammars are not present. Have a look at the `tmLanguage.json` files. In there you can find includes and these match the warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] update: update TextMark/Markdown tooling [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #8490:
URL: https://github.com/apache/netbeans/pull/8490#discussion_r2078326546
##########
ide/textmate.lexer/external/binaries-list:
##########
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
23D2F2EFF7FA0CDA465D86EC9D8BAB53E496D9E6 org.jruby.joni:joni:2.2.1
Review Comment:
Please consider bumping joni to 2.2.6. There were some bugfixes in there and to my understanding regexps are the heart of textmate grammars and thus performance and correctness for that area matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] update TextMark/Markdown tooling [netbeans]
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker commented on PR #8490:
URL: https://github.com/apache/netbeans/pull/8490#issuecomment-2888486228
> @mbien my understanding is, that these warnings come from the textmate grammars, when the corresponding grammars are not present. Have a look at the `tmLanguage.json` files. In there you can find includes and these match the warnings.
@mbien , @matthiasblaesing is correct in saying these msgs are coming from TextMate. I'm working with those folks to try and resolve them.
Nonetheless, we do need to have our TextMate grammar updated as it's really out of date. And that's what I'm trying to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] update TextMark/Markdown tooling [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #8490:
URL: https://github.com/apache/netbeans/pull/8490#issuecomment-2888522984
> Nonetheless, we do need to have our TextMate grammar updated as it's really out of date. And that's what I'm trying to do.
I don't see a problem here. I think this is fine to merge. The hint about Joni was meant as a hint, so if you say "Yeah, evaluated, good idea, but don't feel safe with bumping it", I'm fine with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] update TextMark/Markdown tooling [netbeans]
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker commented on code in PR #8490:
URL: https://github.com/apache/netbeans/pull/8490#discussion_r2094215610
##########
ide/textmate.lexer/external/binaries-list:
##########
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
23D2F2EFF7FA0CDA465D86EC9D8BAB53E496D9E6 org.jruby.joni:joni:2.2.1
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] update TextMark/Markdown tooling [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #8490:
URL: https://github.com/apache/netbeans/pull/8490#issuecomment-2889141648
I see some more warnings from tm4e, but at this point in time I think we need to live with them. So from my POV this is still good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] update TextMark/Markdown tooling [netbeans]
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker merged PR #8490:
URL: https://github.com/apache/netbeans/pull/8490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] update TextMark/Markdown tooling [netbeans]
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker commented on PR #8490:
URL: https://github.com/apache/netbeans/pull/8490#issuecomment-2889147715
> I see some more warnings from tm4e, but at this point in time I think we need to live with them. So from my POV this is still good to go.
That is correct.. There is a new TextMark/Markdown plugin in beta right now. Figured when it is finally released, maybe do another update then as it should reduce the number of messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] update TextMark/Markdown tooling [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8490:
URL: https://github.com/apache/netbeans/pull/8490#issuecomment-2888466680
was hoping this would fix the big block of warnings in the startup log (and also repeated during tests) but they are still there:
<details>
```
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.yaml]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [text.html.derivative]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.css]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [text.html.basic]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.ini]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.java]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.lua]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.makefile]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.perl]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.r]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.ruby]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.php]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.sql]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.asp.vb.net]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [text.xml]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [text.xml.xsl]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.batchfile]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.clojure]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.coffee]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.c]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.cpp]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.diff]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.dockerfile]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [text.git-commit]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [text.git-rebase]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.go]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.groovy]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [text.pug]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.js]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.js.regexp]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.json]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.json.comments]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.css.less]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.objc]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.swift]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.css.scss]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.perl.6]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.powershell]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.python]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.julia]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.regexp.python]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.rust]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.scala]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.shell]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.tsx]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.cs]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.fsharp]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.dart]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [text.html.handlebars]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [text.log]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.erlang]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.elixir]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [text.tex.latex]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [text.bibtex]
WARNING [org.eclipse.tm4e.core.registry.Registry]: No grammar source for scope [source.twig]
```
</details>
not completely sure when this started, but its in NB 25 and 26.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists