You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Laszlo Puskas <lp...@hortonworks.com> on 2017/01/24 15:12:45 UTC

Review Request 55883: Post user creation hook - input csv generated with READ permissions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55883/
-----------------------------------------------------------

Review request for Ambari, Attila Magyar, Robert Levas, Sandor Magyari, and Sebastian Toader.


Bugs: AMBARI-19694
    https://issues.apache.org/jira/browse/AMBARI-19694


Repository: ambari


Description
-------

Currently the post user creation hook mechanism generates the user input csv with read permissions only for the user that runs ambari.
This may cause issues on secure clusters, where ambari is not ran by the root user, az auth to local rules may map to users that don't have READ right for the generated csv.
Solution: input csv file is generated with REAd permissions for all users.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/serveraction/users/CsvFilePersisterService.java d8ffe98 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/users/CsvFilePersisterServiceFunctionalTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/55883/diff/


Testing
-------

Unit test created.
Manual testing under way.


Thanks,

Laszlo Puskas


Re: Review Request 55883: Post user creation hook - input csv generated with READ permissions

Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55883/#review162826
-----------------------------------------------------------


Ship it!




Ship It!

- Attila Magyar


On Jan. 24, 2017, 3:12 p.m., Laszlo Puskas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55883/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2017, 3:12 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Robert Levas, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19694
>     https://issues.apache.org/jira/browse/AMBARI-19694
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently the post user creation hook mechanism generates the user input csv with read permissions only for the user that runs ambari.
> This may cause issues on secure clusters, where ambari is not ran by the root user, az auth to local rules may map to users that don't have READ right for the generated csv.
> Solution: input csv file is generated with REAd permissions for all users.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/users/CsvFilePersisterService.java d8ffe98 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/users/CsvFilePersisterServiceFunctionalTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55883/diff/
> 
> 
> Testing
> -------
> 
> Unit test created.
> Manual testing under way.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>


Re: Review Request 55883: Post user creation hook - input csv generated with READ permissions

Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55883/#review162823
-----------------------------------------------------------


Ship it!




Ship It!

- Sebastian Toader


On Jan. 24, 2017, 4:12 p.m., Laszlo Puskas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55883/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2017, 4:12 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Robert Levas, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19694
>     https://issues.apache.org/jira/browse/AMBARI-19694
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently the post user creation hook mechanism generates the user input csv with read permissions only for the user that runs ambari.
> This may cause issues on secure clusters, where ambari is not ran by the root user, az auth to local rules may map to users that don't have READ right for the generated csv.
> Solution: input csv file is generated with REAd permissions for all users.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/users/CsvFilePersisterService.java d8ffe98 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/users/CsvFilePersisterServiceFunctionalTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55883/diff/
> 
> 
> Testing
> -------
> 
> Unit test created.
> Manual testing under way.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>


Re: Review Request 55883: Post user creation hook - input csv generated with READ permissions

Posted by Laszlo Puskas <lp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55883/
-----------------------------------------------------------

(Updated Jan. 25, 2017, 9:15 a.m.)


Review request for Ambari, Attila Magyar, Robert Levas, Sandor Magyari, and Sebastian Toader.


Changes
-------

Added test details


Bugs: AMBARI-19694
    https://issues.apache.org/jira/browse/AMBARI-19694


Repository: ambari


Description
-------

Currently the post user creation hook mechanism generates the user input csv with read permissions only for the user that runs ambari.
This may cause issues on secure clusters, where ambari is not ran by the root user, az auth to local rules may map to users that don't have READ right for the generated csv.
Solution: input csv file is generated with REAd permissions for all users.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/serveraction/users/CsvFilePersisterService.java d8ffe98 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/users/CsvFilePersisterServiceFunctionalTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/55883/diff/


Testing (updated)
-------

Manually on local environment:
- created a cluster (post user creation hook enabled)
- from the ambari UI created a new local user
- checked the permissions on the generated csv file - owner / group / all read permissions set on the file
- created a new system user (not root ...)
- opened the generated csv as the newlycreated user 

Unit test created.


Thanks,

Laszlo Puskas


Re: Review Request 55883: Post user creation hook - input csv generated with READ permissions

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55883/#review162817
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Levas


On Jan. 24, 2017, 10:12 a.m., Laszlo Puskas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55883/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2017, 10:12 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Robert Levas, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19694
>     https://issues.apache.org/jira/browse/AMBARI-19694
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently the post user creation hook mechanism generates the user input csv with read permissions only for the user that runs ambari.
> This may cause issues on secure clusters, where ambari is not ran by the root user, az auth to local rules may map to users that don't have READ right for the generated csv.
> Solution: input csv file is generated with REAd permissions for all users.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/users/CsvFilePersisterService.java d8ffe98 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/users/CsvFilePersisterServiceFunctionalTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55883/diff/
> 
> 
> Testing
> -------
> 
> Unit test created.
> Manual testing under way.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>