You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/06/05 20:03:07 UTC

[jira] Created: (ZOOKEEPER-434) the java shell should indicate connection status on command prompt

the java shell should indicate connection status on command prompt
------------------------------------------------------------------

                 Key: ZOOKEEPER-434
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-434
             Project: Zookeeper
          Issue Type: Improvement
          Components: java client
    Affects Versions: 3.2.0
            Reporter: Patrick Hunt
            Assignee: Henry Robinson
            Priority: Minor


it would be very useful if the java shell showed the current connection status as part of the command prompt.

this shows itself in particular for the following use case:

I attempted to connect a java shell to a remote cluster that was unavailable, when I run the first command "ls /" on
the cluster the shell hangs. It would be nice if the shell indicated connection status in the prompt and make it more
clear that the shell is currently not connected. (it was hard to see the "attempting to connect" console message as
it was lost in with the other messaes...)


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-434) the java shell should indicate connection status on command prompt

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717557#action_12717557 ] 

Hadoop QA commented on ZOOKEEPER-434:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12410059/ZOOKEEPER-434.patch
  against trunk revision 782792.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/109/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/109/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/109/console

This message is automatically generated.

> the java shell should indicate connection status on command prompt
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-434
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-434
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.1.1
>            Reporter: Patrick Hunt
>            Assignee: Henry Robinson
>            Priority: Minor
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-434.patch
>
>
> it would be very useful if the java shell showed the current connection status as part of the command prompt.
> this shows itself in particular for the following use case:
> I attempted to connect a java shell to a remote cluster that was unavailable, when I run the first command "ls /" on
> the cluster the shell hangs. It would be nice if the shell indicated connection status in the prompt and make it more
> clear that the shell is currently not connected. (it was hard to see the "attempting to connect" console message as
> it was lost in with the other messaes...)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-434) the java shell should indicate connection status on command prompt

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-434:
------------------------------------

    Status: Patch Available  (was: Open)

retrying hudson

> the java shell should indicate connection status on command prompt
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-434
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-434
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.1.1
>            Reporter: Patrick Hunt
>            Assignee: Henry Robinson
>            Priority: Minor
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-434.patch
>
>
> it would be very useful if the java shell showed the current connection status as part of the command prompt.
> this shows itself in particular for the following use case:
> I attempted to connect a java shell to a remote cluster that was unavailable, when I run the first command "ls /" on
> the cluster the shell hangs. It would be nice if the shell indicated connection status in the prompt and make it more
> clear that the shell is currently not connected. (it was hard to see the "attempting to connect" console message as
> it was lost in with the other messaes...)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-434) the java shell should indicate connection status on command prompt

Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Robinson updated ZOOKEEPER-434:
-------------------------------------

    Status: Patch Available  (was: Open)

> the java shell should indicate connection status on command prompt
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-434
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-434
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.2.0
>            Reporter: Patrick Hunt
>            Assignee: Henry Robinson
>            Priority: Minor
>         Attachments: ZOOKEEPER-434.patch
>
>
> it would be very useful if the java shell showed the current connection status as part of the command prompt.
> this shows itself in particular for the following use case:
> I attempted to connect a java shell to a remote cluster that was unavailable, when I run the first command "ls /" on
> the cluster the shell hangs. It would be nice if the shell indicated connection status in the prompt and make it more
> clear that the shell is currently not connected. (it was hard to see the "attempting to connect" console message as
> it was lost in with the other messaes...)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-434) the java shell should indicate connection status on command prompt

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-434:
------------------------------------

    Status: Open  (was: Patch Available)

> the java shell should indicate connection status on command prompt
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-434
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-434
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.1.1
>            Reporter: Patrick Hunt
>            Assignee: Henry Robinson
>            Priority: Minor
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-434.patch
>
>
> it would be very useful if the java shell showed the current connection status as part of the command prompt.
> this shows itself in particular for the following use case:
> I attempted to connect a java shell to a remote cluster that was unavailable, when I run the first command "ls /" on
> the cluster the shell hangs. It would be nice if the shell indicated connection status in the prompt and make it more
> clear that the shell is currently not connected. (it was hard to see the "attempting to connect" console message as
> it was lost in with the other messaes...)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-434) the java shell should indicate connection status on command prompt

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718515#action_12718515 ] 

Hudson commented on ZOOKEEPER-434:
----------------------------------

Integrated in ZooKeeper-trunk #343 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/343/])
    

> the java shell should indicate connection status on command prompt
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-434
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-434
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.1.1
>            Reporter: Patrick Hunt
>            Assignee: Henry Robinson
>            Priority: Minor
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-434.patch
>
>
> it would be very useful if the java shell showed the current connection status as part of the command prompt.
> this shows itself in particular for the following use case:
> I attempted to connect a java shell to a remote cluster that was unavailable, when I run the first command "ls /" on
> the cluster the shell hangs. It would be nice if the shell indicated connection status in the prompt and make it more
> clear that the shell is currently not connected. (it was hard to see the "attempting to connect" console message as
> it was lost in with the other messaes...)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-434) the java shell should indicate connection status on command prompt

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-434:
------------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Committed revision 782879.


> the java shell should indicate connection status on command prompt
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-434
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-434
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.1.1
>            Reporter: Patrick Hunt
>            Assignee: Henry Robinson
>            Priority: Minor
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-434.patch
>
>
> it would be very useful if the java shell showed the current connection status as part of the command prompt.
> this shows itself in particular for the following use case:
> I attempted to connect a java shell to a remote cluster that was unavailable, when I run the first command "ls /" on
> the cluster the shell hangs. It would be nice if the shell indicated connection status in the prompt and make it more
> clear that the shell is currently not connected. (it was hard to see the "attempting to connect" console message as
> it was lost in with the other messaes...)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-434) the java shell should indicate connection status on command prompt

Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Robinson updated ZOOKEEPER-434:
-------------------------------------

    Attachment: ZOOKEEPER-434.patch

Prompt now shows host:port(status)

Also added 'connect' and 'close' to allow for recycling connections without quitting and starting again. If a connection is closed, most operations will report 'Not connected'.

Also included tiny documentation update to get command line parameters right.

> the java shell should indicate connection status on command prompt
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-434
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-434
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.2.0
>            Reporter: Patrick Hunt
>            Assignee: Henry Robinson
>            Priority: Minor
>         Attachments: ZOOKEEPER-434.patch
>
>
> it would be very useful if the java shell showed the current connection status as part of the command prompt.
> this shows itself in particular for the following use case:
> I attempted to connect a java shell to a remote cluster that was unavailable, when I run the first command "ls /" on
> the cluster the shell hangs. It would be nice if the shell indicated connection status in the prompt and make it more
> clear that the shell is currently not connected. (it was hard to see the "attempting to connect" console message as
> it was lost in with the other messaes...)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (ZOOKEEPER-434) the java shell should indicate connection status on command prompt

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717559#action_12717559 ] 

Benjamin Reed edited comment on ZOOKEEPER-434 at 6/8/09 10:12 PM:
------------------------------------------------------------------

Committed revision 782880.

      was (Author: breed):
    Committed revision 782879.

  
> the java shell should indicate connection status on command prompt
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-434
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-434
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.1.1
>            Reporter: Patrick Hunt
>            Assignee: Henry Robinson
>            Priority: Minor
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-434.patch
>
>
> it would be very useful if the java shell showed the current connection status as part of the command prompt.
> this shows itself in particular for the following use case:
> I attempted to connect a java shell to a remote cluster that was unavailable, when I run the first command "ls /" on
> the cluster the shell hangs. It would be nice if the shell indicated connection status in the prompt and make it more
> clear that the shell is currently not connected. (it was hard to see the "attempting to connect" console message as
> it was lost in with the other messaes...)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-434) the java shell should indicate connection status on command prompt

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-434:
------------------------------------

    Affects Version/s:     (was: 3.2.0)
                       3.1.1
        Fix Version/s: 3.2.0
         Hadoop Flags: [Reviewed]

> the java shell should indicate connection status on command prompt
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-434
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-434
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.1.1
>            Reporter: Patrick Hunt
>            Assignee: Henry Robinson
>            Priority: Minor
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-434.patch
>
>
> it would be very useful if the java shell showed the current connection status as part of the command prompt.
> this shows itself in particular for the following use case:
> I attempted to connect a java shell to a remote cluster that was unavailable, when I run the first command "ls /" on
> the cluster the shell hangs. It would be nice if the shell indicated connection status in the prompt and make it more
> clear that the shell is currently not connected. (it was hard to see the "attempting to connect" console message as
> it was lost in with the other messaes...)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-434) the java shell should indicate connection status on command prompt

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717367#action_12717367 ] 

Benjamin Reed commented on ZOOKEEPER-434:
-----------------------------------------

+1 looks good! (we should probably open a jira to start creating tests for the shell.)

> the java shell should indicate connection status on command prompt
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-434
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-434
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.2.0
>            Reporter: Patrick Hunt
>            Assignee: Henry Robinson
>            Priority: Minor
>         Attachments: ZOOKEEPER-434.patch
>
>
> it would be very useful if the java shell showed the current connection status as part of the command prompt.
> this shows itself in particular for the following use case:
> I attempted to connect a java shell to a remote cluster that was unavailable, when I run the first command "ls /" on
> the cluster the shell hangs. It would be nice if the shell indicated connection status in the prompt and make it more
> clear that the shell is currently not connected. (it was hard to see the "attempting to connect" console message as
> it was lost in with the other messaes...)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.