You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Aaron Mulder <am...@alumni.princeton.edu> on 2005/07/01 02:31:16 UTC

Test Breakage

	The tomcat-builder is getting a test failure in something related 
to web services.

	The openejb/core module is getting a test failure in something 
related to web services.

	Since we just got the "big" web services tests to pass, I assume 
this means our internal tests haven't kept up with the latest web services 
code changes.  In any case, can someone look at these?

Thanks,
	Aaron 

Re: Test Breakage

Posted by David Jencks <da...@yahoo.com>.
I've fixed both these problems. I'd appreciate jeff reviewing the 
tomcat builder change: there may be a more efficient way of 
implementing this.

These changes make wsdl-rewriting work for tomcat.

thanks
david jencks

On Jul 1, 2005, at 11:26 AM, David Jencks wrote:

> I'm working on the ejb problem, and will look at the tomcat problem 
> after that.  There's a bug... don't know how extensive the fix is yet 
> (probably small).
>
> thanks
> david jencks
>
> On Jun 30, 2005, at 6:56 PM, Jeff Genender wrote:
>
>> I am in Monterey right now...I can jump on Tomcat as soon as I get 
>> back (unless someone else (David Jencks ;-) ) wants to fix it before 
>> then.
>>
>> Jeff
>>
>> Aaron Mulder wrote:
>>> 	The tomcat-builder is getting a test failure in something related 
>>> to web services.
>>> 	The openejb/core module is getting a test failure in something 
>>> related to web services.
>>> 	Since we just got the "big" web services tests to pass, I assume 
>>> this means our internal tests haven't kept up with the latest web 
>>> services code changes.  In any case, can someone look at these?
>>> Thanks,
>>> 	Aaron
>>
>


Re: Test Breakage

Posted by David Jencks <da...@yahoo.com>.
I'm working on the ejb problem, and will look at the tomcat problem 
after that.  There's a bug... don't know how extensive the fix is yet 
(probably small).

thanks
david jencks

On Jun 30, 2005, at 6:56 PM, Jeff Genender wrote:

> I am in Monterey right now...I can jump on Tomcat as soon as I get 
> back (unless someone else (David Jencks ;-) ) wants to fix it before 
> then.
>
> Jeff
>
> Aaron Mulder wrote:
>> 	The tomcat-builder is getting a test failure in something related to 
>> web services.
>> 	The openejb/core module is getting a test failure in something 
>> related to web services.
>> 	Since we just got the "big" web services tests to pass, I assume 
>> this means our internal tests haven't kept up with the latest web 
>> services code changes.  In any case, can someone look at these?
>> Thanks,
>> 	Aaron
>


Re: Test Breakage

Posted by Aaron Mulder <am...@alumni.princeton.edu>.
	If you're not doing a full multiproject build, you may have
trouble where we haven't checked in a fresh set of snapshots -- the
builder change affected both Geronimo and OpenEJB in any case.

Aaron

On Fri, 1 Jul 2005, Jacek Laskowski wrote:
> Aaron Mulder wrote:
> > 	No -- I saw a test failure, not a compile failure.  There was an 
> > interface change to the builders recently -- perhaps you should do a full 
> > checkout and rebuild.
> 
> Good catch! Will do, but... Shouldn't maven take care of it? It's 
> downloading the required jars so why didn't it avoid the failures? Our 
> current project structure is composed of separate maven subprojects and 
> maven doesn't even consider one already built SNAPSHOT to be uptodate 
> and downloads it again. I wonder how much of the build troubles are ours 
> than Maven's?
> 
> > Aaron
> 
> Jacek
> 
> 

Re: Test Breakage

Posted by Jacek Laskowski <jl...@apache.org>.
Aaron Mulder wrote:
> 	No -- I saw a test failure, not a compile failure.  There was an 
> interface change to the builders recently -- perhaps you should do a full 
> checkout and rebuild.

Good catch! Will do, but... Shouldn't maven take care of it? It's 
downloading the required jars so why didn't it avoid the failures? Our 
current project structure is composed of separate maven subprojects and 
maven doesn't even consider one already built SNAPSHOT to be uptodate 
and downloads it again. I wonder how much of the build troubles are ours 
than Maven's?

> Aaron

Jacek


Re: Test Breakage

Posted by Aaron Mulder <am...@alumni.princeton.edu>.
	No -- I saw a test failure, not a compile failure.  There was an 
interface change to the builders recently -- perhaps you should do a full 
checkout and rebuild.

Aaron

On Fri, 1 Jul 2005, Jacek Laskowski wrote:
> Jeff Genender wrote:
> > I am in Monterey right now...I can jump on Tomcat as soon as I get back 
> > (unless someone else (David Jencks ;-) ) wants to fix it before then.
> 
> Hehe, if we had got to know when you would be back, it would have been 
> much easier to decide whether to jump on or not. Noone (including me) 
> wants to compete against Dave for his lightning-fast code fixes ;)
> 
> (Aaron, see a question below)
> 
> $ maven m:update
>   __  __
> |  \/  |__ _Apache__ ___
> | |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
> |_|  |_\__,_|\_/\___|_||_|  v. 1.0.2
> 
> build:start:
> 
> m:update:
> ...
> BUILD SUCCESSFUL
> Total time: 4 minutes 59 seconds
> Finished at: Fri Jul 01 09:44:37 CEST 2005
> 
> $ cd modules/tomcat-builder
> $ maven rebuild
> ...
> java:compile:
>      [touch] Creating 
> C:\projs\geronimo\modules\tomcat-builder\target\xmlbeans\tstamp
>      [depend] Deleted 0 out of date files in 0 seconds
>      [echo] Compiling to 
> c:\projs\geronimo\modules\tomcat-builder/target/classes
>      [javac] Compiling 10 source files to 
> C:\projs\geronimo\modules\tomcat-builder\target\classes
> C:\projs\geronimo\modules\tomcat-builder\src\java\org\apache\geronimo\tomcat\deployment\TomcatModuleBuilder.java:115: 
> org.apache.geronimo.tomcat.deployment.Tomc
> atModuleBuilder is not abstract and does not override abstract method 
> createModule(java.lang.Object,java.util.jar.JarFile,java.lang.String,java.net.URL,java.net
> .URI) in org.apache.geronimo.j2ee.deployment.ModuleBuilder
> public class TomcatModuleBuilder implements ModuleBuilder {
>         ^
> C:\projs\geronimo\modules\tomcat-builder\src\java\org\apache\geronimo\tomcat\deployment\TomcatModuleBuilder.java:185: 
> parseWebServiceDescriptor(java.net.URL,jav
> a.util.jar.JarFile,boolean) in 
> org.apache.geronimo.j2ee.deployment.WebServiceBuilder cannot be applied 
> to (java.net.URL,java.util.jar.JarFile,boolean,java.util.
> Map)
>                  portMap = 
> webServiceBuilder.parseWebServiceDescriptor(wsDDUrl, moduleFile, false, 
> servletNameToPathMap);
>                                             ^
> Note: * uses or overrides a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> 2 errors
> 
> Is that what you're facing? It's almost 10 CET, so I think most of 
> Geronimos felt asleep. It's my show time - let me tackle with the issue 
> before Dave wakes up and sort it out during his breakfest ;)
> 
> > Jeff
> 
> Jacek
> 
> 

Re: Test Breakage

Posted by Jacek Laskowski <jl...@apache.org>.
Jeff Genender wrote:
> I am in Monterey right now...I can jump on Tomcat as soon as I get back 
> (unless someone else (David Jencks ;-) ) wants to fix it before then.

Hehe, if we had got to know when you would be back, it would have been 
much easier to decide whether to jump on or not. Noone (including me) 
wants to compete against Dave for his lightning-fast code fixes ;)

(Aaron, see a question below)

$ maven m:update
  __  __
|  \/  |__ _Apache__ ___
| |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
|_|  |_\__,_|\_/\___|_||_|  v. 1.0.2

build:start:

m:update:
...
BUILD SUCCESSFUL
Total time: 4 minutes 59 seconds
Finished at: Fri Jul 01 09:44:37 CEST 2005

$ cd modules/tomcat-builder
$ maven rebuild
...
java:compile:
     [touch] Creating 
C:\projs\geronimo\modules\tomcat-builder\target\xmlbeans\tstamp
     [depend] Deleted 0 out of date files in 0 seconds
     [echo] Compiling to 
c:\projs\geronimo\modules\tomcat-builder/target/classes
     [javac] Compiling 10 source files to 
C:\projs\geronimo\modules\tomcat-builder\target\classes
C:\projs\geronimo\modules\tomcat-builder\src\java\org\apache\geronimo\tomcat\deployment\TomcatModuleBuilder.java:115: 
org.apache.geronimo.tomcat.deployment.Tomc
atModuleBuilder is not abstract and does not override abstract method 
createModule(java.lang.Object,java.util.jar.JarFile,java.lang.String,java.net.URL,java.net
.URI) in org.apache.geronimo.j2ee.deployment.ModuleBuilder
public class TomcatModuleBuilder implements ModuleBuilder {
        ^
C:\projs\geronimo\modules\tomcat-builder\src\java\org\apache\geronimo\tomcat\deployment\TomcatModuleBuilder.java:185: 
parseWebServiceDescriptor(java.net.URL,jav
a.util.jar.JarFile,boolean) in 
org.apache.geronimo.j2ee.deployment.WebServiceBuilder cannot be applied 
to (java.net.URL,java.util.jar.JarFile,boolean,java.util.
Map)
                 portMap = 
webServiceBuilder.parseWebServiceDescriptor(wsDDUrl, moduleFile, false, 
servletNameToPathMap);
                                            ^
Note: * uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
2 errors

Is that what you're facing? It's almost 10 CET, so I think most of 
Geronimos felt asleep. It's my show time - let me tackle with the issue 
before Dave wakes up and sort it out during his breakfest ;)

> Jeff

Jacek


Re: Test Breakage

Posted by Jeff Genender <jg...@savoirtech.com>.
I am in Monterey right now...I can jump on Tomcat as soon as I get back 
(unless someone else (David Jencks ;-) ) wants to fix it before then.

Jeff

Aaron Mulder wrote:
> 	The tomcat-builder is getting a test failure in something related 
> to web services.
> 
> 	The openejb/core module is getting a test failure in something 
> related to web services.
> 
> 	Since we just got the "big" web services tests to pass, I assume 
> this means our internal tests haven't kept up with the latest web services 
> code changes.  In any case, can someone look at these?
> 
> Thanks,
> 	Aaron