You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Peter Samuelson <pe...@p12n.org> on 2006/10/12 08:25:25 UTC

Re: svn commit: r21888 - trunk

[dlr@tigris.org]
> Modified: trunk/Makefile.in

> +clean-javahl:
> +	rm -rf $(javahl_java_PATH) $(javahl_javah_PATH) @JAVAHL_OBJDIR@:$(libdir)

I'm guessing you meant that line without the ":$(libdir)".

Re: svn commit: r21888 - trunk

Posted by Daniel Rall <dl...@collab.net>.
On Thu, 12 Oct 2006, Malcolm Rowe wrote:

> On Thu, Oct 12, 2006 at 08:01:42AM -0700, Daniel Rall wrote:
> > > > Modified: trunk/Makefile.in
> > > 
> > > > +clean-javahl:
> > > > +	rm -rf $(javahl_java_PATH) $(javahl_javah_PATH) @JAVAHL_OBJDIR@:$(libdir)
> > > 
> > > I'm guessing you meant that line without the ":$(libdir)".
> > 
> > No, but the ":" character should be a "/".  Together those two expand
> > to "subversion/bindings/java/javahl/native/.libs", which is a libtool
> > directory I want to delete during a clean build.  I definitely don't
> > want to delete the "native" directory, which contains the C++ and C
> > code for the JNI bindings.
> 
> Uh, isn't $(libdir) typically something like /usr/local/lib?  I'm not
> following how this would work.

EINSUFFICIENTCAFFEINE

Yup, Peter was completely right.  (I'd already corrected this in r21899.)

Re: svn commit: r21888 - trunk

Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Thu, Oct 12, 2006 at 08:01:42AM -0700, Daniel Rall wrote:
> > > Modified: trunk/Makefile.in
> > 
> > > +clean-javahl:
> > > +	rm -rf $(javahl_java_PATH) $(javahl_javah_PATH) @JAVAHL_OBJDIR@:$(libdir)
> > 
> > I'm guessing you meant that line without the ":$(libdir)".
> 
> No, but the ":" character should be a "/".  Together those two expand
> to "subversion/bindings/java/javahl/native/.libs", which is a libtool
> directory I want to delete during a clean build.  I definitely don't
> want to delete the "native" directory, which contains the C++ and C
> code for the JNI bindings.

Uh, isn't $(libdir) typically something like /usr/local/lib?  I'm not
following how this would work.

Regards,
Malcolm

Re: svn commit: r21888 - trunk

Posted by Daniel Rall <dl...@collab.net>.
On Thu, 12 Oct 2006, Peter Samuelson wrote:

> 
> [dlr@tigris.org]
> > Modified: trunk/Makefile.in
> 
> > +clean-javahl:
> > +	rm -rf $(javahl_java_PATH) $(javahl_javah_PATH) @JAVAHL_OBJDIR@:$(libdir)
> 
> I'm guessing you meant that line without the ":$(libdir)".

No, but the ":" character should be a "/".  Together those two expand
to "subversion/bindings/java/javahl/native/.libs", which is a libtool
directory I want to delete during a clean build.  I definitely don't
want to delete the "native" directory, which contains the C++ and C
code for the JNI bindings.